NV reverse prime HDMI has no output

[Kai-Chuan Hsieh]

[Impact]
The X failed to load glamoregl module on Dell's new platforms, the module is needed by NV dGPU.

十二 05 10:04:55 /usr/libexec/gdm-x-session[1292]: (II) LoadModule: "glamoregl"
十二 05 10:04:55 /usr/libexec/gdm-x-session[1292]: (II) Loading /usr/lib/xorg/modules/libglamoregl.so
十二 05 10:04:55 /usr/libexec/gdm-x-session[1292]: (II) Module glamoregl: vendor="X.Org Foundation"
十二 05 10:04:55 /usr/libexec/gdm-x-session[1292]: compiled for 1.21.1.3, module version = 1.0.1
十二 05 10:04:55 /usr/libexec/gdm-x-session[1292]: ABI class: X.Org ANSI C Emulation, version 0.4
十二 05 10:04:55 /usr/libexec/gdm-x-session[1292]: MESA: warning: Driver does not support the 0xa78b PCI ID.
十二 05 10:04:55 /usr/libexec/gdm-x-session[1292]: (II) modeset(0): Refusing to try glamor on llvmpipe
十二 05 10:04:55 /usr/libexec/gdm-x-session[1292]: (II) modeset(0): glamor initialization failed

[Fix]

The upstream PR added missing ID for the platforms.
https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16320/
https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17569/

After creating the test build to include the PR above, ODM verified passed on those platform.

[Test case]
Install fixed package on the systems, check that display works.

[Where things could go wrong]
Although one commit drops a couple of pci-id's, they were already dropped from the jammy kernel for lp1990242

[Chris Halse Rogers (raof)]

An upload of mesa to jammy-proposed has been rejected from the upload queue for the following reason: "Looks like there's unintentional changes in src/mesa/formats.csv".

[Chris Halse Rogers (raof)]

Is there a particular reason why we should take the PCI-ID removals? They seem safe enough, though.

[Chris Halse Rogers (raof)]

Hello Kai-Chuan, or anyone else affected,

Accepted mesa into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/mesa/22.0.5-0ubuntu0.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Ubuntu SRU Bot (ubuntu-sru-bot)]

All autopkgtests for the newly accepted mesa (22.0.5-0ubuntu0.2) for jammy have finished running.
The following regressions have been reported in tests triggered by the package:

mutter/42.5-0ubuntu1 (arm64)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/jammy/update_excuses.html#mesa

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

[Timo Aaltonen (tjaalton)]

kchsieh: please verify this bugfix

[Kai-Chuan Hsieh (kchsieh)]

Verify on GAI5-DVT1.1-D9_202211-30857. Intel graphic ID [8086:a78b]

1. enable proposed
2. update mesa to 22.0.5-0ubuntu0.2
3. reboot
4. check the xorg log, that the glamoregl can be loaded successfully.

[Andreas Hasenack (ahasenack)]

Hello Kai-Chuan, or anyone else affected,

Accepted mesa into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/mesa/22.0.5-0ubuntu0.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Andreas Hasenack (ahasenack)]

I ran update-maintainer on the mesa source and uploaded again.

Give the removal of PCI IDs, and the vague statement in the "Where things could go wrong" section of the bug description, I'd like to see a more clear statement saying that these IDs are already not available in the jammy kernel, and as such there is an even lesser risk of regression due to that.

[Timo Aaltonen (tjaalton)]

the pci-id's were dropped from the jammy kernel for lp1990242

[Andreas Hasenack (ahasenack)]

I think this bug/SRU snowballed. Let's take a step back.

It started with fixing two bugs: this one, and bug #1972977. At some point later, #1972977 was deemed not really fixed[1], and was dropped in the 0ubuntu0.3 upload[2].

That upload failed to build in jammy-proposed on arm64[3] and amd64[4].

It was deemed to be a problem introduced by some other jammy-proposed upload (unclear which one).

A new upload was made to jammy unapproved[5] (still missing an update-maintainer run, btw), stating:

Changes:
 mesa (22.0.5-0ubuntu0.4) jammy; urgency=medium
 .
   * Add a patch to build with a newer directx-headers. (LP: #1998893)
 .
 mesa (22.0.5-0ubuntu0.3) jammy; urgency=medium
 .
   * crocus-fix-leak-in-query-code.patch: Drop the patch so the other fix
     can get through to updates.
 .
 mesa (22.0.5-0ubuntu0.2) jammy; urgency=medium
 .
   * crocus-fix-leak-in-query-code.patch: Fix gnome-shell crashing on
     older Intel hw. (LP: #1972977)
   * patches: Update pci-id's for ADL-S/RPL-S. (LP: #1998893)

That is quite a big patch in an area I know nothing about. My concerns are:
- shouldn't we have a separate bug for the FTBFS? This bug here is about PCI IDs.
- what is the other package in jammy proposed that is breaking this build? Must it be released at the same time as mesa?
- the original PR[6] mentioned in the DEP3 header of the FTBFS patch is huge and complex, is that (and the backport done here) really the minimal fix for the FTBFS?
- what are the other changes incurring via this patch, now the the build is fixed? What else is changing? What is the risk analysis of that change?

I feel there is a lot of missing information, but it could just be because I'm not familiar with mesa and the graphic/3d stack. So I prefer to leave this review for another SRU team member, but thought I should leave this comment here instead of just "disappearing" :)

1. https://bugs.launchpad.net/ubuntu/+source/mesa/+bug/1972977/comments/15
2. https://launchpad.net/ubuntu/+source/mesa/22.0.5-0ubuntu0.3
3. https://launchpad.net/ubuntu/+source/mesa/22.0.5-0ubuntu0.3/+build/25458695
4. https://launchpad.net/ubuntu/+source/mesa/22.0.5-0ubuntu0.3/+build/25458694
5. https://launchpadlibrarian.net/645131833/mesa_22.0.5-0ubuntu0.4_source.changes
6. https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15751/diffs

[Timo Aaltonen (tjaalton)]

andreas, directx-headers was dropped instead, and that upload rejected, so the current version in proposed builds and is ready for updates. sorry for the hassle, this was supposed to be the correct path to follow all along :)

[Launchpad Janitor (janitor)]

This bug was fixed in the package mesa - 22.0.5-0ubuntu0.3

---------------
mesa (22.0.5-0ubuntu0.3) jammy; urgency=medium

  * crocus-fix-leak-in-query-code.patch: Drop the patch so the other fix
    can get through to updates.

mesa (22.0.5-0ubuntu0.2) jammy; urgency=medium

  * crocus-fix-leak-in-query-code.patch: Fix gnome-shell crashing on
    older Intel hw. (LP: #1972977)
  * patches: Update pci-id's for ADL-S/RPL-S. (LP: #1998893)

 -- Timo Aaltonen <email address hidden> Thu, 05 Jan 2023 10:45:40 +0200

[Timo Aaltonen (tjaalton)]

The verification of the Stable Release Update for mesa has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.