egl-platform-mir.patch: Incorrect (backwards) pixel formats are accepted
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
mesa (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
egl-platform-
I noticed this recently. GBM reports some pixel formats as supported but if you use them the colours come out backwards. Turns out it's just our patch reporting incorrect format support ...
--- a/src/gbm/
+++ b/src/gbm/
@@ -528,9 +528,11 @@ gbm_dri_
switch (format) {
case GBM_BO_
case GBM_FORMAT_
+ case GBM_FORMAT_
break;
case GBM_BO_
case GBM_FORMAT_
+ case GBM_FORMAT_
if (usage & GBM_BO_USE_SCANOUT)
return 0;
break;
Related branches
- PS Jenkins bot (community): Approve (continuous-integration)
- Kevin DuBois (community): Approve
- Robert Carr (community): Approve
-
Diff: 1191 lines (+556/-130)24 files modifiedexamples/eglapp.c (+50/-23)
examples/image_renderer.cpp (+1/-0)
examples/multiwin.c (+73/-21)
include/common/mir_toolkit/common.h (+39/-15)
playground/demo-shell/typo/typo_glcache.cpp (+1/-0)
src/platform/graphics/pixel_format_utils.cpp (+59/-36)
src/platforms/android/server/android_buffer_allocator.cpp (+2/-1)
src/platforms/android/server/android_format_conversion-inl.h (+6/-2)
src/platforms/mesa/server/common/buffer_allocator.cpp (+23/-17)
src/platforms/mesa/server/common/buffer_allocator.h (+0/-1)
src/platforms/mesa/server/common/gbm_buffer.cpp (+42/-0)
src/platforms/mesa/server/common/shm_buffer.cpp (+76/-4)
src/platforms/mesa/server/common/shm_buffer.h (+2/-0)
src/utils/screencast.cpp (+8/-0)
tests/include/mir/test/doubles/mock_gbm.h (+3/-0)
tests/include/mir/test/doubles/mock_gl.h (+1/-0)
tests/mir_test_doubles/mock_gbm.cpp (+9/-0)
tests/mir_test_doubles/mock_gl.cpp (+6/-0)
tests/unit-tests/graphics/android/test_android_buffer_allocator.cpp (+11/-1)
tests/unit-tests/graphics/android/test_pixel_format.cpp (+6/-3)
tests/unit-tests/graphics/mesa/common/test_buffer_allocator.cpp (+2/-0)
tests/unit-tests/graphics/mesa/common/test_shm_buffer.cpp (+110/-6)
tests/unit-tests/graphics/test_graphics_platform.cpp (+2/-0)
tests/unit-tests/graphics/test_pixel_format_utils.cpp (+24/-0)
description: | updated |
tags: | added: mir-mesa |
tags: |
added: egl-platform-mir removed: mir-mesa |
Linked a loosely related branch, where the bug was first observed.