Mir Mesa EGL platform leaks memory with every frame

Bug #1418486 reported by Alexandros Frantzis on 2015-02-05
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mir
Invalid
High
Alexandros Frantzis
mesa (Ubuntu)
High
Alexandros Frantzis

Bug Description

The Mir Mesa EGL platform leaks memory with every frame. This is the result of incorrect handling of the buffer objects we create from the incoming Mir buffers.

The problem is exhibited in the attached 'massif.out.leak' file. An excerpt from the result of ms_print for this file:

--------------------------------------------------------------------------------
  n time(ms) total(B) useful-heap(B) extra-heap(B) stacks(B)
--------------------------------------------------------------------------------
 23 11,593 4,965,432 4,503,871 461,561 0
 24 12,058 4,971,256 4,509,023 462,233 0
 25 12,640 4,978,536 4,515,463 463,073 0
 26 13,222 4,985,832 4,521,903 463,929 0
 27 13,804 4,993,112 4,528,343 464,769 0
 28 14,386 5,000,392 4,534,783 465,609 0
 29 14,735 5,004,760 4,538,647 466,113 0
 30 15,435 5,013,384 4,546,326 467,058 0
 31 16,016 5,020,776 4,552,815 467,961 0
 32 16,780 5,030,360 4,561,279 469,081 0
 33 17,163 5,035,144 4,565,511 469,633 0

I have attached a patch (fix-mir-mesa-egl-gbm-bo-leak.diff) to get some wider review before creating a final patch for the ubuntu package. With this patch the leak is fixed as shown in the attached 'massif.out.fixed' file:

--------------------------------------------------------------------------------
  n time(ms) total(B) useful-heap(B) extra-heap(B) stacks(B)
--------------------------------------------------------------------------------
 56 11,787 4,859,080 4,410,063 449,017 0
 57 11,920 4,859,080 4,410,063 449,017 0
 58 12,053 4,859,080 4,410,063 449,017 0
 59 12,186 4,859,080 4,410,063 449,017 0
 60 12,320 4,859,080 4,410,063 449,017 0
 61 12,453 4,859,080 4,410,063 449,017 0
 62 12,586 4,859,080 4,410,063 449,017 0
 63 12,719 4,859,080 4,410,063 449,017 0
 64 12,852 4,859,080 4,410,063 449,017 0
 65 12,985 4,859,080 4,410,063 449,017 0

Alexandros Frantzis (afrantzis) wrote :
Changed in mesa (Ubuntu):
assignee: nobody → Alexandros Frantzis (afrantzis)
Changed in mir:
status: New → In Progress
Changed in mesa (Ubuntu):
status: New → In Progress
Changed in mir:
status: In Progress → New
status: New → In Progress
Changed in mir:
milestone: none → 0.12.0
no longer affects: mir
Changed in mesa (Ubuntu):
importance: Undecided → High

The attachment "Proposed fix for Mir Mesa EGL memory leak" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

tags: added: patch
Changed in mir:
status: New → In Progress
assignee: nobody → Alexandros Frantzis (afrantzis)
importance: Undecided → High
Changed in mir:
milestone: none → 0.12.0
Alexandros Frantzis (afrantzis) wrote :
tags: removed: patch
Alexandros Frantzis (afrantzis) wrote :

Fix released in package mesa-10.4.2-2ubuntu3 .

Changed in mir:
status: In Progress → Fix Released
Changed in mesa (Ubuntu):
status: In Progress → Fix Released
Changed in mir:
milestone: 0.12.0 → none
status: Fix Released → Invalid
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers