[FFe] Include Temporal Deinterlacer into libvdpau1-drivers-mesa

Bug #1287326 reported by Peter Frühberger on 2014-03-03
This bug affects 3 people
Affects Status Importance Assigned to Milestone
mesa (Ubuntu)

Bug Description

Beginning with Ubuntu 14.04 mesa will be shipping with vdpau drivers that can be used by e.g. radeon / radeonsi OSS drivers. This allows low power systems, like AMD E350, Kabini and so on to playback Full HD h264, vc1, mpeg4 and mpeg2 videos.

Sadly the world is not only progressive. LiveTV is most of the time broadcasted as 1080i h264 or 576i mpeg2, which means, that it has to be deinterlaced after decoding. In current mesa vdpau (as is in 10.1) code only simple Bobbing [a] is implemented. This low quality method produces one full frame out of every field. This introduces flickering first and last line, when not taking care to cut those correctly.

Grigori Goronzy (zgreg) has developed a high quality / state of the art Temporal deinterlacer [1][a] for mesa, which introduces far better quality than simple bobbing would do.

This deinterlacer was already included into mesa master and was furthermore tested since more than 4 months via a special ppa in combination with xbmc [2]. This ppa was used by some thousand unique people.

We would really like to see this deinterlacer in Ubuntu 14.04. This would make the new version a great basis for every htpc out there.

I will attach the current patches, fetched via git format-patch out of mesa git tree.

[a] http://en.wikipedia.org/wiki/Deinterlacing (Motion Adaptive vs. Bobbing)
[1] Original Patch: http://anzwix.com/a/Mesa/StvdpauAddSupportForDEINTERLACETEMPORAL
[2] http://forum.xbmc.org/showthread.php?tid=174854

The attachment "0001-st-vdpau-add-support-for-DEINTERLACE_TEMPORAL.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

tags: added: patch
summary: - FFe Include Temporal Deinterlacer into libvdpau1-drivers-mesa
+ [FFe] Include Temporal Deinterlacer into libvdpau1-drivers-mesa
description: updated
description: updated
Iain Lane (laney) wrote :

It sounds reasonable. Please could you subscribe to bug reports and watch out for problems coming up. Ack.

Changed in mesa (Ubuntu):
status: New → Triaged
importance: Undecided → Medium
greg (grigorig) wrote :

FWIW, here's a quick comparison, bob vs temporal deinterlacing:


Notice the increased sharpness in the second image.

I've got to admit, i'm struggling to see the improvement, and I *want* to, agreeing with the request of this bug.

But perhaps the conversion to jpeg is wiping it out? Should be using a lossless capture there, I reckon.

Hint: Make both fullscreen and check the power supply lines.

Bob clearly has artifacts, e.g. line is not even continuous differentiable vs temporal: all fine

ok, i *can* see the improvement if i view the images at full size switching between browser tabs (which the site's own page doesn't seem to let you do, bizarrely; initially i'd just thought they were SD captures). Yes, 2nd image is better; but *still* it would probably be better reflection if not captured lossily.

Maarten Lankhorst (mlankhorst) wrote :

Conversion to .jpg is probably destroying it. But yes it's very visible in mostly static images. 'bob' deinterlacing is called that way because objects bob up and down when top and bottom fields are shown alternately. The horizontal resolution of each field is only half a frame, so vertical sharpness is lost. Both effects aren't easy to show in a single image, but it's VERY visible when playing any kind of movie.

Maarten Lankhorst (mlankhorst) wrote :

A fix for this is only showing the top or bottom fields, but that means losing half of the horizontal resolution.

There are other advanced methods, e.g. combining temporal information with spatial information, that you find in the nvidia proprietary implementation for example.

Also intel tries to get something done in their MADI and MACI implementations, but with only one forward reference i am not so sure about the quality outcome.

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package mesa - 10.1.0~rc3-0ubuntu1

mesa (10.1.0~rc3-0ubuntu1) trusty; urgency=medium

  [ Maarten Lankhorst ]
  * Merge from unreleased debian-experimental.
  * Enable egl, libopenvg, gbm and vdpau for all archs.
    - This simplifies the build rules considerably, and
      is closer to debian behavior.
  * Cherry pick fixes for playback of interlaced videos. (LP: #1287326)
  * Cherry pick fixes for crashes related to vdpau interop.
 -- Maarten Lankhorst <email address hidden> Tue, 25 Feb 2014 14:29:26 +0100

Changed in mesa (Ubuntu):
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers