FTBFS on armhf due to alignment problem

Bug #1780838 reported by Robie Basak on 2018-07-09
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Memcached Mirror
Unknown
Unknown
memcached (Ubuntu)
Medium
Robie Basak

Related branches

dormando (dormando) wrote :

https://github.com/memcached/memcached/pull/416

can you try this branch, please? I need to audit it twice and clean it up a little bit, but the tests now pass on my rpi3.

Robie Basak (racb) wrote :

It failed, but that bug is possibly a 1.5.6 thing already fixed in 1.5.8. I'll try again with 1.5.8.

dormando (dormando) wrote :

1.5.7 contained another ARM fix: https://github.com/memcached/memcached/wiki/ReleaseNotes157

Also 1.5.9 is current, now. there's one important segfault fix for binprot.

thanks!

Robie Basak (racb) wrote :

1.5.9 with your trial patch succeeded on all architectures, including armhf, with the exception of i386. Here's the i386 build log: https://launchpadlibrarian.net/382382000/buildlog_ubuntu-cosmic-i386.memcached_1.5.9-0ubuntu1~ppa1_BUILDING.txt.gz

dormando (dormando) wrote :

did i386 fail with 1.5.9 or is this only with the patch? I don't understand why flush-all.t would fail, it doesn't use the modified code at all

dormando (dormando) wrote :

the i386 failure should be transient. think I can see how that would happen, and can make it less likely by just bumping the sleep, since if this test is running on a single core bad prioritization could have the internal timer fail to update in time.

dormando (dormando) wrote :

okay: the 'next' branch now has this change merged in (I couldn't find any problem with it and re-ran the tests on the rpi3 a hundred times). I also include something that should appease flush-all.t for now.

If this passes all your builds I'll be stamping it as 1.5.10 immediately.

thanks!

Robie Basak (racb) wrote :

Thanks!

I pushed 1.5.9-0ubuntu1~ppa2 to my experimental PPA: https://launchpad.net/~racb/+archive/ubuntu/experimental/+packages

This drops your earlier trial patch, and adds all commits from 1.5.9..next from git://github.com/memcached/memcached as patches. This should be identical to what you'll get if you release next as 1.5.10. If this works on all arches, then "next" should be good from Ubuntu's perspective I think.

Robie Basak (racb) wrote :

Success. Builds (and therefore tests) succeeded on all architectures my PPA has.

dormando (dormando) wrote :

1.5.10 is released. I hope we can all agree to ship it :)

Thanks again for your patience.

Robie Basak (racb) wrote :

I've prepared an update for Ubuntu Cosmic, now pending peer review.

Do you think 1.5.10 needs to go into 18.04 or any earlier Ubuntu stable release? If so, we can do that if all the changes comply with Ubuntu's stable release update policy (documented at https://wiki.ubuntu.com/StableReleaseUpdates).

dormando (dormando) wrote :

almost all of the changes inbetween 1.5.6 and 1.5.10 are in seccomp or extstore, neither of which ubuntu enables. even then, the rest are all bugfixes or buildfixes or ARM fixes.

there is one important SASL fix that went into 1.5.9ish that would be great to stick into 18.04, so if at all possible I would appreciate an update. it's a very old bug that came up a couple times over the years before finally being fixed. It can be tripped by the major memcached java client, and a lot more people use SASL now than they used to.

either way, thanks!

Changed in memcached (Ubuntu):
assignee: nobody → Robie Basak (racb)
status: Triaged → In Progress
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package memcached - 1.5.10-0ubuntu1

---------------
memcached (1.5.10-0ubuntu1) cosmic; urgency=medium

  * New upstream release.
  * Includes fixes for various failures on various architectures,
    including the fix for alignment issues on some ARM platforms for
    chunked items (LP: #1780838).

 -- Robie Basak <email address hidden> Mon, 13 Aug 2018 13:10:37 +0100

Changed in memcached (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.