Can't use # as the delimiter between key prefixes and IDs.

Bug #1005821 reported by Kamil Swiatkowski on 2012-05-29
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Memcached Mirror
Unknown
Unknown
memcached (Debian)
Fix Released
Unknown
memcached (Ubuntu)
Low
Clint Byrum

Bug Description

Hi,

memcached daemon has an option to specify custom character as the delimeter between key prefixes and IDs. # character cannot be used because of limitation of /usr/share/memcached/scripts/start-memcached. This startup script parses /etc/memcached_*.conf files and treats every line with # sign as a comment, which is wrong in case of line like below:
-D #

Simple patch attached. I know it's not perfect but it works :)

Related branches

Kamil Swiatkowski (kswia) wrote :
Chuck Short (zulcss) wrote :

Which version does this apply for?

Changed in memcached (Ubuntu):
importance: Undecided → Wishlist
status: New → Incomplete

The attachment "start-memcached.diff" of this bug report has been identified as being a patch. The ubuntu-reviewers team has been subscribed to the bug report so that they can review the patch. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-reviewers team please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

tags: added: patch
Kamil Swiatkowski (kswia) wrote :

Sorry, I forgot to include version.

Version: 1.4.13-0ubuntu2 from precise

Launchpad Janitor (janitor) wrote :

[Expired for memcached (Ubuntu) because there has been no activity for 60 days.]

Changed in memcached (Ubuntu):
status: Incomplete → Expired
Changed in memcached (Ubuntu):
status: Expired → Confirmed
Clint Byrum (clint-fewbar) wrote :

Patch looks good to me. I don't see any problem with carrying it until upstream imports it, especially since I think distros are the only real users of start-memcached.

I forwarded it upstream and to Debian. Marking Triaged.

Changed in memcached (Ubuntu):
importance: Wishlist → Low
Changed in memcached (Ubuntu):
status: Confirmed → In Progress
assignee: nobody → Clint Byrum (clint-fewbar)
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package memcached - 1.4.13-0.1ubuntu2

---------------
memcached (1.4.13-0.1ubuntu2) quantal; urgency=low

  * d/p/start-memcached-fix-hash.patch: Apply patch to allow passing
    # as a value for memcached options such as -D to use # as a prefix
    delimiter for stats collection. (LP: #1005821)
 -- Clint Byrum <email address hidden> Sun, 29 Jul 2012 00:14:09 -0700

Changed in memcached (Ubuntu):
status: In Progress → Fix Released
Changed in memcached (Debian):
status: Unknown → Confirmed
Changed in memcached (Debian):
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.