[SRU] Save and Save as buttons do not save files in Blank comparison

Bug #1685216 reported by Norbert
4
This bug affects 1 person
Affects Status Importance Assigned to Milestone
meld
Fix Released
High
meld (Ubuntu)
New
Undecided
Unassigned

Bug Description

Steps to reproduce:
1. Start Meld 3.14.2 (3.14.2-1 on Ubuntu Xenial 16.04.2 LTS) from terminal.
2. Start "New Comparison" -> "File Comparison" -> "Blank Comparison"
3. Paste file contents from clipboard to left and right sides.
4. Press Save or Save as button on each side, select filepath for each side, press OK.
5. Try to exit from Meld (by Ctrl+Q). In opened window "Save changes to documents before closing?" click "Save".
6. Get errors in console:
Traceback (most recent call last):

File "/usr/lib/python2.7/dist-packages/meld/meldwindow.py", line 433, in on_menu_save_activate
    self.current_doc().save()
  File "/usr/lib/python2.7/dist-packages/meld/filediff.py", line 1823, in save
    self.save_file(pane)
  File "/usr/lib/python2.7/dist-packages/meld/filediff.py", line 1764, in save_file
    text = text.encode(encoding)
TypeError: encode() argument 1 must be string, not None
  File "/usr/lib/python2.7/dist-packages/meld/meldwindow.py", line 433, in on_menu_save_activate
    self.current_doc().save()
  File "/usr/lib/python2.7/dist-packages/meld/filediff.py", line 1823, in save
    self.save_file(pane)
  File "/usr/lib/python2.7/dist-packages/meld/filediff.py", line 1764, in save_file
    text = text.encode(encoding)
TypeError: encode() argument 1 must be string, not None
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/meld/filediff.py", line 1837, in on_file_save_button_clicked
    self.save_file(idx)
  File "/usr/lib/python2.7/dist-packages/meld/filediff.py", line 1764, in save_file
    text = text.encode(encoding)
TypeError: encode() argument 1 must be string, not None
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/meld/filediff.py", line 1837, in on_file_save_button_clicked
    self.save_file(idx)
  File "/usr/lib/python2.7/dist-packages/meld/filediff.py", line 1764, in save_file
    text = text.encode(encoding)
TypeError: encode() argument 1 must be string, not None
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/meld/meldwindow.py", line 299, in on_delete_event
    response = self.try_remove_page(page, appquit=1)
  File "/usr/lib/python2.7/dist-packages/meld/meldwindow.py", line 569, in try_remove_page
    response = page.on_delete_event(appquit)
  File "/usr/lib/python2.7/dist-packages/meld/filediff.py", line 915, in on_delete_event
    response = self.check_save_modified()
  File "/usr/lib/python2.7/dist-packages/meld/filediff.py", line 885, in check_save_modified
    if not self.save_file(i):
  File "/usr/lib/python2.7/dist-packages/meld/filediff.py", line 1764, in save_file
    text = text.encode(encoding)
TypeError: encode() argument 1 must be string, not None

7. Files are not saved.

Expected results:
Files are saved.

Actual results:
Files are not saved, got error in console.

ProblemType: Bug
DistroRelease: Ubuntu 16.04
Package: meld 3.14.2-1
ProcVersionSignature: Ubuntu 4.4.0-72.93-generic 4.4.49
Uname: Linux 4.4.0-72-generic x86_64
ApportVersion: 2.20.1-0ubuntu2.5
Architecture: amd64
CurrentDesktop: Unity
Date: Fri Apr 21 16:12:13 2017
InstallationDate: Installed on 2014-02-07 (1168 days ago)
InstallationMedia: Ubuntu 12.04.4 LTS "Precise Pangolin" - Release amd64 (20140204)
PackageArchitecture: all
SourcePackage: meld
UpgradeStatus: Upgraded to xenial on 2017-04-15 (5 days ago)

Revision history for this message
Norbert (nrbrtx) wrote :
Revision history for this message
Norbert (nrbrtx) wrote :

Bug is fixed in Ubuntu 16.10.
Please backport http://archive.ubuntu.com/ubuntu/pool/universe/m/meld/meld_3.16.3-1_all.deb to Xenial.

summary: - Save and Save as buttons do not save files
+ Save and Save as buttons do not save files in Blank comparison
summary: - Save and Save as buttons do not save files in Blank comparison
+ [SRU] Save and Save as buttons do not save files in Blank comparison
Changed in meld:
importance: Unknown → High
status: Unknown → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.