[MIR] mediaplayer-app

[Jim Hodapp]

[Availability]
 * Available in universe

[Rationale]
 * This package is required by Unity8

[Security]
 * No known security issues at this time. It has been reviewed by security in the past for use on the phone and is one of the oldest apps on the phone.

[Quality assurance]
 * This package has both unit tests and Autopilot tests.

[Dependencies]
 All dependencies are already in main with the exception of the following change needed:
 * MR: https://code.launchpad.net/~phablet-team/mediaplayer-app/mir-fixes/+merge/306350

[Standards compliance]
 * This package uses cmake and is properly translated.

[Maintenance]
 * This package is maintained by Canonical and actively in use on the phone images.

[Will Cooke (willcooke)]

Please hold on this one, we might not push for it to be in main this cycle.

[Will Cooke (willcooke)]

Sorry, ignore comment #1.

[Mathieu Trudel-Lapierre (cyphermox)]

I will review this one.

[Mathieu Trudel-Lapierre (cyphermox)]

Found some lintian warnings; but I wouldn't consider them blockers (but please see about fixing them):

N: Processing binary package mediaplayer-app-autopilot (version 0.20.5+16.10.20160921-0ubuntu1, arch all) ...
I: mediaplayer-app-autopilot: extended-description-is-probably-too-short
N: ----
N: Processing binary package mediaplayer-app (version 0.20.5+16.10.20160921-0ubuntu1, arch amd64) ...
I: mediaplayer-app: extended-description-is-probably-too-short
W: mediaplayer-app: binary-without-manpage usr/bin/mediaplayer-app

[Mathieu Trudel-Lapierre (cyphermox)]

Blocker:
Checking support status of binary dependencies...
 * libautopilot-qt binary and source package is in universe
 * python3-autopilot binary and source package is in universe

Now, we might not want mediaplayer-app-autopilot in main, it seems like only mediaplayer-app is really needed there?

Also, there are tests but they don't appear to be run as part of the build:
   dh_auto_test -O--parallel
 make -j4 test ARGS\+=-j4
make[1]: Entering directory '/«BUILDDIR»/mediaplayer-app-0.20.5+16.10.20160921/obj-x86_64-linux-gnu'
Running tests...
/usr/bin/ctest --force-new-ctest-process -j4
Test project /«BUILDDIR»/mediaplayer-app-0.20.5+16.10.20160921/obj-x86_64-linux-gnu
No tests were found!!!
make[1]: Leaving directory '/«BUILDDIR»/mediaplayer-app-0.20.5+16.10.20160921/obj-x86_64-linux-gnu'

Please fix the issues mentioned above ("fixing" the dependencies could be as simple as confirming that we don't need mediaplayer-app-autopilot in main). I didn't see other issues with this package for inclusion in main.

[Jim Hodapp (jhodapp)]

Let's keep the autopilot stuff out of main.

Here's an MR from renato that adds some build tests:

https://code.launchpad.net/~renatofilho/mediaplayer-app/add-unittest/+merge/306784

[Mathieu Trudel-Lapierre (cyphermox)]

Milestoning, this needs a new look to make sure it still requires a MIR and that it's ready for main.

[Mathieu Trudel-Lapierre (cyphermox)]

Unassigning, looks like we likely won't need a MIR at all.

[Jim Hodapp (jhodapp)]

We don't need this anymore, so switched to won't fix.