When calling Playlist.clear() onMediaRemoved is triggered for each track that is removed
Bug #1511385 reported by
Andrew Hayzen
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Canonical System Image |
Fix Released
|
Medium
|
John McAleely | ||
| media-hub (Ubuntu) |
Fix Released
|
Medium
|
Unassigned | ||
| media-hub (Ubuntu RTM) |
Fix Released
|
Medium
|
Unassigned | ||
Bug Description
When calling Playlist.clear() onMediaRemoved is triggered for each track that is removed, causing slowdown in the music-app's current implementation of storing the queue.
What happened:
1) Start the music-app
2) Click on a track to create a queue
3) From the header actions click "Clear queue"
4) Observe that for each track a onMediaRemoved signal is emitted
What I expected to happen:
At step 4) for a single onMediaRemoved for the whole range is emitted
A diff [0] for the music-app, so you can see the onMediaRemoved calls.
Related branches
lp:~phablet-team/media-hub/bg-playlist-fixes
- Jim Hodapp (community): Approve (code)
-
Diff: 703 lines (+237/-42)11 files modifiedinclude/core/media/track_list.h (+8/-0)
src/core/media/mpris/service.h (+12/-0)
src/core/media/mpris/track_list.h (+17/-0)
src/core/media/player_implementation.cpp (+12/-0)
src/core/media/service_skeleton.cpp (+22/-6)
src/core/media/track_list.cpp (+5/-0)
src/core/media/track_list_implementation.cpp (+25/-18)
src/core/media/track_list_skeleton.cpp (+102/-16)
src/core/media/track_list_skeleton.h (+4/-0)
src/core/media/track_list_stub.cpp (+29/-2)
src/core/media/track_list_stub.h (+1/-0)
| tags: | added: bgplaylist |
| no longer affects: | media-hub (Ubuntu) |
| no longer affects: | media-hub |
| Changed in canonical-devices-system-image: | |
| status: | New → Confirmed |
| Changed in qtubuntu-media (Ubuntu): | |
| status: | New → Triaged |
| Changed in qtubuntu-media (Ubuntu RTM): | |
| status: | New → Triaged |
| no longer affects: | qtubuntu-media (Ubuntu) |
| no longer affects: | qtubuntu-media (Ubuntu RTM) |
| Changed in media-hub (Ubuntu): | |
| status: | New → Triaged |
| Changed in media-hub (Ubuntu RTM): | |
| status: | New → Triaged |
| Changed in media-hub (Ubuntu): | |
| importance: | Undecided → Medium |
| Changed in media-hub (Ubuntu RTM): | |
| importance: | Undecided → Medium |
| Changed in canonical-devices-system-image: | |
| assignee: | nobody → John McAleely (john.mcaleely) |
| importance: | Undecided → Medium |
| milestone: | none → backlog |
| Changed in canonical-devices-system-image: | |
| status: | Confirmed → In Progress |
| Changed in media-hub (Ubuntu RTM): | |
| status: | Triaged → Fix Committed |
| Changed in canonical-devices-system-image: | |
| milestone: | backlog → ww02-2016 |
Revision history for this message
| Łukasz Zemczak (sil2100) wrote | #1 |
| Changed in media-hub (Ubuntu RTM): | |
| status: | Fix Committed → Fix Released |
| Changed in canonical-devices-system-image: | |
| status: | In Progress → Fix Committed |
| Changed in canonical-devices-system-image: | |
| status: | Fix Committed → Fix Released |
| Changed in media-hub (Ubuntu): | |
| status: | Triaged → Fix Released |
To post a comment you must log in.
This bug was fixed in the package media-hub 4.0.0+15.
---------------
media-hub (4.0.0+
[ Jim Hodapp ]
* Added move_track and various fixes for TrackList.
* Major bump for new TrackList API changes.
[ Alfonso Sanchez-Beato ]
* Make sure our iterator for the current track points to the right
place when (un)shuffling (LP #1510219). Fix crash when client tries
to set the player for a non-existing key. Do not add empty URIs to
the list (LP: #1511029). (LP: #1511073, #1511385, #1510219,
#1510227, #1511029)
-- Jim Hodapp <email address hidden> Wed, 18 Nov 2015 18:36:18 +0000