MPRIS is only partially implemented

Bug #1498962 reported by Alfonso Sanchez-Beato
36
This bug affects 7 people
Affects Status Importance Assigned to Milestone
Canonical System Image
Fix Released
Critical
John McAleely
media-hub (Ubuntu)
Fix Released
Critical
Jim Hodapp
media-hub (Ubuntu RTM)
Fix Released
Critical
Jim Hodapp

Bug Description

* Metadata property from org.mpris.MediaPlayer2.Player is not exported (see service_skeleton.cpp)

* Some DBus calls to object /org/mpris/MediaPlayer2 do not return anything, like:

dbus-send --print-reply --type=method_call --dest=core.ubuntu.media.Service /org/mpris/MediaPlayer2 org.freedesktop.DBus.Properties.GetAll string:org.mpris.MediaPlayer2.TrackList

Others are not answered, like:

dbus-send --print-reply --type=method_call --dest=core.ubuntu.media.Service /org/mpris/MediaPlayer2 org.freedesktop.DBus.Properties.Get string:org.mpris.MediaPlayer2.TrackList string:Tracks

Note that MPRIS specification [1] says that the implementations *must* use "/org/mpris/MediaPlayer2" as object path. However, we are using "/core/ubuntu/media/Service/sessions/<number>" and "/core/ubuntu/media/Service/sessions/<number>/TrackList" for most signals and methods.

* The track list is emptied when the non-standard call org.mpris.MediaPlayer2.TrackList.Reset is performed or when music-app is terminated, but no signal is generated, and indicator-sound still thinks there is something to play.

* Also, we do not return an error in the DBus call if DBus calls Next or Previous fail due to an empty track list (see media::TrackListSkeleton::next() and media::TrackListSkeleton::previous())

[1] http://specifications.freedesktop.org/mpris-spec/latest/

Tags: bq-feedback

Related branches

summary: - Some DBus calls make media-hub-server crash
+ MPRIS is only partially implemented
description: updated
description: updated
description: updated
Changed in canonical-devices-system-image:
assignee: nobody → John McAleely (john.mcaleely)
importance: Undecided → High
milestone: none → backlog
status: New → Confirmed
tags: added: bq-feedback
Changed in canonical-devices-system-image:
milestone: backlog → ww08-2016
Changed in media-hub (Ubuntu):
assignee: nobody → Alfonso Sanchez-Beato (alfonsosanchezbeato)
importance: Undecided → High
Jason Yen (jasonyen)
Changed in avila:
milestone: none → ww10-2016
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in media-hub (Ubuntu):
status: New → Confirmed
Changed in canonical-devices-system-image:
importance: High → Wishlist
milestone: ww08-2016 → backlog
Changed in avila:
milestone: ww10-2016 → backlog
Revision history for this message
Pat McGowan (pat-mcgowan) wrote :

If this is required to support metadata in the sound indicator it needs higher priority

Revision history for this message
pedaliero2012 (patrik-simon) wrote :

The bug #1559012 is also a duplicate

Changed in media-hub (Ubuntu):
assignee: Alfonso Sanchez-Beato (alfonsosanchezbeato) → nobody
no longer affects: avila
Changed in media-hub (Ubuntu):
assignee: nobody → Jim Hodapp (jhodapp)
Jim Hodapp (jhodapp)
Changed in media-hub (Ubuntu):
importance: High → Wishlist
Jim Hodapp (jhodapp)
Changed in canonical-devices-system-image:
status: Confirmed → In Progress
Changed in media-hub (Ubuntu):
status: Confirmed → In Progress
Changed in media-hub (Ubuntu RTM):
status: New → In Progress
assignee: nobody → Jim Hodapp (jhodapp)
importance: Undecided → Critical
Changed in media-hub (Ubuntu):
importance: Wishlist → Critical
Revision history for this message
Jim Hodapp (jhodapp) wrote :

The attached branch fixes the metadata part of this bug. I'm going to separate this bug into multiple ones so that each can be addressed in smaller bits.

Changed in media-hub (Ubuntu):
status: In Progress → Fix Committed
Changed in media-hub (Ubuntu RTM):
status: In Progress → Fix Committed
Jim Hodapp (jhodapp)
Changed in canonical-devices-system-image:
importance: Wishlist → Critical
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

This bug was fixed in the package media-hub 4.2.0+15.04.20160609-0ubuntu1 in https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/stable-phone-overlay

---------------

media-hub (4.2.0+15.04.20160609-0ubuntu1) vivid; urgency=medium

  * Enable exporting of metadata via MPRIS over dbus. This does not
    export everything yet and focused solely on track title, track album
    name and artist name. (LP: #1498962)

 -- Jim Hodapp <email address hidden> Thu, 09 Jun 2016 16:56:41 +0000

Changed in media-hub (Ubuntu RTM):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package media-hub - 4.2.0+16.10.20160609-0ubuntu1

---------------
media-hub (4.2.0+16.10.20160609-0ubuntu1) yakkety; urgency=medium

  * Enable exporting of metadata via MPRIS over dbus. This does not
    export everything yet and focused solely on track title, track album
    name and artist name. (LP: #1498962)

 -- Jim Hodapp <email address hidden> Thu, 09 Jun 2016 16:56:41 +0000

Changed in media-hub (Ubuntu):
status: Fix Committed → Fix Released
Changed in canonical-devices-system-image:
status: In Progress → Fix Committed
Revision history for this message
cm-t 🦄🏂🌈🎵 (cm-t) wrote :

Newbie question/note here:

Does MPRIS is just for actions, or for metadata too? If it take in charge the metadatas too, then thumbnail is currently missing.

Revision history for this message
Jim Hodapp (jhodapp) wrote :

MPRIS covers both general info like song title but also covers album artwork. Album artwork is coming in a separate landing which is on schedule to arrive with OTA 12.

Changed in canonical-devices-system-image:
milestone: backlog → 12
Changed in canonical-devices-system-image:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.