Media Hub not exporting MPRIS controls

[Nick Dedekind]

Pressing the previous or next button in the indicator sound menu does nothing.

[Lars Karlitski (larsu)]

I can't reproduce this with other players.

Does calling org.mpris.MediaPlayer2.Player.Next manually on the media hub advance to the next song?

[Jim Hodapp (jhodapp)]

@Lars What other players have you tried? Calling Next via MPRIS is not fully implemented yet in media-hub.

[Lars Karlitski (larsu)]

Rhythmbox, Banshee, and Spotify.

If Next() is not yet implemented in media-hub, then this is unlikely to be a bug in indicator-sound.

[Jim Hodapp (jhodapp)]

@Lars: media-hub is not used on the desktop yet...this would be directly talking to such apps.

[Victor Tuson Palau (vtuson)]

this seems like a desktop bug. Let me know if I got it wrong and we can re-tag it for rtm

[Jim Hodapp (jhodapp)]

@Victor: this is both a desktop and mobile bug

[Ted Gould (ted)]

Changed title. I use the indicator-sound ones everyday with Rhythmbox, they work fine.

[Jim Hodapp (jhodapp)]

Yeah they do work, but there's changes to the controls that will be necessary such as not displaying next/previous buttons when has_next() and has_previous() return false. The new title is fine but doesn't quite capture the extent of the changes, hence this comment.

[John McAleely (john.mcaleely)]

so, are the changes to the controls in #8 something we need before progressing media-hub?

[Jim Hodapp (jhodapp)]

No there's nothing blocking media-hub's progress other than finishing up the background playlist support (actively being worked on). The indicator-sound changes could be done in parallel or slightly after, but these changes should be ready for the next OTA release.

[John McAleely (john.mcaleely)]

@jim, does this one close when silo48 lands?

[Jim Hodapp (jhodapp)]

@john: no not yet, MPRIS controls will not be enabled with silo 48 landing yet. This will be the next landing in a separate silo after I've had time to debug why the MPRIS controls don't seem to do anything after the interface has been re-enabled in media-hub.

[Xavi Garcia (xavi-garcia-mena)]

I've been looking at this issue and I've found that Rhythmbox returns false for both properties: CanGoNext and CanGoPrevious when the player is not playing anything, after pressing play it returns true to both properties and next and previous buttons do what we expect.
Banshee returns true even if the player is not yet playing anything and starts playing when the previous or next buttons are clicked.

The question here wold be: What should we do in the case of Rhythmbox?

Should we show the next and previous buttons although we know that they are going to do nothing until something is playing?

Should we consider this as a bug of Rhythmbox?

The question about if showing the buttons or not in this case I guess is something to be answered by the desing team.

[Sebastien Bacher (seb128)]

@Xavi, not allowing to do next/previous when nothing is playing seems logical to me? but yeah, seems like one for design...

[Jim Hodapp (jhodapp)]

I believe the next/previous buttons should be greyed out or visually disabled somehow when CanGoNext/CanGoPrevious are true. This will be a lot better than displaying the buttons that look fully functional even when they're not.

[John McAleely (john.mcaleely)]

OK, so we've broken out the indicator work into bug #1488569. Landing the MPRIS controls is stalled until that bug is fixed.

[Pat McGowan (pat-mcgowan)]

no really this time

[Jim Hodapp (jhodapp)]

Don't jinx it until QA passes the silo. ;)

[Launchpad Janitor (janitor)]

This bug was fixed in the package indicator-sound - 12.10.2+15.10.20151019-0ubuntu1

---------------
indicator-sound (12.10.2+15.10.20151019-0ubuntu1) wily; urgency=medium

  [ Xavi Garcia Mena ]
  * Wily branch for MPRIS controls (LP: #1373313)

 -- Alfonso Sanchez-Beato <email address hidden> Mon, 19 Oct 2015 07:54:05 +0000