mcollective-plugins-service installs service file with incorrect name

[Jeremy Bowers]

OS: Ubuntu 12.04.1 LTS
Package: mcollective-plugins-service 0.0.0~git20120105.9b90c2b-0ubuntu3

The mcollective-plugins-service package installs /usr/share/mcollective/plugins/mcollective/agent/puppet-service.rb

This appears to break the mco service command when run from an mcollective client:

bash # mco service mysql status

No request sent, we did not discover any nodes.

---- service summary ----
           Nodes: 0 / 0
        Statuses: No responses received
    Elapsed Time: 0.00 s

bash #

Additionally a message in the mcollective server log shows that puppet-service doesn't load properly:

W, [2012-10-03T21:54:40.429396 #2938] WARN -- : agents.rb:95:in `activate_agent?' Agent activation check for puppet-service failed: NameError: wrong constant name Puppet-service

---HOW TO FIX---

Renaming the /usr/share/mcollective/plugins/mcollective/agent/puppet-service.rb to service.rb appears to fix the error and allow the mco service command to function properly:

bash # mco service mysql status
Do you really want to operate on services unfiltered? (y/n): y

 * [ ============================================================> ] 1 / 1

dev-db02 status=running

---- service summary ----
           Nodes: 3 / 3
        Statuses: errors=2 started=1
    Elapsed Time: 0.31 s

bash #

[Camilo Aguilar (camilo-aguilar)]

Same happens with mcollective-plugins-package.

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.