Activity log for bug #1790788

Date Who What changed Old value New value Message
2018-09-05 07:07:10 Frank Heimes bug added bug
2018-09-05 07:07:42 Frank Heimes affects ubuntu-z-systems makedumpfile (Ubuntu)
2018-09-05 07:21:22 Christian Ehrhardt  bug added subscriber  Christian Ehrhardt 
2018-09-05 07:26:55 Christian Ehrhardt  makedumpfile (Ubuntu): assignee Canonical Kernel Team (canonical-kernel-team)
2018-09-05 12:26:01 Thadeu Lima de Souza Cascardo makedumpfile (Ubuntu): assignee Canonical Kernel Team (canonical-kernel-team) Thadeu Lima de Souza Cascardo (cascardo)
2018-09-05 12:26:07 Thadeu Lima de Souza Cascardo makedumpfile (Ubuntu): status New In Progress
2018-09-05 12:26:10 Thadeu Lima de Souza Cascardo makedumpfile (Ubuntu): importance Undecided High
2018-09-05 12:26:20 Thadeu Lima de Souza Cascardo nominated for series Ubuntu Bionic
2018-09-05 12:26:20 Thadeu Lima de Souza Cascardo nominated for series Ubuntu Cosmic
2018-09-05 12:26:20 Thadeu Lima de Souza Cascardo nominated for series Ubuntu Xenial
2018-09-06 15:43:28 Joseph Salisbury bug task added makedumpfile (Ubuntu Bionic)
2018-09-06 15:43:33 Joseph Salisbury bug task added makedumpfile (Ubuntu Cosmic)
2018-09-06 15:43:40 Joseph Salisbury bug task added makedumpfile (Ubuntu Xenial)
2018-10-01 13:06:32 Thadeu Lima de Souza Cascardo attachment added makedumpfile_1.6.4-2ubuntu1.debdiff https://bugs.launchpad.net/ubuntu/+source/makedumpfile/+bug/1790788/+attachment/5195297/+files/makedumpfile_1.6.4-2ubuntu1.debdiff
2018-10-01 16:19:32 Ubuntu Foundations Team Bug Bot tags s390x patch s390x
2018-10-17 12:05:00 Thadeu Lima de Souza Cascardo nominated for series Ubuntu Dd-series
2019-01-18 18:21:25 Launchpad Janitor makedumpfile (Ubuntu): status In Progress Fix Released
2019-03-08 09:30:05 Timo Aaltonen bug task added makedumpfile (Ubuntu Disco)
2019-03-08 13:54:53 Frank Heimes description Trying to use crashdump especially in a KVM machine. Installation looks fine and the reboot is triggered. But it does not work because the kernel does not have a 'crashkernel=' parameter. Nothing in /proc/cmdline: $ cat /proc/cmdline root=LABEL=cloudimg-rootfs Issue seems to be in adding the crashkernel line in this snippet: # Customize crashkernel= value according to architecture ARCH="$(arch)" DEF_PRESET="384M-:128M" case "$ARCH" in s390x) HAS_CRASHKERNEL="$(grep crashkernel /etc/zipl.conf)" || true if test -z "$HAS_CRASHKERNEL"; then sed -i "/parameters/{s|\"$| crashkernel=${DEF_PRESET}\"|}" /etc/zipl.conf zipl fi CIO_IGNORE="$(cio_ignore -u -k)" sed -i "s/\#KDUMP_CMDLINE_APPEND/KDUMP_CMDLINE_APPEND/" $INITCONFFILE sed -i "/KDUMP_CMDLINE_APPEND/{s|\"$| ${CIO_IGNORE}\"|}" $INITCONFFILE ;; esac (especially 1st sed stmt) SRU Justification: ------------------ [Impact] * While installing makedumpfile the "crashkernel=" argument is not properly set, hence dump is not triggered on reboot. * Means the triggering of dumpfiles is currently not possible using makedumpfile. * Dumpfiles are obviously only needed in rare cases, but if they are needed (e.g. in production environments) the situation is usually critical. * Hence fixing this is needed to allow post-mortem analysis of a dumps. * The provided shell code snippet provides a fixed sed statement that makes sure that the kernel parameter is propoerly set. [Test Case] * Create and boot a s390x (KVM virtual) machine * Install kdump-tools and makedumpfile Select 'yes' on question 'Should kdump-tools be enabled by default?' during installation * [ Reboot system ] * Look for crashkernel line in zipl boot-loader grep crashkernel /etc/zipl.conf crashkernel line is missing in case this bug still exists one or more lines like this should be given: parameters = root=UUID=5ed8f208-adce-4fad-b1a6-feb5e8732d89 crashkernel=196M * One may further trigger a crash (for a full positiv test) sudo -s sysctl -w kernel.sysrq=1 echo c > /proc/sysrq-trigger (in case this bug still exists the system will not come up again - check console in parallel) [Regression Potential] * The regression potential is very low, since: * it's limited to the zipl boot loader configuration file only and this means again it's on the s390x platform only (IBM Z) * kdump-tools and makedumpfile are not installed by default and only used in debug situations hence only system where the package(s) got manually installed get updated * The function is today broken anyway, hence it can actually only get better * I successfully verified this in disco. _________________________ Trying to use crashdump especially in a KVM machine. Installation looks fine and the reboot is triggered. But it does not work because the kernel does not have a 'crashkernel=' parameter. Nothing in /proc/cmdline: $ cat /proc/cmdline root=LABEL=cloudimg-rootfs Issue seems to be in adding the crashkernel line in this snippet: # Customize crashkernel= value according to architecture ARCH="$(arch)" DEF_PRESET="384M-:128M" case "$ARCH" in    s390x)       HAS_CRASHKERNEL="$(grep crashkernel /etc/zipl.conf)" || true       if test -z "$HAS_CRASHKERNEL"; then          sed -i "/parameters/{s|\"$| crashkernel=${DEF_PRESET}\"|}" /etc/zipl.conf          zipl       fi          CIO_IGNORE="$(cio_ignore -u -k)"          sed -i "s/\#KDUMP_CMDLINE_APPEND/KDUMP_CMDLINE_APPEND/" $INITCONFFILE          sed -i "/KDUMP_CMDLINE_APPEND/{s|\"$| ${CIO_IGNORE}\"|}" $INITCONFFILE     ;; esac (especially 1st sed stmt)
2019-03-08 14:05:02 Frank Heimes description SRU Justification: ------------------ [Impact] * While installing makedumpfile the "crashkernel=" argument is not properly set, hence dump is not triggered on reboot. * Means the triggering of dumpfiles is currently not possible using makedumpfile. * Dumpfiles are obviously only needed in rare cases, but if they are needed (e.g. in production environments) the situation is usually critical. * Hence fixing this is needed to allow post-mortem analysis of a dumps. * The provided shell code snippet provides a fixed sed statement that makes sure that the kernel parameter is propoerly set. [Test Case] * Create and boot a s390x (KVM virtual) machine * Install kdump-tools and makedumpfile Select 'yes' on question 'Should kdump-tools be enabled by default?' during installation * [ Reboot system ] * Look for crashkernel line in zipl boot-loader grep crashkernel /etc/zipl.conf crashkernel line is missing in case this bug still exists one or more lines like this should be given: parameters = root=UUID=5ed8f208-adce-4fad-b1a6-feb5e8732d89 crashkernel=196M * One may further trigger a crash (for a full positiv test) sudo -s sysctl -w kernel.sysrq=1 echo c > /proc/sysrq-trigger (in case this bug still exists the system will not come up again - check console in parallel) [Regression Potential] * The regression potential is very low, since: * it's limited to the zipl boot loader configuration file only and this means again it's on the s390x platform only (IBM Z) * kdump-tools and makedumpfile are not installed by default and only used in debug situations hence only system where the package(s) got manually installed get updated * The function is today broken anyway, hence it can actually only get better * I successfully verified this in disco. _________________________ Trying to use crashdump especially in a KVM machine. Installation looks fine and the reboot is triggered. But it does not work because the kernel does not have a 'crashkernel=' parameter. Nothing in /proc/cmdline: $ cat /proc/cmdline root=LABEL=cloudimg-rootfs Issue seems to be in adding the crashkernel line in this snippet: # Customize crashkernel= value according to architecture ARCH="$(arch)" DEF_PRESET="384M-:128M" case "$ARCH" in    s390x)       HAS_CRASHKERNEL="$(grep crashkernel /etc/zipl.conf)" || true       if test -z "$HAS_CRASHKERNEL"; then          sed -i "/parameters/{s|\"$| crashkernel=${DEF_PRESET}\"|}" /etc/zipl.conf          zipl       fi          CIO_IGNORE="$(cio_ignore -u -k)"          sed -i "s/\#KDUMP_CMDLINE_APPEND/KDUMP_CMDLINE_APPEND/" $INITCONFFILE          sed -i "/KDUMP_CMDLINE_APPEND/{s|\"$| ${CIO_IGNORE}\"|}" $INITCONFFILE     ;; esac (especially 1st sed stmt) SRU Justification: ------------------ [Impact]  * While installing makedumpfile the "crashkernel=" argument is not properly set, hence dump is not triggered on reboot.  * Means the triggering of dumpfiles is currently not possible using makedumpfile.  * Dumpfiles are obviously only needed in rare cases, but if they are needed (e.g. in production environments) the situation is usually critical.  * Hence fixing this is needed to allow post-mortem analysis of a dumps.  * The provided shell code snippet provides a fixed sed statement that makes sure that the kernel parameter is propoerly set. [Test Case]  * Create and boot a s390x (KVM virtual) machine  * Install kdump-tools and makedumpfile    Select 'yes' on question 'Should kdump-tools be enabled by default?' during installation  * [ Reboot system ]  * Look for crashkernel line in zipl boot-loader    grep crashkernel /etc/zipl.conf    crashkernel line is missing in case this bug still exists    one or more lines like this should be given:    parameters = root=UUID=5ed8f208-adce-4fad-b1a6-feb5e8732d89 crashkernel=196M  * One may further trigger a crash (for a full positiv test)    sudo -s    sysctl -w kernel.sysrq=1    echo c > /proc/sysrq-trigger    (in case this bug still exists the system will not come up again - check console in parallel) Finally dump files should be visible in /var/crash [Regression Potential]  * The regression potential is very low, since:  * it's limited to the zipl boot loader configuration file only    and this means again it's on the s390x platform only (IBM Z)  * kdump-tools and makedumpfile are not installed by default and only used in debug situations    hence only system where the package(s) got manually installed get updated  * The function is today broken anyway, hence it can actually only get better  * I successfully verified this in disco. _________________________ Trying to use crashdump especially in a KVM machine. Installation looks fine and the reboot is triggered. But it does not work because the kernel does not have a 'crashkernel=' parameter. Nothing in /proc/cmdline: $ cat /proc/cmdline root=LABEL=cloudimg-rootfs Issue seems to be in adding the crashkernel line in this snippet: # Customize crashkernel= value according to architecture ARCH="$(arch)" DEF_PRESET="384M-:128M" case "$ARCH" in    s390x)       HAS_CRASHKERNEL="$(grep crashkernel /etc/zipl.conf)" || true       if test -z "$HAS_CRASHKERNEL"; then          sed -i "/parameters/{s|\"$| crashkernel=${DEF_PRESET}\"|}" /etc/zipl.conf          zipl       fi          CIO_IGNORE="$(cio_ignore -u -k)"          sed -i "s/\#KDUMP_CMDLINE_APPEND/KDUMP_CMDLINE_APPEND/" $INITCONFFILE          sed -i "/KDUMP_CMDLINE_APPEND/{s|\"$| ${CIO_IGNORE}\"|}" $INITCONFFILE     ;; esac (especially 1st sed stmt)
2019-03-08 14:06:14 Frank Heimes bug task added ubuntu-z-systems
2019-03-08 14:06:22 Frank Heimes ubuntu-z-systems: status New In Progress
2019-03-28 18:41:34 Thadeu Lima de Souza Cascardo makedumpfile (Ubuntu Bionic): status New In Progress
2019-03-28 18:41:38 Thadeu Lima de Souza Cascardo makedumpfile (Ubuntu Bionic): assignee Thadeu Lima de Souza Cascardo (cascardo)
2019-03-28 18:41:42 Thadeu Lima de Souza Cascardo makedumpfile (Ubuntu Bionic): importance Undecided High
2019-03-29 18:18:56 Nish Aravamudan bug added subscriber Nish Aravamudan
2019-04-29 16:09:04 Łukasz Zemczak makedumpfile (Ubuntu Cosmic): status In Progress Fix Committed
2019-04-29 16:09:06 Łukasz Zemczak bug added subscriber Ubuntu Stable Release Updates Team
2019-04-29 16:09:09 Łukasz Zemczak bug added subscriber SRU Verification
2019-04-29 16:09:12 Łukasz Zemczak tags patch s390x patch s390x verification-needed verification-needed-cosmic
2019-04-29 16:20:14 Łukasz Zemczak makedumpfile (Ubuntu Bionic): status In Progress Fix Committed
2019-04-29 16:20:19 Łukasz Zemczak tags patch s390x verification-needed verification-needed-cosmic patch s390x verification-needed verification-needed-bionic verification-needed-cosmic
2019-04-30 10:06:53 Frank Heimes attachment added verification-cosmic.txt https://bugs.launchpad.net/ubuntu/+source/makedumpfile/+bug/1790788/+attachment/5260249/+files/verification-cosmic.txt
2019-04-30 10:07:17 Frank Heimes tags patch s390x verification-needed verification-needed-bionic verification-needed-cosmic patch s390x verification-done-cosmic verification-needed verification-needed-bionic
2019-04-30 10:07:52 Frank Heimes attachment added verification-bionic.txt https://bugs.launchpad.net/ubuntu/+source/makedumpfile/+bug/1790788/+attachment/5260250/+files/verification-bionic.txt
2019-04-30 10:08:19 Frank Heimes tags patch s390x verification-done-cosmic verification-needed verification-needed-bionic patch s390x verification-done verification-done-bionic verification-done-cosmic
2019-05-20 08:46:37 Launchpad Janitor makedumpfile (Ubuntu Cosmic): status Fix Committed Fix Released
2019-05-20 08:46:48 Łukasz Zemczak removed subscriber Ubuntu Stable Release Updates Team
2019-05-20 09:00:19 Frank Heimes ubuntu-z-systems: status In Progress Fix Committed
2019-05-20 09:21:33 Launchpad Janitor makedumpfile (Ubuntu Bionic): status Fix Committed Fix Released
2019-05-24 13:14:52 Frank Heimes ubuntu-z-systems: importance Undecided High
2019-06-25 08:01:18 Frank Heimes ubuntu-z-systems: status Fix Committed Fix Released