Cannot change mac with --random
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
macchanger (Debian) |
Fix Released
|
Unknown
|
|||
macchanger (Ubuntu) |
Fix Released
|
Medium
|
Unassigned | ||
Trusty |
Won't Fix
|
Medium
|
Unassigned | ||
Wily |
Fix Released
|
Medium
|
Unassigned | ||
Xenial |
Fix Released
|
Medium
|
Unassigned |
Bug Description
[Impact]
A bad patch prevents the --random option from working at all.
This was corrected in Debian, and in newer Ubuntu releases, but has not been corrected in Trusty. This SRU contains the corrected patch.
[Test Case]
- Use --random option
- See if MAC changed or if resulted in error message
[Regression Potential]
Since this code simply doesn't work at all at the moment, the only regression would be for it to crash instead of not printing the error message.
Original description:
Hello,
macchanger works only when I'm specifying which MAC to use. Using macchanger with --random always return 'It's the same MAC!!'.
I think I find out why, there's something in this patch made to improve random MAC generation :
In mc_mac_random()
- 'mac' argument is saved into 'newmac', on the stack (line 40)
- the MAC is randomized and every byte of 'mac' is changed (line 48...)
- 'mac' is overwritten by 'newmac' value (line 82)
Thank you
Changed in macchanger (Ubuntu): | |
status: | Confirmed → Fix Committed |
Changed in macchanger (Debian): | |
status: | Unknown → Fix Released |
Changed in macchanger (Ubuntu Trusty): | |
status: | New → Confirmed |
Changed in macchanger (Ubuntu Wily): | |
status: | New → Fix Released |
Changed in macchanger (Ubuntu Xenial): | |
status: | Confirmed → Fix Released |
Changed in macchanger (Ubuntu Xenial): | |
importance: | Undecided → Medium |
Changed in macchanger (Ubuntu Wily): | |
importance: | Undecided → Medium |
Changed in macchanger (Ubuntu Trusty): | |
importance: | Undecided → Medium |
Status changed to 'Confirmed' because the bug affects multiple users.