Building the MAAS package fails with "ImportError: No module named bson"

[Diogo Matsubara]

As seen in http://d-jenkins.ubuntu-ci:8080/view/MAAS/job/utopic-adt-maas/239/, maas package failed to build with the following error:

HOME=/tmp/adt-run.P7YZGH/ubtree0-build/real-tree/debian/build PYTHONPATH=/tmp/adt-run.P7YZGH/ubtree0-build/real-tree/src/ python2.7 \
 /tmp/adt-run.P7YZGH/ubtree0-build/real-tree/src/maasserver/utils/jsenums.py \
 src/maasserver/enum.py src/metadataserver/enum.py > /tmp/adt-run.P7YZGH/ubtree0-build/real-tree/debian/build/enums.js
Traceback (most recent call last):
  File "/tmp/adt-run.P7YZGH/ubtree0-build/real-tree/src/maasserver/utils/jsenums.py", line 37, in <module>
    from provisioningserver.utils import map_enum
  File "/tmp/adt-run.P7YZGH/ubtree0-build/real-tree/src/provisioningserver/utils/__init__.py", line 70, in <module>
    import bson
ImportError: No module named bson
debian/rules:19: recipe for target 'override_dh_auto_build' failed
make[1]: *** [override_dh_auto_build] Error 1

[Raphaël Badin (rvb)]

The utility in src/maasserver/utils/jsenums.py is used when building the package. It uses the map_enum utility that recently from moved over to src/provisioningserver/utils/__init__.py. The problem with that is that is means that all the modules imported by src/provisioningserver/utils/__init__.py must be present as "build dependencies" in the packaging.

I see three possible solutions here:

- Add all the required dependencies as build dependencies in the packaging.

- Move map_enum in a place where it can be imported in isolation without triggering a ton of imports

- Add a copy of the code of map_enum in src/maasserver/utils/jsenums.py instead of importing the shared map_enum.

[Raphaël Badin (rvb)]

The logical place for map_enum really is src/provisioningserver/utils/__init__.py since it's used by both maasserver and pserv so I really don't want to put it somewhere else. Since jsenum is special in the sense that it's used by the packaging, I'd favor option 3: add a copy of map_enum (it's just a couple of lines) in jsenum.

[Julian Edwards (julian-edwards)]

jsenum has no place in provisioning server, can't you extract that part?

[Raphaël Badin (rvb)]

> jsenum has no place in provisioning server, can't you extract that part?

jsenum is *not* in provisioningserver, as I said above it's in src/maasserver/utils/, where it should be. The problem is that it's *using things* (well, one thing: map_enum) from provisioningserver

[Julian Edwards (julian-edwards)]

On Tuesday 22 Jul 2014 07:09:59 you wrote:
> jsenum is *not* in provisioningserver, as I said above it's in
> src/maasserver/utils/, where it should be. The problem is that it's
> *using things* (well, one thing: map_enum) from provisioningserver

Yeah my bad. Serves me right for replying when I am jet lagged.