power management broken after upgrade from saucy

[James Page]

MAAS was unable to power control nodes after an upgrade from Saucy to Trusty - specifically the template rendering throws an error:

[2014-03-19 11:10:08,272: WARNING/Worker-9] name 'ip_address' is not defined at line 18 column 4 in file /etc/maas/templates/power/ipmi.template
[2014-03-19 11:10:08,275: ERROR/MainProcess] Task provisioningserver.tasks.power_on[b8312502-485c-4853-adf1-1fffd6d78241] raised unexpected: PowerActionFail()
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/celery/app/trace.py", line 218, in trace_task
    R = retval = fun(*args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/celery/app/trace.py", line 398, in __protected_call__
    return self.run(*args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/provisioningserver/tasks.py", line 155, in power_on
    issue_power_action(power_type, 'on', **kwargs)
  File "/usr/lib/python2.7/dist-packages/provisioningserver/tasks.py", line 141, in issue_power_action
    pa.execute(**kwargs)
  File "/usr/lib/python2.7/dist-packages/provisioningserver/power/poweraction.py", line 133, in execute
    rendered = self.render_template(template, **kwargs)
  File "/usr/lib/python2.7/dist-packages/provisioningserver/power/poweraction.py", line 108, in render_template
    raise PowerActionFail(self, error)
PowerActionFail
^C
ubuntu@test-01:/var/log/maas$ sudo vi /etc/maas/templates/power/ipmi.template
ubuntu@test-01:/var/log/maas$ tail -f celery.log
  File "/usr/lib/python2.7/dist-packages/provisioningserver/power/poweraction.py", line 133, in execute
    rendered = self.render_template(template, **kwargs)
  File "/usr/lib/python2.7/dist-packages/provisioningserver/power/poweraction.py", line 108, in render_template
    raise PowerActionFail(self, error)
PowerActionFail

ProblemType: Bug
DistroRelease: Ubuntu 14.04
Package: maas 1.5+bzr1977-0ubuntu5
ProcVersionSignature: Ubuntu 3.13.0-18.38-generic 3.13.6
Uname: Linux 3.13.0-18-generic x86_64
ApportVersion: 2.13.3-0ubuntu1
Architecture: amd64
Date: Wed Mar 19 11:14:18 2014
InstallationDate: Installed on 2011-11-16 (853 days ago)
InstallationMedia: Ubuntu-Server 11.10 "Oneiric Ocelot" - Release amd64 (20111011)
PackageArchitecture: all
ProcEnviron:
 TERM=screen-bce
 PATH=(custom, no user)
 XDG_RUNTIME_DIR=<set>
 LANG=en_US.UTF-8
 SHELL=/bin/bash
SourcePackage: maas
UpgradeStatus: Upgraded to trusty on 2014-03-19 (0 days ago)

[Julian Edwards (julian-edwards)]

I think this is fixed in trunk, FWIW.