Main Inclusion Request: m2crypto

Bug #434723 reported by Scott Moser on 2009-09-22
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
m2crypto (Ubuntu)
High
Chuck Short
Karmic
High
Chuck Short

Bug Description

Binary package hint: m2crypto

Binary package hint: python-m2crypto

Please consider m2crypto for inclusion into main. python-m2crypto provides a crypto and ssl toolkit for python. It is used by the euca2ools package.

Main Inclusion Report can be found at:
  * https://wiki.ubuntu.com/MainInclusionM2crypto

Note, that python-m2crypto is a dependency for other MIR:
  * euca2ools : bug 434697 : https://wiki.ubuntu.com/MainInclusionEuca2ools

Scott Moser (smoser) on 2009-09-22
Changed in m2crypto (Ubuntu):
importance: Undecided → High
Martin Pitt (pitti) on 2009-09-23
Changed in m2crypto (Ubuntu):
assignee: nobody → Kees Cook (kees)
Chuck Short (zulcss) wrote :

Kees,

If you could get to his as soon as possible that would be great!

Thanks
chuck

Kees Cook (kees) wrote :

Given that this is a crypto-wrapper, I would greatly prefer that the testsuite is set up to run (and pass) during the build. The current 2009 CVEs look pretty strange (most are disputed or minor), but I would want to see any standing open CVEs to be solved before Karmic releases as well. If this is a blocker, I'm fine with this going into main early, with the expectation that the above issues are fixed before Karmic is finalized.

Changed in m2crypto (Ubuntu):
assignee: Kees Cook (kees) → nobody
status: New → Incomplete
Colin Watson (cjwatson) wrote :

I've promoted this as a blocker, but am leaving this bug open as release-critical to ensure that it gets addressed.

Changed in m2crypto (Ubuntu Karmic):
milestone: none → ubuntu-9.10
Thierry Carrez (ttx) on 2009-10-02
Changed in m2crypto (Ubuntu Karmic):
assignee: nobody → Chuck Short (zulcss)
Chuck Short (zulcss) wrote :

Pitti,

The testsuite has been fixed and enabled it should be kosher now.

Regards
chuck

Martin Pitt (pitti) wrote :

Failed to build with

test_HTTPS (tests.test_ssl.HttpslibSSLClientTestCase) ... make: *** [build-stamp] Terminated

Does this need a network connection? (ideally a test suite should only use localhost)

Chuck Short (zulcss) wrote :

Pitti,

I tried the past couple of days to fix this however the testsuite will still fail with the same error above.I tried updating the packaging my ppa but it still exhibits the same problem.

Regads
chuck

Martin Pitt (pitti) wrote :

As discussed on IRC, let's || true the test suite for now, so that it doesn't fail the build on the buildds. This will keep comparable test outputs in the build logs, and local developers can still run it fully to test changes (it works locally).

Chuck Short (zulcss) wrote :

Hi,

Ive uploaded the new version of m2crypto which the testsuite is enabled but it wont fail if it doesnt pass properly. I am going to open a bug in the upstream bug tracker about the testsuite failing if there is no network.

Regards
chuck

Chuck Short (zulcss) wrote :

Hi,

Enabling || true, the testsuite still timeouts the buildds. It looks like to me that the test that causes the build never finishes because the buldds timeout. My suggestion is to disable the testsuite and get this fixed properly for karmic +1.

Regards
chuck

Chuck Short [2009-10-14 15:25 -0000]:
> Hi,
>
> Enabling || true, the testsuite still timeouts the buildds. It looks
> like to me that the test that causes the build never finishes because
> the buldds timeout. My suggestion is to disable the testsuite and get
> this fixed properly for karmic +1.

Ack. Thanks for trying!

Martin
--
Martin Pitt | http://www.piware.de
Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org)

Steve Langasek (vorlon) wrote :

Is this satisfactory to the MIR team for karmic, in which case we should 'wontfix' the karmic target?

Chuck Short (zulcss) wrote :

From earlier today:

<pitti> yes, makes sense
 we have worse bugs to deal with now
 thanks a lot for trying, though
<zul> no probs im going to upload it and ill ping you when its built

Martin Pitt (pitti) wrote :

Right. I filed bug 451998 about running the test suite by default.

Changed in m2crypto (Ubuntu Karmic):
status: Incomplete → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.