Merge 0.11.1-2 from Debian Sid

Bug #1690491 reported by Simon Quigley
14
This bug affects 1 person
Affects Status Importance Assigned to Milestone
lxqt-session (Ubuntu)
Fix Released
Undecided
Simon Quigley

Bug Description

lxqt-session 0.11.1 was released upstream and is available in Debian Sid. We should merge these changes.

Changelog since last Ubuntu upload:

lxqt-session (0.11.1-2) unstable; urgency=medium

  * Recommend a screen-saver:
    xscreensaver | gnome-screensaver | light-locker | i3lock | suckless-tools
    (Closes: #824857)

 -- Alf Gaida <email address hidden> Mon, 02 Jan 2017 18:52:28 +0100

lxqt-session (0.11.1-1) unstable; urgency=medium

  * Cherry-picking upstream release 0.11.1.
  * Removed some build dependencies:
    -cmake
    -libqt5xdg-dev
    -libqt5xdgiconloader-dev
    -pkg-config
    -qttools5-dev
    -qttools5-dev-tools
  * Bumped build dependency liblxqt0-dev (>= 0.11.1)
  * Bumped years in d/copyright
  * Removed deleted files and BSD-License from d/copyright

 -- Alf Gaida <email address hidden> Mon, 02 Jan 2017 16:41:12 +0100

Ubuntu delta:

  * debian/control: Don't depend on lxqt-common
  * debian/postinst & debian/prerm
    - Use lxqt-session directly, so lxqt-common is not a hard dependency.

I see no reason why we need to drop the delta, so it can be merged from Debian.

Revision history for this message
Simon Quigley (tsimonq2) wrote :

Attached is the patch completing this merge.

Changed in lxqt-session (Ubuntu):
status: New → In Progress
assignee: nobody → Simon Quigley (tsimonq2)
tags: added: artful upgrade-software-version
Revision history for this message
Mattia Rizzolo (mapreri) wrote :

Looking at this, I can not really understand why we would need this change.
What's wrong with a lxqt-common dependency?

Revision history for this message
Alf Gaida (agaida) wrote :

There is nothing wrong with the lxqt-common dependency. In fact no autostart and some other things will run without and the common answer to misc problems with LXQt and Ubuntu is: Just install lxqt-common. Period.

The only thing that is wrong with lxqt-common: it exists. Maybe it was not the best of all upstream ideas to create the commons, but lxqt-common was and is needed to some extend until 0.12.

See also:
 https://github.com/lxde/lxqt/issues/1234
 https://github.com/lxde/lxqt/issues/1274

Revision history for this message
Alf Gaida (agaida) wrote :

Sorry, forget to mention that a small or no diff to debian would ease the upgrade to 0.12 a lot - there are some breaks/replaces needed. Most of the file moves will not be critical because of it's nature - esp. the conf-file moves are handled fine with apt.

Revision history for this message
Mattia Rizzolo (mapreri) wrote :

That's great to hear, and in fact it is actually a reason to just drop this delta on lxqt-session…

@gilir ?

Revision history for this message
Julien Lavergne (gilir) wrote :

The diff was introduced to be able to use lxqt-session with others settings that the ones provided by lxqt-common. At this time, lxqt was only capable to read settings from 1 path (the one provided by lxqt-common). So, it was impossible to have both lxqt-common and lubuntu-default-settings.

However, the ability to read settings on custom path was merged in Qt (see https://bugs.launchpad.net/lubuntu-next/+bug/1387237 for details), and lubuntu-default-settings was modified to store lxqt settings on a custom path. So, it should work, out-of-the-box, without this diff (if Qt is up-to-date). IMO, the diff can me dropped, and the package sync. At least, upstream and pristine version of lxqt should work, as expected by upstream (it may need a bit of tweaking for Lubuntu Qt version to work as expected).

Revision history for this message
Jeremy Bícha (jbicha) wrote :

Julien, it looks like that change is part of Qt 5.9 which is not in Ubuntu yet. Qt 5.9 is scheduled for release at the end of May and ~mitya57 was going to try to merge it into Ubuntu 17.10 after that.

Revision history for this message
Simon Quigley (tsimonq2) wrote :

I'm working with Dimitry (mitya57) to get Qt 5.9.0 in Ubuntu Artful.

I'll rename the bug once this has been uploaded to artful-proposed so that it can just be force synced, as Julien says (because I agree).

Revision history for this message
Simon Quigley (tsimonq2) wrote :

This has been force synced and when Qt migrates (alongside this), I'll mark this as Fix Released.

Changed in lxqt-session (Ubuntu):
status: In Progress → Fix Committed
Simon Quigley (tsimonq2)
Changed in lxqt-session (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.