[PATCH] Don't put X11 auth file in $HOME

Bug #558765 reported by Daniel Richard G.
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
LXDE
Unknown
Unknown
lxdm (Ubuntu)
Low
Unassigned

Bug Description

Binary package hint: lxdm

This concerns lxdm 0.2.0~svn2307+git20100209-0ubuntu2 in Ubuntu Lucid beta1.

When you log in via lxdm, the X authorization file is in its default location of ~/.Xauthority. Which is fine, unless you are on a system where home directories are served out of NFS or AFS. If the home directory suddenly becomes inaccessible (whether by a file server going down, or authentication expiring in the case of AFS), then the X auth file can't be read, and then you can't even pop up an error dialog to the user.

GDM has a UserAuthDir option that lets you place the X auth file in (for example) /tmp, which works around the above problem handily. I considered adding a similar such option to lxdm, but then figured I may as well just tweak its behavior to match that of xdm (which unconditionally sets XAUTHORITY=/tmp/.XauthXXXXXX).

A patch, against the lxdm sources in the LXDE SVN tree, is attached. (The "#ifdef DEBUG" bit is just a sanity check, to ensure that g_mkstemp_full() created a file.)

Related branches

Revision history for this message
Daniel Richard G. (skunk) wrote :
Revision history for this message
Hans Joachim Desserud (hjd) wrote :

** This is an automated message **
Looking at the attachments in this bug report, I noticed that an attachment was not flagged as a patch. A patch contains changes to an Ubuntu package that will resolve a bug and this attachment is one! Subsequently, I've checked the patch flag for it. In the future when submitting patches please use the patch checkbox as there are some Launchpad searches that use this feature. You can learn more about the patch workflow at https://wiki.ubuntu.com/Bugs/Patches.

tags: added: patch
Revision history for this message
Julien Lavergne (gilir) wrote :

Thank you for your bug report and your patch. I forwarded it to the author of lxdm.

Changed in lxdm (Ubuntu):
importance: Undecided → Low
status: New → Triaged
papukaija (papukaija)
tags: added: lucid
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package lxdm - 0.4.0-0ubuntu1

---------------
lxdm (0.4.0-0ubuntu1) oneiric; urgency=low

  * New upstream release.
   - Add a configuration GUI (LP: #518415)
   - Add an option to not put X11 auth file in $HOME (LP: #558765)
   - Parse ~/.xprofile (LP: #591031)
  * debian/patches:
   - 15-path-replace.patch: Refreshed.
   - 16_gtk3_migration.patch: Remove, merged upstream.
   - 20_disable_resize_grip.patch: Update to always apply since GTK2 has
     resize grip on Ubuntu.
   - 80_translations.patch: Remove, merged upstream.
   - 90_simple_expose.patch: Remove, upstream rewrote this code.
   - lxdm.conf_greeter_path_fix.patch: Remove, fixed upstream.
  * debian/rules:
   - Remove additional CFLAGS for GTK3 migration.
 -- Julien Lavergne <email address hidden> Sun, 24 Jul 2011 19:03:21 +0200

Changed in lxdm (Ubuntu):
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.