dh_apparmor runs against all binary packages, adding useless entries to lxc-dev's postinst/postrm

Bug #1021428 reported by Stéphane Graber on 2012-07-05
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
lxc (Ubuntu)
Undecided
Unassigned
Precise
Low
Stéphane Graber
Quantal
Undecided
Unassigned

Bug Description

The dh_apparmor call in debian/rules isn't called using "-p <binary package>" and so adds apparmor entries to the postinst/postrm of all the binary packages, not just the one containing the profiles.

This is clearly wrong and at the very least confusing (if not a source of bugs).

[rational]
The apparmor postinst/postrm code should only be added to the package containing the profiles and not to lxc-dev.
The fix is trivial and can potentially fix bugs.

[test case]
1) apt-get install lxc-dev
2) grep apparmor /var/lib/dpkg/info/lxc-dev*

2) shouldn't return anything as lxc-dev doesn't have anything to do with apparmor

[regression potential]
The change has been tested on quantal and precise, the apparmor maintainer script entries are indeed limited to just the lxc binary package after that change. Should everything go wrong, the worst that can happen is a missing apparmor maintainer script entry in lxc which will prevent a reload of the profile at upgrade time, though the profile will still be applied at boot time.

Changed in lxc (Ubuntu Quantal):
status: New → Fix Released
Changed in lxc (Ubuntu Precise):
status: New → In Progress
importance: Undecided → Low
assignee: nobody → Stéphane Graber (stgraber)

Hello Stéphane, or anyone else affected,

Accepted lxc into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/lxc/0.7.5-3ubuntu60 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please change the bug tag from verification-needed to verification-done. If it does not, change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in lxc (Ubuntu Precise):
status: In Progress → Fix Committed
tags: added: verification-needed
Stéphane Graber (stgraber) wrote :

Looks good now.

tags: added: verification-done
removed: verification-needed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package lxc - 0.7.5-3ubuntu60

---------------
lxc (0.7.5-3ubuntu60) precise-proposed; urgency=low

  * Update lxc-ubuntu template to use "dpkg --add-architecture" in containers
    running dpkg >= 1.16.2. (LP: #1017862)
  * Patch lxc-clone to stop messing with dhclient.conf when it contains a
    placeholder (<hostname> or gethostname()). Fixes cases where dpkg will
    prompt for modified config file on upgrade. (LP: #1021416)
  * Allow write access to /proc/sys/kernel/shm* as these are namespaced (IPC).
    (LP: #1021411)
  * Allow fstype=fuse.*, for all containers. (LP: #1021421)
  * Rebase lxc-list on quantal's, properly shows FROZEN containers and prints
    error messages on stderr. (LP: #1021429)
  * Only run dh_apparmor against the lxc package. (LP: #1021428)
  * Depend on adduser as it's being used in postinst.
  * Fix lintian-overrides syntax.
 -- Stephane Graber <email address hidden> Thu, 05 Jul 2012 12:18:47 -0400

Changed in lxc (Ubuntu Precise):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers