stop lxc-net should do stop even when USE_LXC_BRIDGE="false"

Bug #1019290 reported by Daniel Dehennin on 2012-06-29
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
lxc (Ubuntu)
Low
Unassigned
Precise
Undecided
Serge Hallyn
Quantal
Low
Unassigned

Bug Description

========================
SRU Justification:
1. Impact: 'stop lxc-net' may not actually tear down the lxc bridge
2. Development fix: don't shortcut 'stop lxc-net' if USE_LXC_BRIDGE is false
3. Stable fix: same as development fix.
4. Test case:
  . sudo apt-get install lxc
  . sudo sed -i 's/USE_LXC_BRIDGE.*$/USE_LXC_BRIDGE="false"/' /etc/default/lxc
  . sudo stop lxc-net
  . ifconfig | grep lxcbr0
5. Regression potential: if done wrong, the worst this should do is to make 'stop lxc-net' give errors when it tries to shut down a non-existent network.
========================

After an installation on precise pangolin (0.7.5-3ubuntu59) , the lxcbr0 bridge is up and dnsmasq is running.

* edit /etc/default/lxc to pass USE_LXC_BRIDGE to "false"
* launch the command: stop lxc-net

The bridge is not stopped, the upstart script should detect that lxc-net was started with USE_LXC_BRIDGE="true" and stop it.

Regards.

Serge Hallyn (serge-hallyn) wrote :

Thanks for reporting this bug. That should indeed be fixed. Marking this Confirmed, with low priority since there is a workaround.

Changed in lxc (Ubuntu):
importance: Undecided → Low
status: New → Triaged
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package lxc - 0.8.0~rc1-4ubuntu21

---------------
lxc (0.8.0~rc1-4ubuntu21) quantal; urgency=low

  [ Stéphane Graber ]
  * Fix lxc-ubuntu and lxc-ubuntu-cloud to fix the /dev/shm workaround to only
    trigger when /dev/shm is not a symlink. (LP: #974584)

  [ Serge Hallyn ]
  * lxc.lxc-net.upstart: replace the check for USE_LXC_BRIDGE (which could be
    changed from true to false after starting lxc-net) with one for the
    existence /var/run/lxc. (LP: #1019290)
  * 0095-lxc-clone-change-uuid-on-xfs.patch: give each cloned xfs-backed
    lvm partition a unique uuid so they can be mounted simultaneously.
    (LP: #1013549)
  * 0096-lxc-wait-add-timeout.patch: patch submitted upstream to add a timeout
    option to lxc-wait. (LP: #1020179)
 -- Serge Hallyn <email address hidden> Thu, 26 Jul 2012 17:40:36 +0000

Changed in lxc (Ubuntu Quantal):
status: Triaged → Fix Released
description: updated
Changed in lxc (Ubuntu Precise):
status: New → In Progress
assignee: nobody → Serge Hallyn (serge-hallyn)

Hello Daniel, or anyone else affected,

Accepted lxc into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/lxc/0.7.5-3ubuntu63 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please change the bug tag from verification-needed to verification-done. If it does not, change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in lxc (Ubuntu Precise):
status: In Progress → Fix Committed
tags: added: verification-needed
Stéphane Graber (stgraber) wrote :

Fix working as expected.

tags: added: verification-done
removed: verification-needed

Fix working as expected on precise with version 0.7.5-3ubuntu63

Thanks.

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package lxc - 0.7.5-3ubuntu63

---------------
lxc (0.7.5-3ubuntu63) precise-proposed; urgency=low

  * lxc.lxc-net.upstart: replace the check for USE_LXC_BRIDGE (which could be
    changed from true to false after starting lxc-net) with one for the
    existence /var/run/lxc. (LP: #1019290)
  * lxc-start-ephemeral: use unionfs only for the rootfs itself
    (LP: #959352)
 -- Serge Hallyn <email address hidden> Tue, 14 Aug 2012 11:38:25 -0500

Changed in lxc (Ubuntu Precise):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers