Update ofono.override plugin excludes ( -P ) for bluez5

Bug #1506988 reported by Tony Espy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canonical System Image
Fix Released
High
John McAleely
lxc-android-config (Ubuntu)
Confirmed
High
Simon Fels
lxc-android-config (Ubuntu RTM)
Fix Committed
High
Simon Fels

Bug Description

The ofono upstart override file includes an updated exec line for ofono with a different set of plugins excluded vs. the upstart job shipped as part of the ofono package.

The '-P' argument is a comma-separated list of plugins to exclude at startup. ofono internally uses g_pattern_match_simple to process this list, which means the patterns are glob-style, and support the wildcard '*' and '?' characters per

https://developer.gnome.org/glib/2.28/glib-Glob-style-pattern-matching.html

The upstart job shipped in the archive's ofono package specifies a single plugin to exclude, 'ril', which is the device plugin used on touch devices only. Note, this job should also probably exclude the 'rildev' plugin as well. As such, we probably should change the upstart job to specify "-P ril*".

The current excludes list in the overlay PPA is:

-P stktest,provision,sap,udev,dun,smart,hfp

'stktest' can be removed as it's only included in the builtin_modules list if ofono is built with MAINTAINER_MODE defined.

'dun' can be removed as there's no plugin with that name. Note, for bluez5, we've added "dun_gw_bluez5" to the list. We should just combine the two and specify "dun*".

'sap' ( SIM Access Profile ) can be removed when we land bluez5, as it's only defined if ofono is built against bluez4.

'smart' isn't doing anything by itself, as the plugin is really named "smart_messaging".

'udev' only prevents the original udev plugin from loading, it doesn't prevent udevng from being loaded. This should probably be changed to "udev*" to prevent problems on a device where a collision might occur between the udev plugins and the rildev plugin.

So, the recommended command line once we land bluez5 should be:

exec ofonod -P provision,udev*,dun*,smart*,hfp_bluez5

Tags: bluez5

Related branches

Tony Espy (awe)
Changed in lxc-android-config (Ubuntu):
status: New → Confirmed
importance: Undecided → High
assignee: nobody → Simon Fels (morphis)
Changed in lxc-android-config (Ubuntu RTM):
status: New → Confirmed
importance: Undecided → High
assignee: nobody → Simon Fels (morphis)
tags: added: bluez5
summary: - Update ofono.override plugin excludes ( -P )
+ Update ofono.override plugin excludes ( -P ) for bluez5
Changed in canonical-devices-system-image:
assignee: nobody → John McAleely (john.mcaleely)
importance: Undecided → High
milestone: none → backlog
status: New → Confirmed
Simon Fels (morphis)
Changed in lxc-android-config (Ubuntu RTM):
status: Confirmed → In Progress
Simon Fels (morphis)
Changed in lxc-android-config (Ubuntu RTM):
status: In Progress → Fix Committed
Changed in canonical-devices-system-image:
status: Confirmed → Fix Committed
milestone: backlog → ww02-2016
Changed in canonical-devices-system-image:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.