lvm2 ftbfs against autoconf 2.72

[Olivier Gayot]

excerpt from the logs [1]
-------------------------

    [GEN] command-count.h
    [GEN] command-lines-input.h
gcc -E -P cmdnames.h 2> /dev/null | \
 @EGREP@ -v '^ *(|#.*|config|devtypes|dumpconfig|formats|fullreport|help|lastlog|lvmchange|lvpoll|pvdata|segtypes|systemid|tags|version) *$' > .commands
\
( cat ./license.inc && \
  echo "/* Do not edit. This file is generated by the Makefile. */" && \
  printf "static const char _command_input[] =\n\n\"" && \
  mawk 'BEGIN {ORS = "\\n\"\n\""} !/^#/ && !/---/ && !/^$/' ./command-lines.in && \
  printf '\\n\\n";\n' \
) > command-lines-input.h
\
( cat ./license.inc && \
  echo "/* Do not edit. This file is generated by the Makefile. */" && \
  printf "#define COMMAND_COUNT " && \
  @GREP@ -c '^ID:' command-lines.in \
) > command-count.h
/bin/bash: line 2: @EGREP@: command not found
    [LN] man-generator.c
ln -s -f command.c man-generator.c
/bin/bash: line 5: @GREP@: command not found
make[3]: *** [Makefile:172: command-count.h] Error 127
make[3]: *** Deleting file 'command-count.h'
make[3]: *** Waiting for unfinished jobs....
make[3]: *** [Makefile:166: .commands] Error 127
make[3]: *** Deleting file '.commands'
make[3]: Leaving directory '/<<PKGBUILDDIR>>/debian/build/build_deb/tools'

excerpt from autoconf 2.72 release notes [2]
--------------------------------------------

*** All internal uses of AC_EGREP_CPP and AC_EGREP_HEADER have been removed.
  These macros look for text matching a regular expression in the
  output of the C preprocessor. Their use has been discouraged for
  many years, as they tend to be unreliable; it is better to find a
  way to use AC_COMPILE_IFELSE or AC_PREPROC_IFELSE instead. We have
  finally taken our own advice.

  This change might break configure scripts that expected probes for
  â€˜grep’ and/or the C preprocessor to happen as a side effect of an
  unrelated operation. Such scripts can be fixed by adding
  AC_PROG_EGREP and/or AC_PROG_CPP in an appropriate place.

  The macros affected by this change are AC_C_STRINGIZE,
  AC_C_VARARRAYS, AC_FUNC_GETGROUPS, AC_FUNC_GETLOADAVG,
  AC_HEADER_TIOCGWINSZ, AC_PROG_GCC_TRADITIONAL, AC_TYPE_GETGROUPS,
  AC_TYPE_UID_T, and AC_XENIX_DIR. Many of these macros are themselves
  obsolete; if your configure script uses any of them, check whether
  it is actually needed.

analysis
--------

There is an upstream patch for lvm2: https://gitlab.com/lvmteam/lvm2/-/commit/635df7486f2d6045c8fc085192b036d78b309907

[1] https://launchpadlibrarian.net/749244995/buildlog_ubuntu-oracular-amd64.lvm2_2.03.22-1ubuntu1_BUILDING.txt.gz
[2] https://lists.gnu.org/archive/html/autotools-announce/2023-12/msg00003.html

[Olivier Gayot (ogayot)]

Attaching debdiff. I didn't forward the patch to Debian since a similar patch was already submitted as part of debbug 1079648.

The package is currently building in PPA ogayot/oracular-proposed:

https://launchpad.net/~ogayot/+archive/ubuntu/oracular-proposed/+packages

[Simon Chopin (schopin)]

Uploaded, thanks (with some rich history as a bonus ;-) )

[Launchpad Janitor (janitor)]

This bug was fixed in the package lvm2 - 2.03.22-1ubuntu2

---------------
lvm2 (2.03.22-1ubuntu2) oracular; urgency=medium

  * Apply upstream patch (trimmed) to fix FTBFS with autoconf 2.72 (ensures
    @EGREP@ and @GREP@ get substituted with their path). (LP: #2083302)
    - d/p/autoconf-2.72-grep-egrep.patch

 -- Olivier Gayot <email address hidden> Mon, 30 Sep 2024 22:41:42 +0200