lvresize,lvextend, and fsadm attempt to fsck a mounted filesystem

Bug #1269175 reported by Dave Chiluk on 2014-01-14
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
lvm2 (Ubuntu)
Undecided
reem
Precise
Medium
Dave Chiluk

Bug Description

[Impact]

 * Potential filesystem corruption

 * The above is remedied by backporting a fix from upstream lvm2 that allows fsadm to return 3 on attempts to check a mounted filesystem. This allows lvextend and lvresize to proceed without a fsck when the filesystem is mounted.

[Test Case]

1. Run lvextend -L +...G -r <LV block device>
2. Obtain a message saying:
WARNING!!! The filesystem is mounted. If you continue you ***WILL***
cause ***SEVERE*** filesystem damage.

Do you really want to continue<n>?

3. Reply no, and lvextend or lvresize proceed anyway, freaking out any user who does not recognize the above message as having come from fsck.
4. Reply yes, and possibly corrupt your filesystem.

[Regression Potential]

 * There is regression potential for scripts that depend on fsadm return values. I did search for other references to "fsadm" within the lvm2 package, but found none.

 * Possible regressions may manifest themselves as other filesystem or lvm2 tools failing.

[Other Info]

 * All 4 patches that were backported for this fix exist upstreams
 * Anticipate questions from users, SRU, +1 maintenance, security teams and the Technical Board
 * and address these questions in advance

----------------------------------------------------------------------------------------

Steps to Reproduce:
1. Run lvextend -L +...G -r <LV block device>
2. Obtain a message saying:
WARNING!!! The filesystem is mounted. If you continue you ***WILL***
cause ***SEVERE*** filesystem damage.

Do you really want to continue<n>?

3. Reply no, and lvextend or lvresize proceed anyway, freaking out any user who does not recognize the above message as having come from fsck.
4. Reply yes, and possibly corrupt your filesystem.

ProblemType: Bug
DistroRelease: Ubuntu 12.04
Package: lvm2 2.02.66-4ubuntu7.3
ProcVersionSignature: User Name 3.2.0-57.87-generic 3.2.52
Uname: Linux 3.2.0-57-generic x86_64
ApportVersion: 2.0.1-0ubuntu17.6
Architecture: amd64
Date: Tue Jan 14 22:33:52 2014
Ec2AMI: ami-000005c2
Ec2AMIManifest: FIXME
Ec2AvailabilityZone: nova
Ec2InstanceType: cpu1-ram1-disk50-ephemeral20
Ec2Kernel: aki-00000548
Ec2Ramdisk: ari-00000548
MarkForUpload: True
ProcEnviron:
 TERM=xterm
 PATH=(custom, no user)
 LANG=en_US.UTF-8
 SHELL=/bin/bash
SourcePackage: lvm2
UpgradeStatus: No upgrade log present (probably fresh install)

Dave Chiluk (chiluk) wrote :
Dave Chiluk (chiluk) wrote :

The above is remedied by backporting a fix from upstream lvm that allows fsadm.sh to return 3 on attempts to check a mounted filesystem. This allows lvextend and lvresize to not error out when the filesystem is mounted.

description: updated
tags: removed: ec2-images
Dave Chiluk (chiluk) on 2014-01-14
Changed in lvm2 (Ubuntu):
assignee: nobody → Dave Chiluk (chiluk)
Dave Chiluk (chiluk) wrote :

It looks like the above fixes were incorporated into
v2_02_91
and
v2_02_96 and newer.

That means I will also have to port this fix to quantal.

Changed in lvm2 (Ubuntu):
status: New → Confirmed
status: Confirmed → In Progress
description: updated
description: updated

The attachment "lp1269175.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

tags: added: patch
Dave Chiluk (chiluk) wrote :

I just verified that quantal does not need this fix. So only precise is needed.

Chris J Arges (arges) on 2014-01-15
Changed in lvm2 (Ubuntu Precise):
assignee: nobody → Dave Chiluk (chiluk)
importance: Undecided → Medium
status: New → In Progress
Changed in lvm2 (Ubuntu):
assignee: Dave Chiluk (chiluk) → nobody
status: In Progress → Fix Released
Chris J Arges (arges) wrote :

sponsored for P

Hello Dave, or anyone else affected,

Accepted lvm2 into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/lvm2/2.02.66-4ubuntu7.4 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in lvm2 (Ubuntu Precise):
status: In Progress → Fix Committed
tags: added: verification-needed
Dave Chiluk (chiluk) wrote :

Verified.

tags: added: verification-done
removed: verification-needed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package lvm2 - 2.02.66-4ubuntu7.4

---------------
lvm2 (2.02.66-4ubuntu7.4) precise; urgency=low

  * When calling lvresize or lvextend do not attempt to fsck a mounted
    filesystem. (LP: #1269175)
 -- Dave Chiluk <email address hidden> Wed, 15 Jan 2014 13:01:44 -0600

Changed in lvm2 (Ubuntu Precise):
status: Fix Committed → Fix Released

The verification of the Stable Release Update for lvm2 has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

reem (reemhassan333) on 2016-09-08
Changed in lvm2 (Ubuntu):
assignee: nobody → reem (reemhassan333)
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers