lua-say: bump debhelper compatibility level

[Lucas Kanashiro]

lua-say is blocking dh-lua/27 migration at the moment:

https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-groovy/groovy/amd64/l/lua-say/20200701_012116_54d6a@/log.gz

This is the important part:

autopkgtest [09:19:35]: test dh-lua-tests: - - - - - - - - - - results - - - - - - - - - -
dh-lua-tests FAIL stderr: dh: warning: Compatibility levels before 10 are deprecated (level 9 in use)
autopkgtest [09:19:35]: test dh-lua-tests: - - - - - - - - - - stderr - - - - - - - - - -
dh: warning: Compatibility levels before 10 are deprecated (level 9 in use)
dh_auto_test: warning: Compatibility levels before 10 are deprecated (level 9 in use)

The fix is straightforward: 1) we could bump debhelper compatibility level to something greater than 9; or 2) we could add the allow-stderr restriction to d/t/control.

I filed this bug in Debian:

https://bugs.debian.org/970089

In Debian, I recommend 1) but, in Ubuntu, my proposed solution is 2) because bumping debhelper version might have some side effects we do not want to have at this point of feature freeze.

With the attached debdiff applied autopkgtest is happy again:

autopkgtest [09:24:30]: test dh-lua-tests: - - - - - - - - - - results - - - - - - - - - -
dh-lua-tests PASS
autopkgtest [09:24:31]: @@@@@@@@@@@@@@@@@@@@ summary
dh-lua-tests PASS

[Andreas Hasenack (ahasenack)]

The bottom line is that this dep8 test flagged a real issue and is an opportunity to improve this package. Adding allow-stderr is a workadound, and one I'm afraid will likely remain there forever. The correct fix is to bump the dh level.

I suggest to rephrase this bug to indicate the dh level needs to be bumped, and leave it open even after the allow-stderr workaround is applied.

[Lucas Kanashiro (lucaskanashiro)]

I agree this is an opportunity of improvement and I pointed this out to the Debian maintainer. I want to play on the safe side here because bumping debhelper compatibility level might come with some unexpected behaviors and I think during the feature freeze is not the right moment to take this risk.

I am attaching a new debdiff with the changes you proposed.

[Andreas Hasenack (ahasenack)]

Sure, that's why I asked to leave this bug open :)

+1

[Lucas Kanashiro (lucaskanashiro)]

Thank you for the review and comments! Uploaded:

$ dput ubuntu ../lua-say_1.3-1-4ubuntu1_source.changes
Checking signature on .changes
gpg: ../lua-say_1.3-1-4ubuntu1_source.changes: Valid signature from F823A2729883C97C
Checking signature on .dsc
gpg: ../lua-say_1.3-1-4ubuntu1.dsc: Valid signature from F823A2729883C97C
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading lua-say_1.3-1-4ubuntu1.dsc: done.
  Uploading lua-say_1.3-1-4ubuntu1.debian.tar.xz: done.
  Uploading lua-say_1.3-1-4ubuntu1_source.changes: done.
Successfully uploaded packages.