lttng-modules/2.12.2-1ubuntu1~20.04.2 ADT test failure with linux-hwe-5.11/5.11.0-20.21~20.04.1

Bug #1932165 reported by Kleber Sacilotto de Souza
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
linux-hwe-5.11 (Ubuntu)
Invalid
Undecided
Unassigned
Focal
Invalid
Undecided
Unassigned
lttng-modules (Ubuntu)
New
Undecided
Unassigned
Focal
Fix Released
Critical
Dimitri John Ledkov
Hirsute
Fix Released
Undecided
Unassigned

Bug Description

[Impact]

lttng-modules-dkms is reporting many build errors with linux-hwe-5.11, because of many kernel ABI changes.

[Fix]

Backporting the individual patches to fix all the build errors would be a lot of work and the risk to introduce regressions would be pretty high, therefore it seems safer to update to the version that is also used in impish, that works with 5.11 and it's backward compatible (so it works also with 5.4).

[Test]

ubuntu_lttng_smoke_test from (git://kernel.ubuntu.com/ubuntu/autotest-client-tests)

[Where problems could occur]

This is a major version update, so it does not contain trivial changes as backporting individual patches/fixes, so there's a risk to see regressions with lttng (however potential regressions are *only* limited to lttng).

However, this way is definitely safer than backporting all the individual changes to fix the all the kernel ABI changes introduced in 5.11.

[Original bug report]

This is a scripted bug report about ADT failures while running lttng-modules tests for linux-hwe-5.11/5.11.0-20.21~20.04.1 on focal. Whether this is caused by the dep8 tests of the tested source or the kernel has yet to be determined.

Testing failed on:
    amd64: https://autopkgtest.ubuntu.com/results/autopkgtest-focal/focal/amd64/l/lttng-modules/20210611_205859_b8295@/log.gz
    arm64: https://autopkgtest.ubuntu.com/results/autopkgtest-focal/focal/arm64/l/lttng-modules/20210612_123048_fc99b@/log.gz
    ppc64el: https://autopkgtest.ubuntu.com/results/autopkgtest-focal/focal/ppc64el/l/lttng-modules/20210611_210510_27086@/log.gz
    s390x: https://autopkgtest.ubuntu.com/results/autopkgtest-focal/focal/s390x/l/lttng-modules/20210611_210134_272f4@/log.gz

tags: added: kernel-adt-failure
Changed in lttng-modules (Ubuntu Focal):
status: New → Confirmed
Revision history for this message
Andrea Righi (arighi) wrote :

I've just created a ppa with the latest lttng-modules-dkms from impish recompiled for focal

https://launchpad.net/~arighi/+archive/ubuntu/lttng/

And tested (ubuntu_lttng_smoke_test) with the 5.11 hwe and 5.4 kernels. Everything looks good with both kernels.

The debdiff in attach (against the impish version) only contains the changelog entry to backport the version from impish to focal.

tags: added: patch
Revision history for this message
Andrea Righi (arighi) wrote :

Bad debdiff, ignore it for now, new debdiff incoming.

Revision history for this message
Andrea Righi (arighi) wrote :

New debdiff for the backport from impish to focal in attach.

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

Changelog entries in the #3 debdiff are in the wrong order.

The 2.12.2-1ubuntu1~20.04* entreis should be just above the other 2.12.2 entries.

Such that when build is done with -v2.12.5-1ubuntu1~20.04.2 all changelog entries since 2.12.2 are included, i.e. all the v2.12.5 from impish and etc.

Will redo this before the upload.

Revision history for this message
Dimitri John Ledkov (xnox) wrote :
Revision history for this message
Dimitri John Ledkov (xnox) wrote :
Revision history for this message
Dimitri John Ledkov (xnox) wrote :
Andrea Righi (arighi)
description: updated
Changed in lttng-modules (Ubuntu Focal):
milestone: none → ubuntu-20.04.3
importance: Undecided → Critical
assignee: nobody → Dimitri John Ledkov (xnox)
Revision history for this message
Brian Murray (brian-murray) wrote :

I think a more appropriate and less confusing version number would be 2.12.5-1ubuntu2~20.04.1 given that its a backport of 2.12.5-1ubuntu2 (in Impish) and ~20.04.1 since its the appearance of 2.12.5 in Focal.

Additionally, are there any plans to update the version of lttng-modules in Hirsute? I ask given that Ubuntu 20.04 LTS systems will be able to upgrade Ubuntu 21.04.

Revision history for this message
Brian Murray (brian-murray) wrote (last edit ):

I went ahead and uploaded the version number that makes me happier to the PPA (https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/4630) but it seems to have only built for amd64. (OMG that's what its supposed to do - time to slow my roll.)

Revision history for this message
Łukasz Zemczak (sil2100) wrote : Please test proposed package

Hello Kleber, or anyone else affected,

Accepted lttng-modules into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/lttng-modules/2.12.5-1ubuntu2~20.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in lttng-modules (Ubuntu Focal):
status: Confirmed → Fix Committed
tags: added: verification-needed verification-needed-focal
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

I also agree that maybe we should get the same package backported to hirsute?

Revision history for this message
Kleber Sacilotto de Souza (kleber-souza) wrote :
tags: added: verification-done-focal
removed: verification-needed-focal
Changed in linux-hwe-5.11 (Ubuntu):
status: New → Invalid
Changed in linux-hwe-5.11 (Ubuntu Focal):
status: New → Invalid
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

lttng-modules 2.12.5-1ubuntu2~21.04.1 in hirsute-proposed unapproved queue

Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Hello Kleber, or anyone else affected,

Accepted lttng-modules into hirsute-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/lttng-modules/2.12.5-1ubuntu2~21.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-hirsute to verification-done-hirsute. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-hirsute. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in lttng-modules (Ubuntu Hirsute):
status: New → Fix Committed
tags: added: verification-needed-hirsute
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

This is quite a lot of changes, and there's always risk of regressing existing GA kernel users. But seeing that most of our users are on HWE kernels, I'm thinking about just releasing this early - to unblock the kernel cycle for .3.

So, even though that's not super safe, I'll be conditionally releasing this before the 7-day aging period.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package lttng-modules - 2.12.5-1ubuntu2~20.04.1

---------------
lttng-modules (2.12.5-1ubuntu2~20.04.1) focal; urgency=medium

  * Use Impish version of lttng-modules with Focal (LP: #1932165).

lttng-modules (2.12.5-1ubuntu2) impish; urgency=medium

  * Cherry picks support for kernel v5.13 from upstream/stable-2.12

lttng-modules (2.12.5-1ubuntu1) impish; urgency=medium

  * Cherry picks support for kernel v5.12 from upstream/stable-2.12

lttng-modules (2.12.5-1) unstable; urgency=medium

  * [8e0b514] New upstream version 2.12.5
  * [9feae13] Refreshed patches
  * Add support for kernel v5.11
  * Add support for stable branch kernels with sublevel >=256

lttng-modules (2.12.4-1) unstable; urgency=medium

  * [46f9e6c] New upstream version 2.12.4

lttng-modules (2.12.3-1) unstable; urgency=medium

  * [5674e6f] New upstream version 2.12.3

 -- Andrea Righi <email address hidden> Tue, 13 Jul 2021 12:07:28 +0000

Changed in lttng-modules (Ubuntu Focal):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for lttng-modules has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Kleber Sacilotto de Souza (kleber-souza) wrote :

Confirmed that lttng-modules-dkms 2.12.5-1ubuntu2~21.04.1 in hirsute-proposed can be installed, build and loaded successfully:

$ dkms status
lttng-modules, 2.12.5, 5.11.0-33-generic, x86_64: installed

$ lsmod | grep "^lttng" | awk '{ print $1 }'
lttng_test
lttng_ring_buffer_metadata_mmap_client
lttng_ring_buffer_metadata_client
lttng_ring_buffer_client_overwrite
lttng_ring_buffer_client_mmap_overwrite
lttng_ring_buffer_client_mmap_discard
lttng_ring_buffer_client_discard
lttng_probe_writeback
lttng_probe_workqueue
lttng_probe_vmscan
lttng_probe_v4l2
lttng_probe_udp
lttng_probe_timer
lttng_probe_sunrpc
lttng_probe_statedump
lttng_probe_sock
lttng_probe_skb
lttng_probe_signal
lttng_probe_scsi
lttng_probe_sched
lttng_probe_regulator
lttng_probe_rcu
lttng_probe_random
lttng_probe_printk
lttng_probe_power
lttng_probe_net
lttng_probe_napi
lttng_probe_module
lttng_probe_kvm
lttng_probe_kmem
lttng_probe_jbd2
lttng_probe_irq
lttng_probe_gpio
lttng_probe_compaction
lttng_probe_block
lttng_probe_asoc
lttng_probe_9p
lttng_tracer
lttng_statedump
lttng_wrapper
lttng_uprobes
lttng_lib_ring_buffer
lttng_kretprobes
lttng_kprobes
lttng_clock_plugin_test
lttng_clock

autopkgtest also completed successfully:

amd64 - https://autopkgtest.ubuntu.com/results/autopkgtest-hirsute/hirsute/amd64/l/lttng-modules/20210827_092600_f29e1@/log.gz
arm64 - https://autopkgtest.ubuntu.com/results/autopkgtest-hirsute/hirsute/arm64/l/lttng-modules/20210827_093210_e3a3a@/log.gz
admhf - not supported
ppc64el - https://autopkgtest.ubuntu.com/results/autopkgtest-hirsute/hirsute/ppc64el/l/lttng-modules/20210827_092927_f29e1@/log.gz
s390x - https://autopkgtest.ubuntu.com/results/autopkgtest-hirsute/hirsute/s390x/l/lttng-modules/20210827_091858_e3a3a@/log.gz

Thanks!

tags: added: verification-done-hirsute
removed: verification-needed-hirsute
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package lttng-modules - 2.12.5-1ubuntu2~21.04.1

---------------
lttng-modules (2.12.5-1ubuntu2~21.04.1) hirsute; urgency=medium

  * Use Impish version of lttng-modules with Hirsute (LP: #1932165).

lttng-modules (2.12.5-1ubuntu2) impish; urgency=medium

  * Cherry picks support for kernel v5.13 from upstream/stable-2.12

lttng-modules (2.12.5-1ubuntu1) impish; urgency=medium

  * Cherry picks support for kernel v5.12 from upstream/stable-2.12

lttng-modules (2.12.5-1) unstable; urgency=medium

  * [8e0b514] New upstream version 2.12.5
  * [9feae13] Refreshed patches
  * Add support for kernel v5.11
  * Add support for stable branch kernels with sublevel >=256

lttng-modules (2.12.4-1) unstable; urgency=medium

  * [46f9e6c] New upstream version 2.12.4

lttng-modules (2.12.3-1) unstable; urgency=medium

  * [5674e6f] New upstream version 2.12.3

 -- Andrea Righi <email address hidden> Tue, 13 Jul 2021 12:07:28 +0000

Changed in lttng-modules (Ubuntu Hirsute):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers