ldm only runs "ltspfsmounter all cleanup" when x-session-manager exits without error
Bug #121254 reported by
Gavin McCullagh
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| ltsp (Ubuntu) |
Fix Released
|
Undecided
|
Scott Balneaves | ||
Bug Description
/usr/sbin/ldm as in feisty includes the lines:
155 # make sure we clean up after logout if localdev is used
156 if self.use_localdev:
157 session_manager = session_manager+' && ltspfsmounter all cleanup'
158 print "info: Enabling localdev support."
which means that if the session_manager program exists without error, "ltspfsmounter all cleanup" gets run.
If the session manager gets killed, the session crashes or things otherwise end with an error, this command should still be run.
I suggest that this should therefore be changed from "&&" to "||" so it gets run no matter what exit code the session manager gives.
Revision history for this message
| Scott Balneaves (sbalneav) wrote | #1 |
| Changed in ltsp: | |
| assignee: | nobody → sbalneav |
| status: | New → Fix Committed |
Revision history for this message
| Oliver Grawert (ogra) wrote | #2 |
| Changed in ltsp: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Yep, good catch.
I've fixed it in my tree, rev 386, probably won't make it for tribe 2, but will be in for tribe 3
Scott