Missing dep8 tests
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
logwatch |
New
|
Unknown
|
|||
logwatch (Ubuntu) |
Fix Released
|
Wishlist
|
Miriam España Acebal |
Bug Description
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
As of April 3, 2017, this source package did not contain package tests
in the current development release of Ubuntu, named Zesty. This was
determined by running `pull-lp-source logwatch zesty` and then
checking for the existence of 'debian/tests/' and
'debian/
declaration in the debian/control file, 2) any 'test', 'tests',
'testsuite', or 'test-suite' directories, 3) go tests (if applicable),
and 4) a test suite declared in a setup.py (if applicable).
If you feel this report is incorrect (e.g. this is a library or a source
only package) or the check above missed some other package level test
please reply explaining why and mark this bug as 'invalid'.
Test automation is essential to higher levels of quality and confidence
in updates to packages. dep8 tests [1] specify how automatic testing can
be integrated into packages and then run by package maintainers before
new uploads.
This defect is to report the absence of these tests and to report the
opportunity as a potential item for development by both new and
experienced contributors.
Thanks!
[1] http://
affects ubuntu/logwatch
status new
importance wishlist
tag needs-dep8
- ---
Joshua Powers
Ubuntu Server
Canonical Ltd
-----BEGIN PGP SIGNATURE-----
iQIcBAEBCAAGBQJ
4/xZG2T5bWNDhJ5
Nd5r9uoWOIl8IW0
G7aMm6b9lMRoIKB
+nXXVg/
j+cRyUIB9VTjkny
Hbw++eRWm8VNKGp
9CpmxP9x10pn4ik
4UkSbEDGLXVTfi+
OHVY/IsXa5XRYwK
lbRMU3rR742q3XG
ii2QKrzzJCm3Pg6
=Wshy
-----END PGP SIGNATURE-----
Related branches
- Sergio Durigan Junior (community): Approve
- Canonical Server: Pending requested
- git-ubuntu import: Pending requested
-
Diff: 1085 lines (+842/-2)15 files modifieddebian/changelog (+484/-0)
debian/control (+4/-2)
debian/patches/0010-zz-zfs-detect-zfs-location.patch (+42/-0)
debian/patches/0014-zz-sys-Suppress-warnings-if-Sys-CPU-or-Sys-MemInfo-a.patch (+52/-0)
debian/patches/0015-pam_unix-Ignore-issues-about-etc-securetty-being-mis.patch (+44/-0)
debian/patches/series (+5/-0)
debian/tests/apparmor-unmatched-entries (+41/-0)
debian/tests/basic-checks (+34/-0)
debian/tests/control (+15/-0)
debian/tests/data/su-l (+2/-0)
debian/tests/data/unmatched-entries-apparmor_kern.log (+14/-0)
debian/tests/detail (+16/-0)
debian/tests/packages-and-report (+36/-0)
debian/tests/su-l-check (+37/-0)
debian/tests/syntax-check (+16/-0)
- Sergio Durigan Junior (community): Approve
- Bryce Harrington (community): Approve
- Canonical Server: Pending requested
-
Diff: 293 lines (+231/-0)10 files modifieddebian/changelog (+20/-0)
debian/tests/apparmor-unmatched-entries (+41/-0)
debian/tests/basic-checks (+34/-0)
debian/tests/control (+15/-0)
debian/tests/data/su-l (+2/-0)
debian/tests/data/unmatched-entries-apparmor_kern.log (+14/-0)
debian/tests/detail (+16/-0)
debian/tests/packages-and-report (+36/-0)
debian/tests/su-l-check (+37/-0)
debian/tests/syntax-check (+16/-0)
Changed in logwatch (Ubuntu): | |
assignee: | nobody → Miriam España Acebal (mirespace) |
Changed in logwatch: | |
status: | Unknown → New |
I'm not sure there's a whole lot of value to gain from a dep8 test of this package, it's basically just a collection of perl scripts.
Probably 90% of issues would be caught by just doing a syntax check on each of the Perl files (i.e. perl -c lib/Logwatch.pm; etc.)
A simple integration test for this might be to just run logwatch over a collection of sample config files, and verify the generated report includes stuff it should be flagging, and omits chaff that it shouldn't. Some recent logwatch SRUs are using this approach for their test cases.