[Patch] Unmatched named lines

[Steffen Klemer]

On Ubuntu 16.04 I get unmatched lines from named like

Dec 26 03:24:41 localhost named[2690]: zone 10.in-addr.arpa/IN: notify from 134.76.00.00#11179: serial 390000000

I fixed it using:

--- named 2016-12-27 13:47:30.375372799 +0100
+++ named_ 2016-12-27 13:48:31.728155333 +0100
@@ -213,8 +213,6 @@
       $ZoneRemoved{$Zone}++;
    } elsif ( ($Zone) = ( $ThisLine =~ /received notify for zone '(.*)'/ ) ) {
       $ZoneReceivedNotify{$Zone}++;
- } elsif ( ($Zone) = ( $ThisLine =~ /zone (.+): notify from .+: serial [0-9]+/ ) ) {
- $ZoneReceivedNotify{$Zone}++;
    } elsif ( ($Zone) = ( $ThisLine =~ /zone (.*): notify from .* up to date/ ) ) {
       $ZoneReceivedNotify{$Zone}++;
    } elsif ( ($Zone) = ( $ThisLine =~ /zone (.+): refused notify from non-master/ ) ) {

[Steffen Klemer (sklemer1)]

To be more specific:

root@fernglas:/var/log# named -V
BIND 9.10.3-P4-Ubuntu <id:ebd72b3>
[...]

root@fernglas:/var/log# dpkg -s bind9
Package: bind9
Status: install ok installed
Priority: optional
Section: net
Installed-Size: 1626
Maintainer: Ubuntu Developers <email address hidden>
Architecture: amd64
Version: 1:9.10.3.dfsg.P4-8ubuntu1.3
[...]

[Eric Desrochers (slashd)]

Hi Steffen,

Is your patch in logwatch upstream ?

If not... the first step would be to make sure your proposal patch is approved/merged upstream.

Then you can request a backport in Zesty (devel release) and then Xenial by attaching debdiff(s) for both Z and X.

Ideally, opening a debian bug is strongly recommended to make sure debian has the fix as well.

- Eric

[Eric Desrochers (slashd)]

I also encouraged you to read the following[1] if you want to submit the patch yourself via the SRU process.

[1] - https://wiki.ubuntu.com/StableReleaseUpdates

- Eric

[Eric Desrochers (slashd)]

I didn't look at the src code, but reading at the bug it's not clear if the fix is in logwatch or bind9. Is logwatch has been affected by mistake ? Please confirm.

Either way, it doesn't change the fact that the fix needs to be approved/merged upstream first before submitting for SRU.

- Eric

[Steffen Klemer (sklemer1)]

Yes, it is for logwatch and not bind.
No, it is not upstream.

I'll send it to upstream then and post the relevant link/bug id here.

[Eric Desrochers (slashd)]

Let me know if you need help for the SRU, I can help you with that portion

[Eric Desrochers (slashd)]

Also you could have a look at the current logwatch upstream git repo and see if there is already a commit that address the situation you are fixing yourself before submitting upstream.

I did a quick search and I found a major rework for named report, which might solve the situation...
I think it's worth looking at the existing git repo and see if problem is solve already.

If it already in place in logwatch git, then you can request a backport in Xenial and other affected releases.

If not already in place, then submit your fix upstream, and then once approve/merged we can then backport it into Ubuntu affected releases.

* Upstream repo :

$ git clone git://git.code.sf.net/p/logwatch/git logwatch-git

* Potential candidate that IMHO is worth reviewing:

commit 22c55d1246c8d2295e416105b0bef695349fcb04

    [named] Major rework for named report

    - Catch connection timed out zone transfer failures
    - Catch zone expired and other messages that have view names
    - Move important messages/errors to the top of the report
    - Always report deniend zone transfers
    - Ignore client signer approved messages

- Eric

[Eric Desrochers (slashd)]

It looks like that "22c55d1246c8d2295e416105b0bef695349fcb04" is already in Xenial, but again reviewing the upstream git src code is still a good approach before submitting a fix upstream.

Hope it helps !

[Launchpad Janitor (janitor)]

[Expired for logwatch (Ubuntu) because there has been no activity for 60 days.]