2023-02-27 19:24:40 |
Athos Ribeiro |
bug |
|
|
added bug |
2023-02-27 19:32:09 |
Athos Ribeiro |
description |
As part of the log4cplus MIR work (LP: #2003549), we are adding DEP8 tests and a symbols file for liblog4cplus.
While those changes should not need a FFe, we are also including a "-fvisibility=hidden" build flag, since the source code does is annotated to only export the symbols the developers want to be publicly exposed.
As a result several symbols (which were leaking, belonging to other libraries) are no longer being exposed. Since this is a change in the shared library binaries, we decided it would be better to file an FFe.
We have ran test rebuilds of the reverse dependencies (isc-kea and openvdb) and also verified (best effort) that the versions of such reverse dependencies in the archive are still functional after the changes.
The changes in question and further discussions are available at https://code.launchpad.net/~athos-ribeiro/ubuntu/+source/log4cplus/+git/log4cplus/+merge/437047. |
As part of the log4cplus MIR work (LP: #2003549), we are adding DEP8 tests and a symbols file for liblog4cplus.
While those changes should not need a FFe, we are also including a "-fvisibility=hidden" build flag, since the source code does is annotated to only export the symbols the developers want to be publicly exposed.
As a result several symbols (which were leaking, belonging to other libraries) are no longer being exposed. Since this is a change in the shared library binaries, we decided it would be better to file an FFe.
Note that the new exported symbols list is the intended one for linux systems: the upstream project claims that autotools is the preferred build system for unix-like systems, and the proposed symbols file is what we get from default autotools based builds. However, the package currently builds with cmake, where the "-fvisibility=hidden" flag was missing.
We have ran test rebuilds of the reverse dependencies (isc-kea and openvdb) and also verified (best effort) that the versions of such reverse dependencies in the archive are still functional after the changes.
The changes in question and further discussions are available at https://code.launchpad.net/~athos-ribeiro/ubuntu/+source/log4cplus/+git/log4cplus/+merge/437047.
A PPA with the proposed package and the rdeps test rebuilds is available at https://launchpad.net/~athos-ribeiro/+archive/ubuntu/log4cplus-symbols/+packages.
This Is the proposed chagelog diff:
diff --git a/debian/changelog b/debian/changelog
index 3177ffb..10c0af2 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,14 @@
+log4cplus (2.0.8-1ubuntu1) lunar; urgency=medium
+
+ * d/rules: set the default symbol visibility to hidden.
+ * d/liblog4cplus-2.0.5.symbols*: add symbols files.
+ * Apply filters to exported symbols.
+ * d/liblog4cplus-2.0.5.lintian-overrides: remove lintian overrides for
+ missing symbols file.
+ * d/tests: use upstream examples as DEP8 tests.
+
+ -- Athos Ribeiro <athos.ribeiro@canonical.com> Tue, 07 Feb 2023 08:43:44 -0300
+
log4cplus (2.0.8-1) unstable; urgency=medium
* New upstream version 2.0.8 |
|
2023-02-27 19:33:01 |
Athos Ribeiro |
bug |
|
|
added subscriber Ubuntu Release Team |
2023-02-27 19:33:10 |
Athos Ribeiro |
bug |
|
|
added subscriber Ubuntu Server |
2023-02-27 19:41:03 |
Andreas Hasenack |
bug |
|
|
added subscriber Andreas Hasenack |
2023-02-27 19:41:46 |
Andreas Hasenack |
description |
As part of the log4cplus MIR work (LP: #2003549), we are adding DEP8 tests and a symbols file for liblog4cplus.
While those changes should not need a FFe, we are also including a "-fvisibility=hidden" build flag, since the source code does is annotated to only export the symbols the developers want to be publicly exposed.
As a result several symbols (which were leaking, belonging to other libraries) are no longer being exposed. Since this is a change in the shared library binaries, we decided it would be better to file an FFe.
Note that the new exported symbols list is the intended one for linux systems: the upstream project claims that autotools is the preferred build system for unix-like systems, and the proposed symbols file is what we get from default autotools based builds. However, the package currently builds with cmake, where the "-fvisibility=hidden" flag was missing.
We have ran test rebuilds of the reverse dependencies (isc-kea and openvdb) and also verified (best effort) that the versions of such reverse dependencies in the archive are still functional after the changes.
The changes in question and further discussions are available at https://code.launchpad.net/~athos-ribeiro/ubuntu/+source/log4cplus/+git/log4cplus/+merge/437047.
A PPA with the proposed package and the rdeps test rebuilds is available at https://launchpad.net/~athos-ribeiro/+archive/ubuntu/log4cplus-symbols/+packages.
This Is the proposed chagelog diff:
diff --git a/debian/changelog b/debian/changelog
index 3177ffb..10c0af2 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,14 @@
+log4cplus (2.0.8-1ubuntu1) lunar; urgency=medium
+
+ * d/rules: set the default symbol visibility to hidden.
+ * d/liblog4cplus-2.0.5.symbols*: add symbols files.
+ * Apply filters to exported symbols.
+ * d/liblog4cplus-2.0.5.lintian-overrides: remove lintian overrides for
+ missing symbols file.
+ * d/tests: use upstream examples as DEP8 tests.
+
+ -- Athos Ribeiro <athos.ribeiro@canonical.com> Tue, 07 Feb 2023 08:43:44 -0300
+
log4cplus (2.0.8-1) unstable; urgency=medium
* New upstream version 2.0.8 |
As part of the log4cplus MIR work (LP: #2003549), we are adding DEP8 tests and a symbols file for liblog4cplus.
While those changes should not need a FFe, we are also including a "-fvisibility=hidden" build flag, since the source code is annotated to only export the symbols the developers want to be publicly exposed.
As a result several symbols (which were leaking, belonging to other libraries) are no longer being exposed. Since this is a change in the shared library binaries, we decided it would be better to file an FFe.
Note that the new exported symbols list is the intended one for linux systems: the upstream project claims that autotools is the preferred build system for unix-like systems, and the proposed symbols file is what we get from default autotools based builds. However, the package currently builds with cmake, where the "-fvisibility=hidden" flag was missing.
We have ran test rebuilds of the reverse dependencies (isc-kea and openvdb) and also verified (best effort) that the versions of such reverse dependencies in the archive are still functional after the changes.
The changes in question and further discussions are available at https://code.launchpad.net/~athos-ribeiro/ubuntu/+source/log4cplus/+git/log4cplus/+merge/437047.
A PPA with the proposed package and the rdeps test rebuilds is available at https://launchpad.net/~athos-ribeiro/+archive/ubuntu/log4cplus-symbols/+packages.
This Is the proposed chagelog diff:
diff --git a/debian/changelog b/debian/changelog
index 3177ffb..10c0af2 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,14 @@
+log4cplus (2.0.8-1ubuntu1) lunar; urgency=medium
+
+ * d/rules: set the default symbol visibility to hidden.
+ * d/liblog4cplus-2.0.5.symbols*: add symbols files.
+ * Apply filters to exported symbols.
+ * d/liblog4cplus-2.0.5.lintian-overrides: remove lintian overrides for
+ missing symbols file.
+ * d/tests: use upstream examples as DEP8 tests.
+
+ -- Athos Ribeiro <athos.ribeiro@canonical.com> Tue, 07 Feb 2023 08:43:44 -0300
+
log4cplus (2.0.8-1) unstable; urgency=medium
* New upstream version 2.0.8 |
|
2023-02-27 21:13:41 |
Athos Ribeiro |
merge proposal linked |
|
https://code.launchpad.net/~athos-ribeiro/ubuntu/+source/log4cplus/+git/log4cplus/+merge/437047 |
|
2023-03-08 16:40:15 |
Graham Inggs |
log4cplus (Ubuntu): status |
New |
Incomplete |
|
2023-03-08 17:37:23 |
Athos Ribeiro |
log4cplus (Ubuntu): status |
Incomplete |
New |
|
2023-03-09 06:45:27 |
Graham Inggs |
log4cplus (Ubuntu): status |
New |
Triaged |
|
2023-03-09 12:00:25 |
Athos Ribeiro |
log4cplus (Ubuntu): status |
Triaged |
Fix Committed |
|
2023-03-10 02:28:29 |
Launchpad Janitor |
log4cplus (Ubuntu): status |
Fix Committed |
Fix Released |
|
2024-03-04 19:57:47 |
Launchpad Janitor |
merge proposal linked |
|
https://code.launchpad.net/~athos-ribeiro/ubuntu/+source/log4cplus/+git/log4cplus/+merge/461748 |
|
2024-03-04 20:52:49 |
Athos Ribeiro |
merge proposal unlinked |
https://code.launchpad.net/~athos-ribeiro/ubuntu/+source/log4cplus/+git/log4cplus/+merge/461748 |
|
|