4.19+ (and possibly -stable trees?) need a fix from upstream

Bug #1816650 reported by Nish Aravamudan on 2019-02-19
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
lldpd (Ubuntu)
Undecided
Unassigned
Bionic
Undecided
Nish Aravamudan
Cosmic
Undecided
Nish Aravamudan

Bug Description

[Impact]

lldpctl indicates duplicate LLDP records. While the above issue is only seen on kernels newer than 4.19 (so 19.04+, which implies 18.04.3's kernel), this patch has been backported to the -stable tree.

[Test Case]

On a system with a bonded link, issue:

# lldpctl | grep PortDescr

and it will indicate duplicate records.

After applying the fix, issue the same command and duplicates will be elided.

[Regression Potential]

However, the bond-specific code in lldpctl is only needed on kernels <= 2.6.27 per upstream, which is older than any kernel in any supported Ubuntu. This fix allows future-proofs lldpctl for the eventual HWE impact.

[Original Description]

So I think this commit:

https://github.com/torvalds/linux/commit/6a9e461f6fe4434e6172304b69774daff9a3ac4c

has been backported to some -stable trees.

This makes lldpd < 1.0.3 duplicate entries. I think given both -stable trees in existing Ubuntu and the HWE stack in 18.04 (even if only 18.04.3), we should backport

https://github.com/vincentbernat/lldpd/pull/307/commits/0638075c721323aa6aeab9c6ab282861f53c9f2f

to the source package in 18.04+.

Nish Aravamudan (nacc) on 2019-02-19
Changed in lldpd (Ubuntu):
status: New → Fix Released
Changed in lldpd (Ubuntu Bionic):
assignee: nobody → Nish Aravamudan (nacc)
Changed in lldpd (Ubuntu Cosmic):
assignee: nobody → Nish Aravamudan (nacc)
Nish Aravamudan (nacc) on 2019-02-20
description: updated
Changed in lldpd (Ubuntu Cosmic):
status: New → Won't Fix
status: Won't Fix → In Progress
Changed in lldpd (Ubuntu Bionic):
status: New → In Progress
description: updated

Hello Nish, or anyone else affected,

Accepted lldpd into cosmic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/lldpd/1.0.1-1ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-cosmic to verification-done-cosmic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-cosmic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in lldpd (Ubuntu Cosmic):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-cosmic
Changed in lldpd (Ubuntu Bionic):
status: In Progress → Fix Committed
tags: added: verification-needed-bionic
Brian Murray (brian-murray) wrote :

Hello Nish, or anyone else affected,

Accepted lldpd into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/lldpd/0.9.9-1ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Nish Aravamudan (nacc) wrote :

Before:

# lldpctl | grep PortDescr
    PortDescr: et-0/0/23:0
    PortDescr: et-0/0/23:0
    PortDescr: et-0/0/23:0
    PortDescr: et-0/0/23:0

After:

# lldpctl | grep PortDescr
    PortDescr: et-0/0/23:0
    PortDescr: et-0/0/23:0

Using: 0.9.9-1ubuntu0.1 on 18.04

tags: added: verification-done-bionic
removed: verification-needed-bionic
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package lldpd - 0.9.9-1ubuntu0.1

---------------
lldpd (0.9.9-1ubuntu0.1) bionic; urgency=medium

  * debian/patches/0002-remove-specific-handling-for-bond.patch: Remove
    specific handling for bonds. Thanks to Vincent Bernat
    <email address hidden>. Closes LP: #1816650.

 -- Nishanth Aravamudan <email address hidden> Wed, 20 Feb 2019 14:24:36 -0600

Changed in lldpd (Ubuntu Bionic):
status: Fix Committed → Fix Released

The verification of the Stable Release Update for lldpd has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Łukasz Zemczak (sil2100) wrote :

Thank you for the verification! I have released this to bionic-updates just now. Could you or someone else perform the same validation on a 18.10 system?

The fix for this bug has been awaiting testing feedback in the -proposed repository for cosmic for more than 90 days. Please test this fix and update the bug appropriately with the results. In the event that the fix for this bug is still not verified 15 days from now, the package will be removed from the -proposed repository.

tags: added: removal-candidate
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers