LXD snap no longer seeded in any images so does not need special handling in unminimize logic

[Philip Roche]

The LXD snap is no longer seeded in any images since Noble+ so the unminimize logic in https://git.launchpad.net/livecd-rootfs/tree/live-build/auto/build?h=ubuntu/noble#n290 and https://git.launchpad.net/livecd-rootfs/tree/live-build/ubuntu-server/hooks/01-unminimize.chroot_early?h=ubuntu/noble#n17 is no longer required.

lxd-installer can remain installed.

This applies for Noble+ so requires SRU back to Noble

[ Impact ]

Attempting to install LXD snap on unminimize when this is no longer required.

Due to how daily server image builds upgrade to packages from -proposed this is also causing server image build failures - see https://bugs.launchpad.net/ubuntu/+source/lxd-installer/+bug/2061017

[ Test Plan ]

 * Successfully build server daily image
 * Build cloud minimal image and confirm unminimize does not install LXD snap

[ Where problems could occur ]

 * If the server image does not build or if LXD snap continues to be installed

[Launchpad Janitor (janitor)]

This bug was fixed in the package livecd-rootfs - 24.10.2

---------------
livecd-rootfs (24.10.2) oracular; urgency=medium

  [ Michael Hudson-Doyle ]
  * Replace 'ubuntustudio-dvd' project with an almost identical 'ubuntustudio'
    project.

  [ Philip Roche ]
  * No longer install LXD snap in unminimize script (LP: #2066905)

 -- Philip Roche <email address hidden> Thu, 23 May 2024 14:11:57 +0100

[Philip Roche (philroche)]

Now in noble unapproved queue https://launchpad.net/ubuntu/noble/+queue?queue_state=1&queue_text=livecd-rootfs

[Steve Langasek (vorlon)]

Hello Philip, or anyone else affected,

Accepted livecd-rootfs into noble-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/livecd-rootfs/24.04.71 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-noble to verification-done-noble. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-noble. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Paride Legovini (paride)]

[ Noble Verification: server daily image build ]

I downloaded a recent noble-live-server-amd64.iso daily, specifically:

$ bsdtar -x -f noble-live-server-amd64.iso -O .disk/info
20240616

Opened its cd-build-log file:

https://ubuntu-archive-team.ubuntu.com/cd-build-logs/ubuntu-server/noble/daily-live-20240616.log

which points to this livefs build:

ubuntu-server-live-amd64: https://launchpad.net/~ubuntu-cdimage/+livefs/ubuntu/noble/ubuntu-server-live/+build/634647

whose buildlog (https://launchpadlibrarian.net/735405004/buildlog_ubuntu_noble_amd64_ubuntu-server-live_BUILDING.txt.gz) shows:

Selecting previously unselected package livecd-rootfs.
Preparing to unpack .../153-livecd-rootfs_24.04.71_amd64.deb ...
Unpacking livecd-rootfs (24.04.71) ...
[...]
Setting up livecd-rootfs (24.04.71) ...

and livecd-rootfs (24.04.71) is the version currently in noble-proposed that we want to verify.

I manually performed an all-defaults install from that ISO and successfully verified that:

1. right after install, the lxd snap is not installed
2. there is a /usr/sbin/lxc file provided by the lxd-installer package
3. if I run `lxc`, the snap gets auto installed, then lxc from the snap is executed
4. running `lxc` again works fine, running the command from the snap

[Philip Roche (philroche)]

I have created a test noble minimal cloud image with the -proposed livecd-rootfs 24.04.71 and also successfully confirmed that `unminimize` no longer attempts to install the LXD snap.

I built the cloud image in launchpad and tested using qemu.

Marking as verification-done

[Philip Roche (philroche)]

Adding `block-proposed-noble` tag as the changes in https://code.launchpad.net/~philroche/livecd-rootfs/+git/livecd-rootfs/+merge/466388 actually remove all of unminimize calls - not just the lxd specific changes. I will create bug to track this.

[Robie Basak (racb)]

Thank you for your diligence! In that case, marking this as not ready.

[Andreas Hasenack (ahasenack)]

Hello Philip, or anyone else affected,

Accepted livecd-rootfs into noble-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/livecd-rootfs/24.04.72 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-noble to verification-done-noble. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-noble. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Philip Roche (philroche)]

LP: #2069828 (https://bugs.launchpad.net/ubuntu/+source/livecd-rootfs/+bug/2069828) was created to track the regression. The fix to LP: #2069828 is now in version 24.04.72 which is now in -proposed and will be verified. As such I am removing `block-proposed-noble` tag as lack of verification of 24.04.72 will block.

[Philip Roche (philroche)]

From ubuntu-server daily live image build 20240628 @ https://cdimage.ubuntu.com/ubuntu-server/noble/daily-live/20240628/ with amd64 build @ https://launchpad.net/~ubuntu-cdimage/+livefs/ubuntu/noble/ubuntu-server-live/+build/642557 with these changes and I can confirm:

* from the build log that 24.04.72 was used.
* from the log @ that `/usr/local/sbin/unminimize` is now being called in `01-unminimize.chroot_early` as expected.
* Build was successful
* Ubuntu Server (minimized) install of server resulted in the following test results https://pastebin.ubuntu.com/p/CF783fb7H9/
* Ubuntu Server install of server resulted in the following test results https://pastebin.ubuntu.com/p/ztwHFR2Ysf/
* LXD is not preseeded.
* Layers/install targets are as expected with recommends packages only present in the non minimized install.

Marking verified.

[Launchpad Janitor (janitor)]

This bug was fixed in the package livecd-rootfs - 24.04.72

---------------
livecd-rootfs (24.04.72) noble; urgency=medium

  [ Heinrich Schuchardt ]
  * riscv64: use earlycon=sbi on command line (LP: #2068739)

  [ Philip Roche ]
  * Revert removal of unminimize call in server builds (LP: #2069828)

livecd-rootfs (24.04.71) noble; urgency=medium

  * Re-enable ability to build HyperV desktop images (LP: #2064280)

livecd-rootfs (24.04.70) noble; urgency=medium

  [ Łukasz 'sil2100' Zemczak ]
  * Add experimental support for building ubuntu-core-desktop installer images
    (LP: #2063203)

  [ Philip Roche ]
  * No longer install LXD snap in unminimize script (LP: #2066905)

 -- Philip Roche <email address hidden> Mon, 24 Jun 2024 14:24:52 +0100

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for livecd-rootfs has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.