| 2020-07-15 14:14:45 |
Łukasz Zemczak |
description |
[Impact]
A while back, we have launched Ubuntu Appliances, a set of ubuntu-core based appliance-based images for various use-cases. One can read more about those here:
https://ubuntu.com/appliance
The first batch of appliances have been created with some local tooling. This is counter-productive, as there will be more and more appliances appearing in time. We want to support building and publishing of such images via cdimage. For this, we need to add support for building such images into livecd-rootfs.
To make the task of adding new appliances easier, we want to add support for building arbitrarily named appliance images. The proposed change adds a special appliance-<MODEL> wildcard SUBARCH, which results in building an image of the specified model - additionally setting the brand to ubuntu from the default canonical one.
[Test Case]
Once the package builds in -proposed, attempt a livefs ubuntu-core build with SUBARCH=appliance-adguard-home-core18-amd64, make sure it succeeds. Then launch another livefs ubuntu-core build with SUBARCH=appliance-adguard-home-core18-pi, make sure it succeeds.
To make sure regular core builds are still working, check if -proposed based bionic ubuntu-core and classic raspi images still build correctly.
[Regression Potential]
We need to make sure that regular ubuntu-core and preinstalled server builds still work correctly, as this is where any regressions can be seen. But we added a test case for that. |
[Impact]
A while back, we have launched Ubuntu Appliances, a set of ubuntu-core based appliance-based images for various use-cases. One can read more about those here:
https://ubuntu.com/appliance
The first batch of appliances have been created with some local tooling. This is counter-productive, as there will be more and more appliances appearing in time. We want to support building and publishing of such images via cdimage. For this, we need to add support for building such images into livecd-rootfs.
To make the task of adding new appliances easier, we want to add support for building arbitrarily named appliance images. The proposed change adds a special appliance-<MODEL> wildcard SUBARCH, which results in building an image of the specified model - additionally setting the brand to ubuntu from the default canonical one.
[Test Case]
Once the package builds in -proposed, attempt a livefs ubuntu-core build with SUBARCH=appliance-adguard-home-core18-amd64, make sure it succeeds. Then launch another livefs ubuntu-core build with SUBARCH=appliance-adguard-home-core18-pi, make sure it succeeds.
To make sure regular core builds are still working, check if -proposed based bionic ubuntu-core and classic raspi images still build correctly.
[Regression Potential]
We need to make sure that regular ubuntu-core and preinstalled server builds still work correctly, as this is where any regressions can be seen. But we added a test case for that.
[Other Info]
Note to SRU members: this is a change very specific to bionic. I will also push it to groovy later, but it basically only has an use-case in bionic (uc18). When we switch appliances to uc20, we'll need to push this to focal - but right now it makes no sense to have it there (and no way to test it).
So I'd appreciate only accepting it for bionic. |
|
