[backport] magic-proxy: dump proxy log to stdout on failure

Bug #1847300 reported by Robert C Jennings on 2019-10-08
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
livecd-rootfs (Ubuntu)
Undecided
Unassigned
Xenial
Undecided
Unassigned
Bionic
Undecided
Unassigned
Disco
Undecided
Unassigned

Bug Description

[Impact]

When we encounter a failure in 'lb binary' the launchpad builders can
only surface the build output from stdout. If the binary hook failure
implicates the archive we can not determine fault without the apt
proxy log. Backporting the patch from eoan will dump the proxy log
to stdout to aid in debugging these failures.

[Test case]

Run a build with a $REPO_SNAPSHOT_STAMP and a binary hook with 'exit 1'. The apt proxy log should end up on stdout.

[Regression Potential]

Nearly none. This dumps a file to stdout in the failure exit path; a failure at this stage does not change the outcome of the build.

[Other Info]

We are seeing issues today in builds that need this debug output in place, we would like to move this SRU through quickly. The code has been running in eoan for at least a week without issue.

Related branches

Hello Robert, or anyone else affected,

Accepted livecd-rootfs into disco-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/livecd-rootfs/2.578.9 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-disco to verification-done-disco. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-disco. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in livecd-rootfs (Ubuntu Disco):
status: New → Fix Committed
tags: added: verification-needed verification-needed-disco
Changed in livecd-rootfs (Ubuntu Bionic):
status: New → Fix Committed
tags: added: verification-needed-bionic
Łukasz Zemczak (sil2100) wrote :

Hello Robert, or anyone else affected,

Accepted livecd-rootfs into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/livecd-rootfs/2.525.31 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in livecd-rootfs (Ubuntu Xenial):
status: New → Fix Committed
tags: added: verification-needed-xenial
Łukasz Zemczak (sil2100) wrote :

Hello Robert, or anyone else affected,

Accepted livecd-rootfs into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/livecd-rootfs/2.408.55 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

tags: added: id-5d889967d57ad866a3d11ab1
Robert C Jennings (rcj) wrote :

Test builds with -proposed on xenial, disco, and bionic show that the proxy log is written to stdout on failure in a binary hook. Marking this as verification-done.

tags: added: verification-done verification-done-bionic verification-done-disco verification-done-xenial
removed: verification-needed verification-needed-bionic verification-needed-disco verification-needed-xenial
Robert C Jennings (rcj) wrote :

Łukasz, with verification done, can we get this promoted to -update now? We need to debug failures we're seeing in production and need this change. Thanks.

The verification of the Stable Release Update for livecd-rootfs has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package livecd-rootfs - 2.525.31

---------------
livecd-rootfs (2.525.31) bionic; urgency=medium

  * magic-proxy: dump proxy log to stdout on failure (LP: #1847300)

 -- Robert C Jennings <email address hidden> Tue, 08 Oct 2019 11:00:07 -0500

Changed in livecd-rootfs (Ubuntu Bionic):
status: Fix Committed → Fix Released
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package livecd-rootfs - 2.408.55

---------------
livecd-rootfs (2.408.55) xenial; urgency=medium

  * magic-proxy: dump proxy log to stdout on failure (LP: #1847300)

 -- Robert C Jennings <email address hidden> Tue, 08 Oct 2019 11:02:08 -0500

Changed in livecd-rootfs (Ubuntu Xenial):
status: Fix Committed → Fix Released
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package livecd-rootfs - 2.578.9

---------------
livecd-rootfs (2.578.9) disco; urgency=medium

  * magic-proxy: dump proxy log to stdout on failure (LP: #1847300)

 -- Robert C Jennings <email address hidden> Tue, 08 Oct 2019 10:57:31 -0500

Changed in livecd-rootfs (Ubuntu Disco):
status: Fix Committed → Fix Released
tags: added: id-5d9deacf00e6912c2f5878f7
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers