| 2019-07-15 14:05:53 |
Iain Lane |
bug |
|
|
added bug |
| 2019-07-15 14:11:19 |
Sebastien Bacher |
tags |
|
rls-ee-incoming |
|
| 2019-07-15 16:54:57 |
Will Cooke |
bug |
|
|
added subscriber Will Cooke |
| 2019-07-15 20:43:11 |
Launchpad Janitor |
livecd-rootfs (Ubuntu): status |
New |
Fix Released |
|
| 2019-07-16 09:19:08 |
Iain Lane |
description |
eoan:
livecd-rootfs | 2.599
bionic:
livecd-rootfs | 2.525.27
Images currently being built have non-functional snaps. Seeding never finishes, and the journal contains:
Jul 15 13:52:16 ubuntu snapd[944]: stateengine.go:102: state ensure error: devicemgr: cannot proceed without seeding "core"
seed.yaml doesn't contain core:
ubuntu@ubuntu:~$ cat /var/lib/snapd/seed/seed.yaml
snaps:
-
name: core18
channel: stable
file: core18_1055.snap
-
name: snapd
channel: stable
file: snapd_3646.snap
-
name: gnome-3-28-1804
channel: stable/ubuntu-19.10
file: gnome-3-28-1804_67.snap
-
name: gnome-calculator
channel: stable/ubuntu-19.10
file: gnome-calculator_406.snap
-
name: gnome-characters
channel: stable/ubuntu-19.10
file: gnome-characters_296.snap
-
name: gnome-logs
channel: stable/ubuntu-19.10
file: gnome-logs_61.snap
-
name: gnome-system-monitor
channel: stable/ubuntu-19.10
file: gnome-system-monitor_100.snap
-
name: gtk-common-themes
channel: stable/ubuntu-19.10
file: gtk-common-themes_1313.snap
I think it is due to this change in livecd-rootfs:
laney@raleigh (ubuntu/master↑3|✔)> git show 05e71b38409b5a7cef41ebc864223466292268bb -- live-build/functions ~/dev/canonical/release/livecd-rootfs
commit 05e71b38409b5a7cef41ebc864223466292268bb
Author: Tobias Koch <tobias.koch@canonical.com>
Date: Thu Apr 11 17:46:00 2019 +0200
Do not include any snaps in ubuntu-cpc:minimized builds
diff --git a/live-build/functions b/live-build/functions
index c0dfcdca..6cc87d91 100644
--- a/live-build/functions
+++ b/live-build/functions
@@ -436,6 +436,17 @@ _snap_preseed() {
return
fi
+ # Determine if and what core snap is needed
+ local core_snap=$(/usr/share/livecd-rootfs/snap-tool info \
+ --cohort-key="${COHORT_KEY:-}" \
+ --channel="$CHANNEL" "$SNAP_NAME" | \
+ grep '^base:' | awk '{print $2}'
+ )
+
+ if [ -n "$core_snap" ]; then
+ _snap_preseed $CHROOT_ROOT $core_snap stable
+ fi
+
sh -c "
set -x;
cd \"$CHROOT_ROOT/var/lib/snapd/seed\";
@@ -544,9 +555,6 @@ snap_prepare() {
local CUSTOM_BRAND_MODEL=${2:-generic:generic-classic}
snap_prepare_assertions "$CHROOT_ROOT" "$CUSTOM_BRAND_MODEL"
-
- # Download the core snap
- _snap_preseed $CHROOT_ROOT core stable
}
snap_preseed() {
Which stopped unconditionally seeding core. But this can't be the whole story, since disco was built with that livecd-rootfs and it *does* have core. |
[ Description ]
eoan:
livecd-rootfs | 2.599
bionic:
livecd-rootfs | 2.525.27
Images currently being built have non-functional snaps. Seeding never finishes, and the journal contains:
Jul 15 13:52:16 ubuntu snapd[944]: stateengine.go:102: state ensure error: devicemgr: cannot proceed without seeding "core"
[ Fix ]
Explicitly seed 'core', since snapd still requires it currently.
[ QA ]
Boot a desktop ISO to the live session. Snap seeding is slow, so wait a couple of minutes. Check that the seeded snaps (e.g. gnome-calculator) are available in the Shell.
[ Regression potential ]
Image builds could start failing. They'll now have core where they didn't before, so that is a size increase.
[ Original report (rest of) ]
seed.yaml doesn't contain core:
ubuntu@ubuntu:~$ cat /var/lib/snapd/seed/seed.yaml
snaps:
-
name: core18
channel: stable
file: core18_1055.snap
-
name: snapd
channel: stable
file: snapd_3646.snap
-
name: gnome-3-28-1804
channel: stable/ubuntu-19.10
file: gnome-3-28-1804_67.snap
-
name: gnome-calculator
channel: stable/ubuntu-19.10
file: gnome-calculator_406.snap
-
name: gnome-characters
channel: stable/ubuntu-19.10
file: gnome-characters_296.snap
-
name: gnome-logs
channel: stable/ubuntu-19.10
file: gnome-logs_61.snap
-
name: gnome-system-monitor
channel: stable/ubuntu-19.10
file: gnome-system-monitor_100.snap
-
name: gtk-common-themes
channel: stable/ubuntu-19.10
file: gtk-common-themes_1313.snap
I think it is due to this change in livecd-rootfs:
laney@raleigh (ubuntu/master↑3|✔)> git show 05e71b38409b5a7cef41ebc864223466292268bb -- live-build/functions ~/dev/canonical/release/livecd-rootfs
commit 05e71b38409b5a7cef41ebc864223466292268bb
Author: Tobias Koch <tobias.koch@canonical.com>
Date: Thu Apr 11 17:46:00 2019 +0200
Do not include any snaps in ubuntu-cpc:minimized builds
diff --git a/live-build/functions b/live-build/functions
index c0dfcdca..6cc87d91 100644
--- a/live-build/functions
+++ b/live-build/functions
@@ -436,6 +436,17 @@ _snap_preseed() {
return
fi
+ # Determine if and what core snap is needed
+ local core_snap=$(/usr/share/livecd-rootfs/snap-tool info \
+ --cohort-key="${COHORT_KEY:-}" \
+ --channel="$CHANNEL" "$SNAP_NAME" | \
+ grep '^base:' | awk '{print $2}'
+ )
+
+ if [ -n "$core_snap" ]; then
+ _snap_preseed $CHROOT_ROOT $core_snap stable
+ fi
+
sh -c "
set -x;
cd \"$CHROOT_ROOT/var/lib/snapd/seed\";
@@ -544,9 +555,6 @@ snap_prepare() {
local CUSTOM_BRAND_MODEL=${2:-generic:generic-classic}
snap_prepare_assertions "$CHROOT_ROOT" "$CUSTOM_BRAND_MODEL"
-
- # Download the core snap
- _snap_preseed $CHROOT_ROOT core stable
}
snap_preseed() {
Which stopped unconditionally seeding core. But this can't be the whole story, since disco was built with that livecd-rootfs and it *does* have core. |
|
| 2019-07-16 09:19:13 |
Iain Lane |
nominated for series |
|
Ubuntu Bionic |
|
| 2019-07-16 09:19:13 |
Iain Lane |
bug task added |
|
livecd-rootfs (Ubuntu Bionic) |
|
| 2019-07-16 09:19:17 |
Iain Lane |
livecd-rootfs (Ubuntu Bionic): status |
New |
In Progress |
|
| 2019-07-16 09:19:20 |
Iain Lane |
livecd-rootfs (Ubuntu Bionic): assignee |
|
Iain Lane (laney) |
|
| 2019-07-16 14:35:41 |
Iain Lane |
nominated for series |
|
Ubuntu Disco |
|
| 2019-07-16 14:35:41 |
Iain Lane |
bug task added |
|
livecd-rootfs (Ubuntu Disco) |
|
| 2019-07-16 15:33:12 |
Andy Whitcroft |
livecd-rootfs (Ubuntu Bionic): status |
In Progress |
Fix Committed |
|
| 2019-07-16 15:33:14 |
Andy Whitcroft |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2019-07-16 15:33:15 |
Andy Whitcroft |
bug |
|
|
added subscriber SRU Verification |
| 2019-07-16 15:33:18 |
Andy Whitcroft |
tags |
rls-ee-incoming |
rls-ee-incoming verification-needed verification-needed-bionic |
|
| 2019-07-16 15:33:59 |
Andy Whitcroft |
livecd-rootfs (Ubuntu Disco): status |
New |
Fix Committed |
|
| 2019-07-16 15:34:02 |
Andy Whitcroft |
tags |
rls-ee-incoming verification-needed verification-needed-bionic |
rls-ee-incoming verification-needed verification-needed-bionic verification-needed-disco |
|
| 2019-07-16 17:59:47 |
Iain Lane |
tags |
rls-ee-incoming verification-needed verification-needed-bionic verification-needed-disco |
rls-ee-incoming verification-done-bionic verification-needed verification-needed-disco |
|
| 2019-07-25 19:43:08 |
Launchpad Janitor |
livecd-rootfs (Ubuntu Bionic): status |
Fix Committed |
Fix Released |
|
| 2019-07-25 19:43:19 |
Adam Conrad |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
| 2019-09-14 19:30:14 |
Iain Lane |
tags |
rls-ee-incoming verification-done-bionic verification-needed verification-needed-disco |
rls-ee-incoming verification-done verification-done-bionic verification-done-disco |
|
| 2019-09-16 07:33:29 |
Launchpad Janitor |
livecd-rootfs (Ubuntu Disco): status |
Fix Committed |
Fix Released |
|
