magic-proxy does not send along headers for errors

Bug #1829944 reported by Robert C Jennings on 2019-05-22
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
livecd-rootfs (Ubuntu)
Undecided
Unassigned
Disco
Undecided
Unassigned

Bug Description

[Impact]

When there is an error with the apt proxy the headers are not returned which makes debugging hard.

[Test Case]

This was tested on xenial when the release lacked the InRelease file by-hash.

This can be verified manually as follows:

* Start the proxy via

./magic-proxy -t `python -c "import time; print(int(time.time() - 300))"`

* In an empty directory do

mkdir -p ubuntu/dists/xenial/by-hash/SHA256
touch ubuntu/dists/xenial/InRelease
python3 -m http.server

* In a separate terminal telnet to port 8080 and paste

GET /ubuntu/dists/xenial/InRelease HTTP/1.1
HOST: localhost:8000

followed by an empty line. Without the patch, the response will be the string "No InRelease file found for given mirror, suite and timestamp".

With the patch applied, the response will start with a HTTP status line "HTTP/1.0 404 Not Found" and a set of HTTP headers.

[Regression Potential]

Low. This was tested on xenial when the release lacked the InRelease file by-hash. Also, this code is not yet in use.

Robert C Jennings (rcj) on 2019-05-22
description: updated
Tobias Koch (tobijk) on 2019-05-22
description: updated
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package livecd-rootfs - 2.586

---------------
livecd-rootfs (2.586) eoan; urgency=medium

  [ Robert C Jennings ]
  * magic-proxy: Send headers on error (LP: #1829944)

 -- Michael Hudson-Doyle <email address hidden> Thu, 23 May 2019 12:33:21 +1200

Changed in livecd-rootfs (Ubuntu):
status: New → Fix Released

Hello Robert, or anyone else affected,

Accepted livecd-rootfs into disco-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/livecd-rootfs/2.578.4 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-disco to verification-done-disco. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-disco. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in livecd-rootfs (Ubuntu Disco):
status: New → Fix Committed
tags: added: verification-needed verification-needed-disco
Robert C Jennings (rcj) wrote :

Testing from disco-proposed completed.

Before:
GET /ubuntu/dists/xenial/InRelease HTTP/1.1
HOST: localhost:8000

127.0.0.1 - - [23/May/2019 21:42:00] "GET /ubuntu/dists/xenial/by-hash/SHA256 HTTP/1.1" 301 -
127.0.0.1 - - [23/May/2019 21:42:00] "GET /ubuntu/dists/xenial/by-hash/SHA256/ HTTP/1.1" 200 -
127.0.0.1 - - [23/May/2019 21:42:00] "GET /ubuntu/dists/xenial/InRelease HTTP/1.1" 404 -
No InRelease file found for given mirror, suite and timestamp.Connection closed by foreign host.

After:

GET /ubuntu/dists/xenial/InRelease HTTP/1.1
HOST: localhost:8000

127.0.0.1 - - [23/May/2019 21:40:27] "GET /ubuntu/dists/xenial/by-hash/SHA256 HTTP/1.1" 301 -
127.0.0.1 - - [23/May/2019 21:40:27] "GET /ubuntu/dists/xenial/by-hash/SHA256/ HTTP/1.1" 200 -
127.0.0.1 - - [23/May/2019 21:40:27] "GET /ubuntu/dists/xenial/InRelease HTTP/1.1" 404 -
HTTP/1.0 404 Not Found
Server: BaseHTTP/0.6 Python/3.7.3
Date: Thu, 23 May 2019 21:40:27 GMT
Content-Type: text/plain; charset=utf-8

No InRelease file found for given mirror, suite and timestamp.Connection closed by foreign host.

tags: added: verification-done verification-done-disco
removed: verification-needed verification-needed-disco
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package livecd-rootfs - 2.578.4

---------------
livecd-rootfs (2.578.4) disco; urgency=medium

  [ Robert C Jennings ]
  * magic-proxy: Send headers on error (LP: #1829944)

livecd-rootfs (2.578.3) disco; urgency=medium

  [ Robert C Jennings ]
  * ubuntu-cpc: Ensure base disk image is the same between all build targets
    (LP: #1827426)

 -- Steve Langasek <email address hidden> Thu, 23 May 2019 13:33:40 -0700

Changed in livecd-rootfs (Ubuntu Disco):
status: Fix Committed → Fix Released

The verification of the Stable Release Update for livecd-rootfs has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers