ubuntu-cpc: parallel build targets produce different root FS output

[Robert C Jennings]

[Impact]

The following targets have livecd.ubuntu-cpc.manifest (and
livecd.ubuntu-cpc.ext4) which differ in some way from the 'all'
target. They are all missing grub-efi and other modifications:

root-dir
squashfs
tarball

These targets do not depend on the 'disk-image' target. This means that
the ext4 produced will lack the uefi modifications (and any from the
disk-image target binary hooks).

Since the ext4 file is common to all builds there is a chance that a
parallel build from one of these targets could mistakenly be used.

[Test Case]

A build of each of the above mentioned image targets must produce a
root filesystem that is the same as the 'disk-image' or 'all' target.

[Regression Potential]

None. Image targets are not yet in use in production for the ubuntu-cpc project and the changes do not affect builds without specification of an
image target.

[Other Info]

This is blocking backporting of image parallelization to the rest of our
supported releases (and consumption of the feature overall) making it
a high priority for us to see these in place.

[Robert C Jennings (rcj)]

I've proposed https://code.launchpad.net/~rcj/livecd-rootfs/+git/livecd-rootfs/+merge/366862 for this issue for master as well as https://code.launchpad.net/~rcj/livecd-rootfs/+git/livecd-rootfs/+merge/366863 for disco (I'll add an SRU template as well).

[Robert C Jennings (rcj)]

mwhudson has requested that the make-hooks command be amended to allow comments in series files and these series files have comments added to the effect "# Ensure livecd.ubuntu-cpc.ext4 is consistent with other targets"

[Robert C Jennings (rcj)]

I've pushed a commit to each branch to support comments and added them for the changes.

[Steve Langasek (vorlon)]

Hello Robert, or anyone else affected,

Accepted livecd-rootfs into disco-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/livecd-rootfs/2.578.4 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-disco to verification-done-disco. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-disco. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Robert C Jennings (rcj)]

Thanks for pulling this into -proposed. I will mark this as verification done now after validating image builds.

[Launchpad Janitor (janitor)]

This bug was fixed in the package livecd-rootfs - 2.578.4

---------------
livecd-rootfs (2.578.4) disco; urgency=medium

  [ Robert C Jennings ]
  * magic-proxy: Send headers on error (LP: #1829944)

livecd-rootfs (2.578.3) disco; urgency=medium

  [ Robert C Jennings ]
  * ubuntu-cpc: Ensure base disk image is the same between all build targets
    (LP: #1827426)

 -- Steve Langasek <email address hidden> Thu, 23 May 2019 13:33:40 -0700

[Steve Langasek (vorlon)]

The verification of the Stable Release Update for livecd-rootfs has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.