SRU subiquity specific changes from master to bionic

[Dimitri John Ledkov]

[Impact]

 * SRU subiquity image specific changes in livecd-rootfs to fix installer issues.

[Test Case]

  * subiquity: make subiquity_config.mount optional.

    1) boot subiquity image
    2) observe that there are no boot messages mentioning failed to start subiquity_config.mount

  * Make serial-subiquity@ use the same codepath as tty1 subiquity.

    1) boot subiquity image on an architecture with a serial console, e.g. ppc64el KVM, s390x KVM.
    2) observe that the boot goes straight to subiquity, without multiple attempts of failing to start it, crash, try again, crash, snaps get seeded, success.

  * Fix ubuntu-server-live images to generate initrd with casper UUID.

    1) mount iso
    2) check that it contains uuid file
    cat /mnt/.disk/casper-uuid-generic
    3) unpack initrd
    unmkinitramfs /mnt/casper/initrd /tmp/tmp.AGwIMQfj0j
    4) check that it also contains uuid:
    cat /tmp/tmp.AGwIMQfj0j/main/conf/uuid.conf
    5) check that uuid form #2 and #4 are the same

[Regression Potential]

 * This is a livecd-rootfs upload that may impact building images. The code touched here affects ubuntu-server-live images only. This SRU should be reviewed and accepted, server-live images spun and checked as per the above testcases.

[Other Info]

 * All changes are cherrypicks from disco/eoan.

[Brian Murray (brian-murray)]

Hello Dimitri, or anyone else affected,

Accepted livecd-rootfs into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/livecd-rootfs/2.525.23 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Dimitri John Ledkov (xnox)]

# mount ./bionic-live-server-amd64.iso /mnt/
# cat /mnt/.disk/casper-uuid-generic
ed387af7-7c8f-4d98-8bca-4f8fbcabb0c8
# cat /mnt/.disk/casper-uuid-generic-hwe
6e6d655c-f35b-4361-9b5d-13bea0bbfb1b
# cd $(mktemp -d)
# unmkinitramfs /mnt/casper/initrd .
# cat main/conf/uuid.conf
ed387af7-7c8f-4d98-8bca-4f8fbcabb0c8
# unmkinitramfs /mnt/casper/hwe-initrd .
# cat main/conf/uuid.conf
6e6d655c-f35b-4361-9b5d-13bea0bbfb1b

UUID test case is good.

[Dimitri John Ledkov (xnox)]

booting with a black screen with the first line of text that appears is the getty tty1 message.

Which is great, meaning that subiquity_config.mount has not failed, and didn't cause the boot to be "degraded"

[Dimitri John Ledkov (xnox)]

Above two things are tested with:
Ubuntu-Server 18.04.2 LTS "Bionic Beaver" - Beta amd64 (20190509)

which is built with livecd-rootfs 2.525.23

The serial console stuff, needs to be tested on some other arch, as I'm failing to create serial only amd64 VM =)

[Dimitri John Ledkov (xnox)]

Tested
Ubuntu-Server 18.04.2 LTS "Bionic Beaver" - Beta ppc64el (20190510)

As ubuntu-cdimage changes are not backported yet, had to manually type grub configs to get it to boot.
But after that hvc0 serial subiquity did start, and it did block until snaps were seeded without any FAILED serial units on boot, or crash/restart subiquity.

Verification done.

[Launchpad Janitor (janitor)]

This bug was fixed in the package livecd-rootfs - 2.525.23

---------------
livecd-rootfs (2.525.23) bionic; urgency=medium

  * Backport two minimizations for the docker images: remove apt lists that
    are removed downstream anyway, and remove device nodes from the image.
    (LP: #1828118)

livecd-rootfs (2.525.22) bionic; urgency=medium

  * Subiquity specific changes SRU LP: #1827357
    - subiquity: make subiquity_config.mount optional
    - Make serial-subiquity@ use the same codepath as tty1 subiquity.
    - Fix ubuntu-server-live images to generate initrd with casper UUID.

 -- Michael Hudson-Doyle <email address hidden> Wed, 08 May 2019 10:48:39 +1200

[Steve Langasek (vorlon)]

The verification of the Stable Release Update for livecd-rootfs has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.