| 2017-10-31 16:11:01 |
Steve Langasek |
bug |
|
|
added bug |
| 2017-10-31 16:58:18 |
Steve Langasek |
affects |
grub2 (Ubuntu) |
livecd-rootfs (Ubuntu) |
|
| 2017-10-31 16:58:32 |
Launchpad Janitor |
branch linked |
|
lp:livecd-rootfs |
|
| 2017-10-31 16:59:10 |
Steve Langasek |
nominated for series |
|
Ubuntu Xenial |
|
| 2017-10-31 16:59:10 |
Steve Langasek |
bug task added |
|
livecd-rootfs (Ubuntu Xenial) |
|
| 2017-10-31 16:59:18 |
Steve Langasek |
livecd-rootfs (Ubuntu): status |
New |
Fix Committed |
|
| 2017-10-31 17:06:28 |
Launchpad Janitor |
branch linked |
|
lp:~ubuntu-core-dev/livecd-rootfs/xenial-proposed |
|
| 2017-10-31 17:28:13 |
Steve Langasek |
description |
LP: #1060404 was addressed by making the update-grub kernel postinst hook a no-op when running in containers.
We now do all of our livefs builds in containers in Launchpad; this means livefses no longer get a grub config automatically generated with the correct contents when installing a kernel in the target, as they did previously.
The change for LP: #1060404 was described by Colin as a "temporary fix".
We know that update-grub itself now succeeds in containers, because we have several points in livefs builds where we are invoking it directly and it does what we expect.
We should check that running update-grub in a stock lxd container works as expected, and that this isn't due to some sort of launchpad sauce. Provided it does work, we should remove the container check from the kernel postinst hook. |
[SRU Justification]
LP: #1060404 was addressed by making the update-grub kernel postinst hook a no-op when running in containers.
We now do all of our livefs builds in containers in Launchpad; this means livefses no longer get a grub config automatically generated with the correct contents when installing a kernel in the target, as they did previously.
The change for LP: #1060404 was described by Colin as a "temporary fix".
We know that update-grub itself now succeeds in the launchpad buildd containers, because we have several points in livefs builds where we are invoking it directly and it does what we expect. And in any containers where update-grub does not work, these same livefs builds will fail anyway.
[Test case]
Run through a standard set of xenial image builds with livecd-rootfs in launchpad, including the private cloud image builds. Confirm that the builds are successful and that
[Regression potential]
If something else relied on container detection in order to modify its behavior, and is called between the addition and removal of the systemd-detect-virt diversion, it could now behave incorrectly in a container and cause build failures. This is an entirely hypothetical scenario, since all current consumers of (un)divert_grub, and pending users of it, have it very narrowly scoped such that they're only doing update-grub / kernel install operations in between. |
|
| 2017-10-31 23:27:46 |
Chris Halse Rogers |
livecd-rootfs (Ubuntu Xenial): status |
New |
Fix Committed |
|
| 2017-10-31 23:27:48 |
Chris Halse Rogers |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2017-10-31 23:27:51 |
Chris Halse Rogers |
bug |
|
|
added subscriber SRU Verification |
| 2017-10-31 23:27:57 |
Chris Halse Rogers |
tags |
|
verification-needed verification-needed-xenial |
|
| 2017-10-31 23:34:07 |
Steve Langasek |
description |
[SRU Justification]
LP: #1060404 was addressed by making the update-grub kernel postinst hook a no-op when running in containers.
We now do all of our livefs builds in containers in Launchpad; this means livefses no longer get a grub config automatically generated with the correct contents when installing a kernel in the target, as they did previously.
The change for LP: #1060404 was described by Colin as a "temporary fix".
We know that update-grub itself now succeeds in the launchpad buildd containers, because we have several points in livefs builds where we are invoking it directly and it does what we expect. And in any containers where update-grub does not work, these same livefs builds will fail anyway.
[Test case]
Run through a standard set of xenial image builds with livecd-rootfs in launchpad, including the private cloud image builds. Confirm that the builds are successful and that
[Regression potential]
If something else relied on container detection in order to modify its behavior, and is called between the addition and removal of the systemd-detect-virt diversion, it could now behave incorrectly in a container and cause build failures. This is an entirely hypothetical scenario, since all current consumers of (un)divert_grub, and pending users of it, have it very narrowly scoped such that they're only doing update-grub / kernel install operations in between. |
[SRU Justification]
LP: #1060404 was addressed by making the update-grub kernel postinst hook a no-op when running in containers.
We now do all of our livefs builds in containers in Launchpad; this means livefses no longer get a grub config automatically generated with the correct contents when installing a kernel in the target, as they did previously.
The change for LP: #1060404 was described by Colin as a "temporary fix".
We know that update-grub itself now succeeds in the launchpad buildd containers, because we have several points in livefs builds where we are invoking it directly and it does what we expect. And in any containers where update-grub does not work, these same livefs builds will fail anyway.
[Test case]
Run through a standard set of xenial image builds with livecd-rootfs in launchpad, including the private cloud image builds. Confirm that the builds are successful and that the resulting images list the correct contents in /boot/grub/grub.cfg.
[Regression potential]
If something else relied on container detection in order to modify its behavior, and is called between the addition and removal of the systemd-detect-virt diversion, it could now behave incorrectly in a container and cause build failures. This is an entirely hypothetical scenario, since all current consumers of (un)divert_grub, and pending users of it, have it very narrowly scoped such that they're only doing update-grub / kernel install operations in between. |
|
| 2017-10-31 23:39:52 |
Launchpad Janitor |
livecd-rootfs (Ubuntu): status |
Fix Committed |
Fix Released |
|
| 2017-11-04 06:44:05 |
Steve Langasek |
tags |
verification-needed verification-needed-xenial |
verification-done-xenial |
|
| 2017-11-09 12:07:13 |
Launchpad Janitor |
livecd-rootfs (Ubuntu Xenial): status |
Fix Committed |
Fix Released |
|
| 2017-11-09 12:07:17 |
Andy Whitcroft |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
