lirc-modules-source doesn't compile with 2.6.26

Bug #247233 reported by Plantagenet
4
Affects Status Importance Assigned to Milestone
lirc (Ubuntu)
Fix Released
Undecided
Mario Limonciello

Bug Description

Binary package hint: lirc

kernel 2.6.26 has deprecated class_device_create and class_device_destroy. lirc-modules-souce is based on lirc 0.8.3 and doesn't compile on 2.6.26 (the kernel on Intrepid). The CVS sources for lirc accomodate 2.6.26 by changing class_device_create to device_create. lirc-modules-source should be updated with newer lirc source.

Description: Ubuntu intrepid (development branch)
Release: 8.10

lirc:
  Installed: 0.8.3-0ubuntu1
  Candidate: 0.8.3-0ubuntu1
  Version table:
 *** 0.8.3-0ubuntu1 0
        500 http://us.archive.ubuntu.com intrepid/universe Packages
        100 /var/lib/dpkg/status

ProblemType: Bug
Architecture: amd64
Date: Thu Jul 10 06:41:31 2008
DistroRelease: Ubuntu 8.10
Package: lirc 0.8.3-0ubuntu1
PackageArchitecture: amd64
ProcEnviron:
 SHELL=/bin/bash
 PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games
 LANG=en_US.UTF-8
SourcePackage: lirc
Uname: Linux 2.6.26-3-generic x86_64

Tags: apport-bug
Revision history for this message
Plantagenet (morrison-bnl) wrote :
Revision history for this message
Mario Limonciello (superm1) wrote : Re: [Bug 247233] [NEW] lirc-modules-source doesn't compile with 2.6.26

As far as you know, it has just been depracated, but not actually removed right?

On 07/10/2008, Plantagenet <email address hidden> wrote:
> Public bug reported:
>
> Binary package hint: lirc
>
> kernel 2.6.26 has deprecated class_device_create and
> class_device_destroy. lirc-modules-souce is based on lirc 0.8.3 and
> doesn't compile on 2.6.26 (the kernel on Intrepid). The CVS sources for
> lirc accomodate 2.6.26 by changing class_device_create to device_create.
> lirc-modules-source should be updated with newer lirc source.
>
> Description: Ubuntu intrepid (development branch)
> Release: 8.10
>
> lirc:
> Installed: 0.8.3-0ubuntu1
> Candidate: 0.8.3-0ubuntu1
> Version table:
> *** 0.8.3-0ubuntu1 0
> 500 http://us.archive.ubuntu.com intrepid/universe Packages
> 100 /var/lib/dpkg/status
>
> ProblemType: Bug
> Architecture: amd64
> Date: Thu Jul 10 06:41:31 2008
> DistroRelease: Ubuntu 8.10
> Package: lirc 0.8.3-0ubuntu1
> PackageArchitecture: amd64
> ProcEnviron:
> SHELL=/bin/bash
> PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games
> LANG=en_US.UTF-8
> SourcePackage: lirc
> Uname: Linux 2.6.26-3-generic x86_64
>
> ** Affects: lirc (Ubuntu)
> Importance: Undecided
> Status: New
>
>
> ** Tags: apport-bug
>
> --
> lirc-modules-source doesn't compile with 2.6.26
> https://bugs.launchpad.net/bugs/247233
> You received this bug notification because you are a member of MythTV
> Ubuntu Maintainers, which is subscribed to lirc in ubuntu.
>

--
Sent from Gmail for mobile | mobile.google.com

Mario Limonciello
<email address hidden>

Revision history for this message
Domino (dave-bnl) wrote :

No, it's gone. It's there in the 2.6.24 headers:

# egrep -RHn class_device_create
/usr/src/linux-headers-2.6.24-18-generic/include/linux
/usr/src/linux-headers-2.6.24-18-generic/include/linux/device.h:227:extern
int __must_check class_device_create_file(struct class_device *,
/usr/src/linux-headers-2.6.24-18-generic/include/linux/device.h:294:extern
int __must_check class_device_create_bin_file(struct class_device *,
/usr/src/linux-headers-2.6.24-18-generic/include/linux/device.h:314:extern
struct class_device *class_device_create(struct class *cls,
#

and not there in the 2.6.26 headers

# egrep -RHn class_device_create
/usr/src/linux-headers-2.6.26-3-generic/include/linux
#

It was removed in this commit on 12 March 2008:

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=c3b19ff06e0808555403491d61e8f0cbbb53e933

Dave

Mario Limonciello wrote:
> As far as you know, it has just been depracated, but not actually
> removed right?
>
>
> On 07/10/2008, Plantagenet <email address hidden> wrote:
>> Public bug reported:
>>
>> Binary package hint: lirc
>>
>> kernel 2.6.26 has deprecated class_device_create and
>> class_device_destroy. lirc-modules-souce is based on lirc 0.8.3 and
>> doesn't compile on 2.6.26 (the kernel on Intrepid). The CVS sources for
>> lirc accomodate 2.6.26 by changing class_device_create to device_create.
>> lirc-modules-source should be updated with newer lirc source.
>>
>> Description: Ubuntu intrepid (development branch)
>> Release: 8.10
>>
>> lirc:
>> Installed: 0.8.3-0ubuntu1
>> Candidate: 0.8.3-0ubuntu1
>> Version table:
>> *** 0.8.3-0ubuntu1 0
>> 500 http://us.archive.ubuntu.com intrepid/universe Packages
>> 100 /var/lib/dpkg/status
>>
>> ProblemType: Bug
>> Architecture: amd64
>> Date: Thu Jul 10 06:41:31 2008
>> DistroRelease: Ubuntu 8.10
>> Package: lirc 0.8.3-0ubuntu1
>> PackageArchitecture: amd64
>> ProcEnviron:
>> SHELL=/bin/bash
>> PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games
>> LANG=en_US.UTF-8
>> SourcePackage: lirc
>> Uname: Linux 2.6.26-3-generic x86_64
>>
>> ** Affects: lirc (Ubuntu)
>> Importance: Undecided
>> Status: New
>>
>>
>> ** Tags: apport-bug
>>
>> --
>> lirc-modules-source doesn't compile with 2.6.26
>> https://bugs.launchpad.net/bugs/247233
>> You received this bug notification because you are a member of MythTV
>> Ubuntu Maintainers, which is subscribed to lirc in ubuntu.
>>
  >

Revision history for this message
Mario Limonciello (superm1) wrote :

This has been fixed in the intrepid kernel package. I'll pull in that update for the lirc package too.

Revision history for this message
Mario Limonciello (superm1) wrote :

Fixed in bzr revno 20

Changed in lirc:
assignee: nobody → superm1
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package lirc - 0.8.3-0ubuntu2

---------------
lirc (0.8.3-0ubuntu2) intrepid; urgency=low

  * debian/patches/25_upstream_2.6.26.patch:
    - Fix lirc-modules-source compilation on 2.6.26 by pulling some
      patches from CVS (LP: #247233)
  * debian/rules:
    - Install original modules back into proper location for
      intrepid kernel (LP: #242216)
  * debian/patches/37_msi_tv_anywhere.dpatch:
    - Create patch for supporting MSI TV @anywhere remote. (LP: #241830)
  * debian/lirc.postinst:
    - Correct path to look for module in Intrepid.
    - Ask for a path when using dvico remotes. (LP: #238032)
    - Don't accidentally overwrite lircd.conf and hardware.conf
      when things haven't really changed at all. (LP: #206609)
  * debian/lirc.init.d:
    - Don't allow udev to put us into endless spinning loops. Instead
      pray that module hotplugging worked for all things USB. (LP: #269743)
  * debian/lirc.fdi:
    - Include this FDI file to prevent in kernel support for the
      saa7134 when LIRC is installed. (LP: #204960, #164627)
  * debian/rules:
    - Install FDI file.
  * debian/lirc.install:
    - List FDI file.
  * debian/patches/22_hauppauge_novat_500.dpatch:
    - Adapt to include alternative numeric keys. (LP: #224080)
  * debian/patches/25_upstream_2.6.27.dpatch:
    - Update to content that is currently sitting in Ubuntu GIT
      tree.

 -- Mario Limonciello <email address hidden> Wed, 24 Sep 2008 12:02:17 -0500

Changed in lirc:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.