Would be cool if the Ubuntu logo would be shown by default instead of the Debian logo

[Axel Beckert]

On Ubuntu Precise, linuxlogo (5.11-1) shows by default the Debian logo (linuxlogo -L debian), but there's also an Ubuntu logo included (linuxlogo -L ubuntu).

It should suffice to change "-L debian" in /etc/linux_logo.conf to "-L ubuntu".

[Dariusz Dwornikowski (dariusz-dwornikowski)]

The package is copied from Debian, so we do not intend to change it. Ubuntu can repackage to include these changes. I think this is not a bug but a wishlist.

[Axel Beckert (xtaran)]

Hi Dariusz,

I don't seem to be the only one of this opinion, see https://bugs.launchpad.net/ubuntu/+source/linuxlogo/+bug/1364624

You seem to have taken over the maintenance of the Debian package of linuxlogo, so you could make the default depending on the distro the package is built for at build time.

/etc/linux_logo.conf doesn't seem to be able to handle shell style meta characters. Otherwise using

-L `dpkg-vendor --is ubuntu && echo ubuntu || dpkg-vendor --is raspbian && echo raspi || echo debian_banner_2`

might have been the solution to it.

[Axel Beckert (xtaran)]

Hi Dariusz,

Axel Beckert wrote:
> You seem to have taken over the maintenance of the Debian package of
> linuxlogo, so you could make the default depending on the distro the
> package is built for at build time.

The attached patch should implement that behaviour for Ubuntu and
Raspbian.

If you don't mind, I'll push that patch directly to the collab-maint
repo on Alioth.

  Regards, Axel
--
 ,''`. | Axel Beckert <email address hidden>, http://people.debian.org/~abe/
: :' : | Debian Developer, ftp.ch.debian.org Admin
`. `' | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5
  `- | 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE

[Axel Beckert (xtaran)]

Hi Dariusz,

I've pushed packaging updates to Debian's linuxlogo package which fix
all outstanding bug reports on Debian (#791929, #819926) and Ubuntu
(LP#1088889, LP#1364624) plus fix some obvious and noncontentious
issues (typos inside the debian directory :-) reported by lintian to
the branch abe/proposed on collab-maint:

https://anonscm.debian.org/git/collab-maint/linuxlogo.git/log/?h=abe/proposed

Feel free to fast-forward merge it into the master branch and upload
it.

I though can also do this as non-maintainer upload in case you're busy
at the moment. (I can fix also further lintian warnings if I should do
the upload and you're ok with fixing those warnings -- as they're
usually out-of-scope for an NMU unless permitted by the package
maintainer.)

  Regards, Axel
--
 ,''`. | Axel Beckert <email address hidden>, http://people.debian.org/~abe/
: :' : | Debian Developer, ftp.ch.debian.org Admin
`. `' | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5
  `- | 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE

[Dariusz Dwornikowski (dariusz-dwornikowski)]

On 26.04.16 01:07:07, Axel Beckert wrote:
> Hi Dariusz,
>
> I've pushed packaging updates to Debian's linuxlogo package which fix
> all outstanding bug reports on Debian (#791929, #819926) and Ubuntu
> (LP#1088889, LP#1364624) plus fix some obvious and noncontentious
> issues (typos inside the debian directory :-) reported by lintian to
> the branch abe/proposed on collab-maint:
>
> https://anonscm.debian.org/git/collab-maint/linuxlogo.git/log/?h=abe/proposed
>
> Feel free to fast-forward merge it into the master branch and upload
> it.
>
> I though can also do this as non-maintainer upload in case you're busy
> at the moment. (I can fix also further lintian warnings if I should do
> the upload and you're ok with fixing those warnings -- as they're
> usually out-of-scope for an NMU unless permitted by the package
> maintainer.)

Hey Axel, feel free to create an NMU. I am quite busy atm. You can fix
all the outstanding lintian warnings. Thank you for your contribution
to linuxlogo.

--
Dariusz Dwornikowski,
  Institute of Computing Science, Poznań University of Technology
  www.cs.put.poznan.pl/ddwornikowski/
  room 1.6.2 BTiCW | tel. [phone]

[Axel Beckert (xtaran)]

Hi Dariusz,

Dariusz Dwornikowski wrote:
> Hey Axel, feel free to create an NMU.

Will do later today.

> You can fix all the outstanding lintian warnings.

Pushed already most of it to the git repository on Alioth and
(fast-forward) merged my branch into the master branch.

The only ones currently left are debian-watch-may-check-gpg-signature
(upstream doesn't seem to sign the tar balls) and hardening-no-pie
(FTBFS if I enable PIE).

> Thank you for your contribution to linuxlogo.

You're welcome. Thanks for maintaining the package for Debian.

  Regards, Axel
--
 ,''`. | Axel Beckert <email address hidden>, http://people.debian.org/~abe/
: :' : | Debian Developer, ftp.ch.debian.org Admin
`. `' | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5
  `- | 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE

[Launchpad Janitor (janitor)]

This bug was fixed in the package linuxlogo - 5.11-8.1

---------------
linuxlogo (5.11-8.1) unstable; urgency=medium

  * Non-maintainer upload with maintainer's permission.
  * Choose vendor-based default logo at build time:
    + On Ubuntu and derivatives, it shows the "ubuntu" logo.
    + On Raspbian and derivatives, it shows the "raspi" logo.
    + Else it shows the same Debian logo as before ("debian_banner_2").
    + Fixes LP: #1088889 and LP: #1364624.
  * Properly escape "\" in logos when being fed to getty (Closes: #819926)
  * Add patch to support arm64 aka aarch64 (Closes: #791929)
  * Fix spelling errors found by lintian in README.Debian and man page.
  * Enable bindnow hardening flags.
  * Switch Vcs-* headers to https:// and cgit.
  * Declare compliance with Debian Policy 3.9.8. (No changes needed.)
  * Make nearly-DEP5-compliant debian/copyright DEP5-compliant.
  * Update packaging copyright in debian/copyright.
  * Fix build log scanner warnings by properly passing $CFLAGS and
    $CPPFLAGS through libsysinfo-0.2.2/configure.

 -- Axel Beckert <email address hidden> Tue, 26 Apr 2016 23:38:33 +0200