Suspend on Thinkpad X200s worked in 2.6.35-24-generic but no longer in 2.6.35-25-generic

[Nick Moffitt]

I believe this is the first serious suspend problem I have had with my X200s in the year and a half since I bought it. When I upgraded to 2.6.35-25-generic I found suspend would abort with these messages in kern.log:

Jan 19 19:54:49 vezza kernel: [33418.201021] sd 0:0:0:0: [sda] Synchronizing SCSI cache
Jan 19 19:54:49 vezza kernel: [33418.201180] sd 0:0:0:0: [sda] Stopping disk
Jan 19 19:54:49 vezza kernel: [33418.230127] tpm_tis 00:0a: tpm_transmit: tpm_send: error -5
Jan 19 19:54:49 vezza kernel: [33418.230135] legacy_suspend(): pnp_bus_suspend+0x0/0x90 returns -5
Jan 19 19:54:49 vezza kernel: [33418.230140] PM: Device 00:0a failed to suspend: error -5
Jan 19 19:54:49 vezza kernel: [33418.530367] PM: suspend of drv:sd dev:0:0:0:0 complete after 329.348 msecs
Jan 19 19:54:49 vezza kernel: [33418.530400] PM: suspend of drv:scsi dev:target0:0:0 complete after 329.340 msecs
Jan 19 19:54:49 vezza kernel: [33418.530412] PM: suspend of drv:scsi dev:host0 complete after 329.276 msecs
Jan 19 19:54:49 vezza kernel: [33418.530432] PM: Some devices failed to suspend
Jan 19 19:54:49 vezza kernel: [33418.530773] sd 0:0:0:0: [sda] Starting disk

The system flashes the quarter-moon indicator a few times, but shortly returns to a woken state with the screen locked. A few key lines of the above paste appear on console during the process, which is partly why I chose this excerpt. More complete logs are available upon request.

ProblemType: Bug
DistroRelease: Ubuntu 10.10
Package: linux-image-2.6.35-25-generic 2.6.35-25.43
Regression: Yes
Reproducible: Yes
ProcVersionSignature: Ubuntu 2.6.35-24.42-generic 2.6.35.8
Uname: Linux 2.6.35-24-generic x86_64
AlsaVersion: Advanced Linux Sound Architecture Driver Version 1.0.23.
Architecture: amd64
ArecordDevices:
 **** List of CAPTURE Hardware Devices ****
 card 0: Intel [HDA Intel], device 0: CONEXANT Analog [CONEXANT Analog]
   Subdevices: 1/1
   Subdevice #0: subdevice #0
AudioDevicesInUse:
 USER PID ACCESS COMMAND
 /dev/snd/controlC0: nick 2424 F.... pulseaudio
CRDA: Error: [Errno 2] No such file or directory
Card0.Amixer.info:
 Card hw:0 'Intel'/'HDA Intel at 0xf2620000 irq 47'
   Mixer name : 'Conexant CX20561 (Hermosa)'
   Components : 'HDA:14f15051,17aa20ff,00100000'
   Controls : 14
   Simple ctrls : 7
Card29.Amixer.info:
 Card hw:29 'ThinkPadEC'/'ThinkPad Console Audio Control at EC reg 0x30, fw 7XHT22WW-1.04'
   Mixer name : 'ThinkPad EC 7XHT22WW-1.04'
   Components : ''
   Controls : 1
   Simple ctrls : 1
Card29.Amixer.values:
 Simple mixer control 'Console',0
   Capabilities: pswitch pswitch-joined penum
   Playback channels: Mono
   Mono: Playback [on]
Date: Fri Jan 21 11:45:39 2011
EcryptfsInUse: Yes
HibernationDevice: RESUME=UUID=093be503-d248-45fa-a7fe-77cdd35c0f5a
MachineType: LENOVO 7465CTO
ProcCmdLine: root=UUID=5237fceb-23d0-412d-84d9-b8f8b3bf28af ro quiet splash
ProcEnviron:
 LC_COLLATE=C
 PATH=(custom, user)
 LANG=en_US.UTF-8
 SHELL=/bin/bash
RelatedPackageVersions: linux-firmware 1.38.3
SourcePackage: linux
WpaSupplicantLog:

dmi.bios.date: 06/25/2009
dmi.bios.vendor: LENOVO
dmi.bios.version: 6DET55WW (3.05 )
dmi.board.name: 7465CTO
dmi.board.vendor: LENOVO
dmi.board.version: Not Available
dmi.chassis.asset.tag: No Asset Information
dmi.chassis.type: 10
dmi.chassis.vendor: LENOVO
dmi.chassis.version: Not Available
dmi.modalias: dmi:bvnLENOVO:bvr6DET55WW(3.05):bd06/25/2009:svnLENOVO:pn7465CTO:pvrThinkPadX200s:rvnLENOVO:rn7465CTO:rvrNotAvailable:cvnLENOVO:ct10:cvrNotAvailable:
dmi.product.name: 7465CTO
dmi.product.version: ThinkPad X200s
dmi.sys.vendor: LENOVO

[Brian Carlson (abutilize)]

This is not limited to the X200. I am also suddenly suffering this regression on my T400

[Nick Moffitt (nick-moffitt)]

Brian, does yours appear to be related to the SCSI suspend of your primary drive, as mine seems to be?

[Nick Moffitt (nick-moffitt)]

As you can see from the apport data, I am happily running 2.6.35-24.42-generic at the moment, with no noticeable problems with any hardware subsystem.

[Paul Collins (pjdc)]

modprobe -r tpm_tis after booting, before the first suspend attempt, seems to work around the problem.

[Brian Carlson (abutilize)]

Nick,
I didn't do too much investigation. I found this page after googleing. Is there some information you would like for me to obtain that would help the Kernel team with their work?

Paul,
The "sudo modprobe -r tpm_tis" worked for me on my Thinkpad T400

[Nick Moffitt (nick-moffitt)]

"sudo modprobe -r tpm_tis" worked for me as well, also on 2.6.35-25.44

[Andy Whitcroft (apw)]

Most peculiar, we had issues with tpm devices needing removing for suspend some time back, but those were supposed to be fixed. I do note that between the two versions you indicate that there are exactly no changes to the tpm stack at all:

    $ git log Ubuntu-2.6.35-24.42..Ubuntu-2.6.35-25.44 ./drivers/char/tpm
    $

Probabally we could do with someone doing a bisect between these two to find out what the heck triggered this.

[Andy Whitcroft (apw)]

Ok this seems to being discussed on LKML. though as far as I can tell it should always have failed and

Looks like there may be a fix for this out there already:

    https://lkml.org/lkml/2010/10/21/456

[Andy Whitcroft (apw)]

[Damnable web interface....]

Ok this seems to being discussed on LKML. though as far as I can tell it should always have failed and not have been affected by this update. Perhaps there is simply a timing component to the failure. Anyhow discussion is under the thread below:

    [REGRESSION] Suspend fails because of TPM modules

Looks like there may be a fix for this out there already:

    https://lkml.org/lkml/2010/10/21/456

Will get some kernels together to confirm.

[Andy Whitcroft (apw)]

Ok it seems we would need the following two commits here:

  commit 3f0d3d016d89a5efb8b926d4707eb21fa13f3d27
  Author: Matthew Garrett <email address hidden>
  Date: Thu Oct 21 17:42:40 2010 -0400

    tpm: Autodetect itpm devices

  commit e5cce6c13c25d9ac56955a3ae2fd562719848172
  Author: Olof Johansson <email address hidden>
  Date: Thu Jan 6 21:24:01 2011 -0600

    tpm: fix panic caused by "tpm: Autodetect itpm devices"

[Andy Whitcroft (apw)]

Ok I have pulled those two fixes into the Maverick kernel and build some kernels for testing. Could those of you affected by this test the kernels below and report back here. Kernels can be found at the URL below:

    http://people.canonical.com/~apw/lp705845-maverick/

Thanks!

[strav (strav)]

Regained the ability to suspend using
linux-image-2.6.35-26-generic_2.6.35-26.45~lp705845v201101271403_i386.deb
On lenovo x200

(didn't tested hibernate though)

Thanks!

[Nick Moffitt (nick-moffitt)]

The problem is now fixed for me with:

 Linux vezza 2.6.35-26-generic #45~lp705845v201101271403 SMP Thu Jan 27 14:17:52 UTC 2011 x86_64 GNU/Linux

[Luka Renko (lure)]

I had the same problem on my X200s:
        Manufacturer: LENOVO
        Product Name: 74705HG
        Version: ThinkPad X200s

The test kernel fixes the problem for me:
   Linux lure 2.6.35-26-generic #45~lp705845v201101271403 SMP Thu Jan 27 14:17:52 UTC 2011 x86_64 GNU/Linux

Before this test kernel, I have used the following workaround:
http://us.generation-nt.com/answer/regression-suspend-fails-because-tpm-modules-help-201235252.html

Also note, that similar problem was fixed in RedHat kernel (with similar auto-detection fix) already in Nov 2010:
https://bugzilla.redhat.com/show_bug.cgi?id=644842

[James Ferguson (jamesf)]

Ditto - another confirmation on X200s, fixed by test kernel 2.6.35-26-generic #45~lp705845v201101271403 SMP Thu Jan 27 14:17:52 UTC 2011 x86_64 GNU/Linux

[Martin Pitt (pitti)]

Accepted linux into lucid-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

[Sergius (stadnik-sergey)]

I confirm that this kernel: http://people.canonical.com/~apw/lp705845-maverick/ fixes the issue on my Thinkpad X301.

[Ante Karamatić (ivoks)]

I confirm that kernel from proposed:

Linux titan 2.6.35-26-generic #46-Ubuntu SMP Sun Jan 30 06:59:07 UTC 2011 x86_64 GNU/Linux

fixes this issue on my ThinkPad x200s.

[Brad Figg (brad-figg)]

The verification must be done using the kernel in -proposed.

[Brad Figg (brad-figg)]

This bug is awaiting verification that the kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed' to 'verification-done'.

If verification is not done by one week from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

[Ante Karamatić (ivoks)]

@Brad I used kernel from proposed. How many confirmations are needed?

[Nick Moffitt (nick-moffitt)]

Well I'm the original reporter of the bug, and I can confirm that it is indeed fixed with the kernel currently in proposed:

Linux vezza 2.6.35-26-generic #46-Ubuntu SMP Sun Jan 30 06:59:07 UTC 2011 x86_64 GNU/Linux

Many thanks for the prompt resolution.

[Bastian Sauert (bastian-sauert)]

I had the same problem with my T500 and can confirm that the kernel currently in proposed solved it.

[Gerv (gerv-launchpad)]

The kernel currently in proposed, "Linux kitten 2.6.35-26-generic #46-Ubuntu SMP Sun Jan 30 08:10:51 UTC 2011 i686 GNU/Linux", fixes the problem for me on an X200.

Thank you :-)

Gerv

[thearthur (arthur-ulfeldt)]

how long do fixes have to sit in proposed? this bug is a real ongoing problem for a lot of people and I cant recommended using proposed as a general solution?

[Martin Pitt (pitti)]

Accepted linux into maverick-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

[Rainer Engel (rainer-engel)]

new kernel in proposed package workes well. Suspend to disk and memory now possible. My hardware Lenovo X200s Ubuntu 10.10 64bit. Good solution :-)

[Launchpad Janitor (janitor)]

This bug was fixed in the package linux - 2.6.35-27.48

---------------
linux (2.6.35-27.48) maverick-proposed; urgency=low

  [ Steve Conklin ]

  * Release Tracking Bug
    - LP: #723335

  [ Upstream Kernel Changes ]

  * thinkpad-acpi: avoid keymap pitfall
    - LP: #722747

linux (2.6.35-27.47) maverick-proposed; urgency=low

  [ Brad Figg ]

  * Release Tracking Bug
    - LP: #716532

  [ Upstream Kernel Changes ]

  * Revert "USB: gadget: Allow function access to device ID data during
    bind()"
    - LP: #714732
  * net: fix rds_iovec page count overflow, CVE-2010-3865
    - LP: #709153
    - CVE-2010-3865
  * Input: fix typo in keycode validation supporting large scancodes
    - LP: #658198
  * net: ax25: fix information leak to userland, CVE-2010-3875
    - LP: #710714
    - CVE-2010-3875
  * net: ax25: fix information leak to userland harder, CVE-2010-3875
    - LP: #710714
    - CVE-2010-3875
  * net: packet: fix information leak to userland, CVE-2010-3876
    - LP: #710714
    - CVE-2010-3876
  * net: tipc: fix information leak to userland, CVE-2010-3877
    - LP: #711291
    - CVE-2010-3877
  * posix-cpu-timers: workaround to suppress the problems with mt exec,
    CVE-2010-4248
    - LP: #712609
    - CVE-2010-4248
  * sys_semctl: fix kernel stack leakage, CVE-2010-4083
    - LP: #712749
    - CVE-2010-4083
  * thinkpad-acpi: lock down size of hotkey keymap
    - LP: #712174
  * thinkpad-acpi: add support for model-specific keymaps
    - LP: #712174
  * thinkpad-acpi: Add KEY_CAMERA (Fn-F6) for Lenovo keyboards
    - LP: #712174
  * x86, hotplug: Use mwait to offline a processor, fix the legacy case
    - LP: #714732
  * fuse: verify ioctl retries
    - LP: #714732
  * fuse: fix ioctl when server is 32bit
    - LP: #714732
  * ALSA: hda: Use position_fix=1 for Acer Aspire 5538 to enable capture on
    internal mic
    - LP: #685161, #714732
  * ALSA: hda: Use model=lg quirk for LG P1 Express to enable playback and
    capture
    - LP: #595482, #714732
  * drm/radeon/kms: don't apply 7xx HDP flush workaround on AGP
    - LP: #714732
  * drm/kms: remove spaces from connector names (v2)
    - LP: #714732
  * drm/radeon/kms: fix vram base calculation on rs780/rs880
    - LP: #714732
  * nohz: Fix printk_needs_cpu() return value on offline cpus
    - LP: #714732
  * nohz: Fix get_next_timer_interrupt() vs cpu hotplug
    - LP: #714732
  * nfsd: Fix possible BUG_ON firing in set_change_info
    - LP: #714732
  * NFS: Fix fcntl F_GETLK not reporting some conflicts
    - LP: #714732
  * sunrpc: prevent use-after-free on clearing XPT_BUSY
    - LP: #714732
  * hwmon: (adm1026) Allow 1 as a valid divider value
    - LP: #714732
  * hwmon: (adm1026) Fix setting fan_div
    - LP: #714732
  * EDAC: Fix workqueue-related crashes
    - LP: #714732
  * amd64_edac: Fix interleaving check
    - LP: #714732
  * ASoC: Fix swap of left and right channels for WM8993/4 speaker boost
    gain
    - LP: #714732
  * ASoC: Fix off by one error in WM8994 EQ register bank size
    - LP: #714732
  * ASoC: WM8580: Fix R8 initial value
    - LP: #714732
  * ASoC: fix deemphasis control in wm8904/55/60 codecs
    - LP: #714732
  * bootmem: Add alloc_bootmem_...