Fixup vesafb initialization patch which was mistakenly dropped.

Bug #611471 reported by Brad Figg on 2010-07-29
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
linux (Ubuntu)
Low
Unassigned
Declined for Jaunty by Martin Pitt
Hardy
Low
Unassigned
Karmic
Low
Unassigned
Lucid
Low
Unassigned

Bug Description

SRU Justification

Since dapper we have carried a vesafb modularization patch. This allows
us to make vesafb a module so we can control its insertion. When this
patch was rolled forward somewhere between dapper and hardy part of the
patch was lost. Such that we do not allocate sufficient memory for the
local info structure. This can lead to memory corruption and will lead
to a panic on unload of the module.

Please apply the attached patch to correct this problem.

TEST CASE: TBD

Brad Figg (brad-figg) wrote :
tags: added: patch
tags: added: kj-triage
Jonathan Riddell (jr) wrote :

Seems to have been uploaded to jaunty-proposed

needs debdiff on bug

needs a test case

needs approval from ubuntu-sru (subscribed)

Martin Pitt (pitti) wrote :

If it hasn't turned out to be a major problem by now, why do we need to fix this now? I understand lucid, and I also can agree with hardy as LTS, but jaunty and karmic are both rather old/mature already, and not LTS, and thus SRUs there have a diminishing return (likewise, we get very few SRU testing on those).

Martin Pitt (pitti) wrote :

Discussed with Stefan. This isn't an important bug, doesn't happen on a normal system (we don't remove modules), and if someone could get along with this bug in Jaunty for 16 months, they can certainly get along with it for the remaining two months of its life, so rejecting for jaunty. The risk and overhead for doing a new kernel just for this greatly outweighs the benefit IMHO.

The karmic upload fixes other things as well, so it's ok to slip in.

Stefan Bader (smb) wrote :

The reason I made that upload is that it was discovered that for a long time (Hardy to Maverick were affected) we carried a patch that had dropped parts of the patch which can cause nasty effects on module removal. Since the missing code is all the same for all releases, I was more looking at having a common code base.
But I can agree that this is maybe not sufficient for an update in Jaunty which contains only that patch. Especially as Jaunty is reaching end of life soon.

Changed in linux (Ubuntu Hardy):
importance: Undecided → Low
status: New → Fix Committed
Changed in linux (Ubuntu Karmic):
importance: Undecided → Low
status: New → Fix Committed
Stefan Bader (smb) on 2010-08-24
Changed in linux (Ubuntu Lucid):
importance: Undecided → Low
status: New → Fix Committed

Accepted linux into karmic-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

tags: added: verification-needed
Martin Pitt (pitti) wrote :

Accepted linux-ec2 into karmic-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Martin Pitt (pitti) wrote :

Accepted linux-mvl-dove into karmic-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Stefan Bader (smb) wrote :

Was released in 2.6.35-18.24

Changed in linux (Ubuntu):
importance: Undecided → Low
status: New → Fix Released
Martin Pitt (pitti) wrote :

Accepted linux into lucid-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Brad Figg (brad-figg) wrote :

We need some testing of the proposed kernel to see whether this has been resolved - please see comment #10 for information about how to get the proposed kernel.

Thanks

Martin Pitt (pitti) wrote :

Accepted linux into karmic-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Brad, please add a test case. Thanks.

Launchpad Janitor (janitor) wrote :
Download full text (43.7 KiB)

This bug was fixed in the package linux - 2.6.32-25.44

---------------
linux (2.6.32-25.44) lucid-proposed; urgency=low

  [ Brad Figg ]

  * SAUCE: (no-up) Modularize vesafb -- fix initialization
    - LP: #611471

  [ Stefan Bader ]

  * Revert "SAUCE: sync before umount to reduce time taken by ext4 umount"
    - LP: #543617, #585092

  [ Steve Conklin ]

  * Revert "SAUCE: tulip: Let dmfe handle davicom on non-sparc"
    - LP: #607824

  [ Tim Gardner ]

  * [Config] Added ums-cypress to udeb
    - LP: #576066

  [ Upstream Kernel Changes ]

  * Revert "PCI quirk: Disable MSI on VIA K8T890 systems"
    - LP: #607824
  * Revert "PCI quirks: disable msi on AMD rs4xx internal gfx bridges"
    - LP: #607824
  * Revert "(pre-stable) Input: psmouse - reset all types of mice before
    reconnecting"
    - LP: #607824
  * Revert "jbd: jbd-debug and jbd2-debug should be writable"
    - LP: #607824
  * Revert "ext4: Make fsync sync new parent directories in no-journal
    mode"
    - LP: #615548
  * Revert "ext4: Fix compat EXT4_IOC_ADD_GROUP"
    - LP: #615548
  * Revert "ext4: Conditionally define compat ioctl numbers"
    - LP: #615548
  * Revert "ext4: restart ext4_ext_remove_space() after transaction
    restart"
    - LP: #615548
  * Revert "ext4: Clear the EXT4_EOFBLOCKS_FL flag only when warranted"
    - LP: #615548
  * Revert "ext4: Avoid crashing on NULL ptr dereference on a filesystem
    error"
    - LP: #615548
  * Revert "ext4: Use bitops to read/modify i_flags in struct
    ext4_inode_info"
    - LP: #615548
  * Revert "ext4: Show journal_checksum option"
    - LP: #615548
  * Revert "ext4: check for a good block group before loading buddy pages"
    - LP: #615548
  * Revert "ext4: Prevent creation of files larger than RLIMIT_FSIZE using
    fallocate"
    - LP: #615548
  * Revert "ext4: Remove extraneous newlines in ext4_msg() calls"
    - LP: #615548
  * Revert "ext4: init statistics after journal recovery"
    - LP: #615548
  * Revert "ext4: clean up inode bitmaps manipulation in ext4_free_inode"
    - LP: #615548
  * Revert "ext4: Do not zero out uninitialized extents beyond i_size"
    - LP: #615548
  * Revert "ext4: don't scan/accumulate more pages than mballoc will
    allocate"
    - LP: #615548
  * Revert "ext4: stop issuing discards if not supported by device"
    - LP: #615548
  * Revert "ext4: check s_log_groups_per_flex in online resize code"
    - LP: #615548
  * Revert "ext4: fix quota accounting in case of fallocate"
    - LP: #615548
  * Revert "ext4: allow defrag (EXT4_IOC_MOVE_EXT) in 32bit compat mode"
    - LP: #615548
  * Revert "ext4: rename ext4_mb_release_desc() to ext4_mb_unload_buddy()"
    - LP: #615548
  * Revert "ext4: Remove unnecessary call to ext4_get_group_desc() in
    mballoc"
    - LP: #615548
  * Revert "ext4: fix memory leaks in error path handling of
    ext4_ext_zeroout()"
    - LP: #615548
  * Revert "ext4: check missed return value in ext4_sync_file()"
    - LP: #615548
  * Revert "ext4: Issue the discard operation *before* releasing the blocks
    to be reused"
    - LP: #615548
  * Revert "ext4: Fix buffer head leaks after calls to
    ext4_get_inode_loc()"
    - LP: #615548
  * Revert "ex...

Changed in linux (Ubuntu Lucid):
status: Fix Committed → Fix Released
Stefan Bader (smb) wrote :

After discussion this was withdrawn from fixing in Hardy.

Changed in linux (Ubuntu Hardy):
status: Fix Committed → Won't Fix
Brad Figg (brad-figg) on 2010-10-07
tags: added: verification-done
removed: verification-needed
Martin Pitt (pitti) wrote :

Brad, did you actually test the proposed kernel debs from the archive on this hardware? Thanks!

Martin Pitt (pitti) wrote :

Setting back to v-needed until previous question gets answered.

tags: added: verification-needed
removed: verification-done
Martin Pitt (pitti) wrote :

Accepted linux into karmic-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Steve Conklin (sconklin) wrote :

This bug is awaiting verification that the kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed' to 'verification-done'.

If verification is not done by Thursday, November 11, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package linux - 2.6.31-22.68

---------------
linux (2.6.31-22.68) karmic-proposed; urgency=low

  [ Andy Whitcroft ]

  * SAUCE: docs -- fix doc strings for fc_event_seq

  [ Brad Figg ]

  * SAUCE: (no-up) Modularize vesafb -- fix initialization
    - LP: #611471

  [ Chase Douglas ]

  * SAUCE: sched: update load count only once per cpu in 10 tick update
    window
    - LP: #513848

  [ Ike Panhc ]

  * SAUCE: agp/intel: Add second set of PCI-IDs for B43
    - LP: #640214
  * SAUCE: drm/i915: Add second set of PCI-IDs for B43
    - LP: #640214

  [ Steve Conklin ]

  * SAUCE: Fix compile error on ia64, powerpc, and sparc

  [ Upstream Kernel Changes ]

  * (pre-stable) x86-32, resume: do a global tlb flush in S4 resume
    - LP: #531309
  * PCI: Ensure we re-enable devices on resume
    - LP: #566149
 -- Steve Conklin <email address hidden> Fri, 22 Oct 2010 09:05:13 -0500

Changed in linux (Ubuntu Karmic):
status: Fix Committed → Fix Released
tags: added: testcase
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers