b43 has invalid "firmware:" field

Bug #488636 reported by Martin Pitt
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
linux (Ubuntu)
Medium
Tim Gardner
Lucid
Medium
Tim Gardner

Bug Description

This turned up while discussing https://blueprints.launchpad.net/ubuntu/+spec/desktop-lucid-jockey-hotplug-support with Tim Gardner at UDS.

In order for getting working hotplug support for jockey to install missing firmware, the "firmware:" links in modules need to be correct.

This currently is wrong for b43:

$ modinfo b43|grep firmware
firmware: FW13
$ modinfo b43legacy|grep firmware
firmware: FW10

however, neither of those files exist (or should).

Now, the devices need several files, but I suppose this could just take a particular representative, like b43/ucode14.fw for b43, and b43legacy/ucode11.fw .

Or isn't the b43 driver meant to use the kernel's normal firmware loading mechanism? (/lib/udev/firmware.sh)

Thanks!

Martin Pitt (pitti)
Changed in linux (Ubuntu):
assignee: nobody → Tim Gardner (timg-tpi)
Andy Whitcroft (apw)
tags: added: kernel-series-unknown
Revision history for this message
Tim Gardner (timg-tpi) wrote :

Martin - as far as I can tell, usage of the MODULE_FIRMWARE() macro in the b43 and b43legacy kernel drivers is just wrong. In order for the module information to be correctly displayed, the value passed to MODULE_FIRMWARE() must be fully instantiated at compile time.

Revision history for this message
Martin Pitt (pitti) wrote :

Tim, do you think it's possible to fix this by beta-1, so that we have enough time to test/fix jockey after that?

Changed in linux (Ubuntu Lucid):
importance: Undecided → Medium
milestone: none → ubuntu-10.04-beta-1
status: New → Triaged
Tim Gardner (timg-tpi)
Changed in linux (Ubuntu Lucid):
milestone: ubuntu-10.04-beta-1 → lucid-alpha-2
status: Triaged → In Progress
Revision history for this message
Andy Whitcroft (apw) wrote :

Pulled into lucid from mailing list.

Changed in linux (Ubuntu Lucid):
status: In Progress → Fix Committed
Andy Whitcroft (apw)
Changed in linux (Ubuntu Lucid):
milestone: lucid-alpha-2 → lucid-alpha-3
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (15.5 KiB)

This bug was fixed in the package linux - 2.6.32-11.15

---------------
linux (2.6.32-11.15) lucid; urgency=low

  [ Andy Whitcroft ]

  * Revert "(pre-stable) drm/radeon/kms: fix crtc vblank update for r600"
  * Revert "(pre-stable) sched: Fix balance vs hotplug race"
  * Revert "[Upstream] acerhdf: Limit modalias matching to supported
    boards"
  * Revert "[Upstream] mmc: prevent dangling block device from accessing
    stale queues"
  * Revert "SAUCE: Fix nx_enable reporting"
  * Revert "SAUCE: [x86] fix report of cs-limit nx-emulation"
  * Revert "SAUCE: [x86] implement cs-limit nx-emulation for ia32"
  * SAUCE: i915 -- disable powersave by default
    - LP: #492392

  [ Kees Cook ]

  * SAUCE: [x86] implement cs-limit nx-emulation for ia32
    - LP: #369978
  * SAUCE: [x86] fix report of cs-limit nx-emulation
    - LP: #454285
  * SAUCE: Fix nx_enable reporting
    - LP: #454285

  [ Tim Gardner ]

  * [Upstream] b43: Declare all possible firmware files.
    - LP: #488636
  * [Config] updateconfigs after adding pvscsi
    - LP: #497156
  * [Config] CONFIG_BT=m

  [ Upstream Kernel Changes ]

  * Revert "x86: Side-step lguest problem by only building cmpxchg8b_emu
    for pre-Pentium"
  * SCSI: ipr: fix EEH recovery
  * SCSI: qla2xxx: dpc thread can execute before scsi host has been added
  * SCSI: st: fix mdata->page_order handling
  * SCSI: fc class: fix fc_transport_init error handling
  * sched: Fix task_hot() test order
  * x86, cpuid: Add "volatile" to asm in native_cpuid()
  * sched: Select_task_rq_fair() must honour SD_LOAD_BALANCE
  * clockevents: Prevent clockevent_devices list corruption on cpu hotplug
  * pata_hpt3x2n: fix clock turnaround
  * pata_cmd64x: fix overclocking of UDMA0-2 modes
  * ASoC: wm8974: fix a wrong bit definition
  * sound: sgio2audio/pdaudiocf/usb-audio: initialize PCM buffer
  * ALSA: hda - Fix missing capsrc_nids for ALC88x
  * acerhdf: limit modalias matching to supported
    - LP: #435958
  * ACPI: EC: Fix MSI DMI detection
  * ACPI: Use the return result of ACPI lid notifier chain correctly
  * powerpc: Handle VSX alignment faults correctly in little-endian mode
  * ASoC: Do not write to invalid registers on the wm9712.
  * drm/radeon: fix build on 64-bit with some compilers.
  * USB: emi62: fix crash when trying to load EMI 6|2 firmware
  * USB: option: support hi speed for modem Haier CE100
  * USB: Fix a bug on appledisplay.c regarding signedness
  * USB: musb: gadget_ep0: avoid SetupEnd interrupt
  * Bluetooth: Prevent ill-timed autosuspend in USB driver
  * USB: rename usb_configure_device
  * USB: fix bugs in usb_(de)authorize_device
  * drivers/net/usb: Correct code taking the size of a pointer
  * x86: SGI UV: Fix writes to led registers on remote uv hubs
  * md: Fix unfortunate interaction with evms
  * dma: at_hdmac: correct incompatible type for argument 1 of
    'spin_lock_bh'
  * dma-debug: Do not add notifier when dma debugging is disabled.
  * dma-debug: Fix bug causing build warning
  * cifs: NULL out tcon, pSesInfo, and srvTcp pointers when chasing DFS
    referrals
  * x86/amd-iommu: Fix initialization failure panic
  * ioat3: fix p-disabled q-continuation
  * ioat2,3: put channel...

Changed in linux (Ubuntu Lucid):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Related blueprints