Comment 3 for bug 345710

Revision history for this message
TJ (tj) wrote :

I've found and fixed the bug. Submitting to mailing list and attaching patch here too.

Subject: [PATCH] UBUNTU: SAUCE: iwl3945: Don't queue rfkill_poll work when module is exiting

Bug: #345710

When the wireless interface is active and the iwl3945 module is unloaded the
call to ieee80211_unregister_hw() would call iwl3945_mac_stop() which would
restart the delayed workqueue for rfkill_poll. That workqueue had already been
cancelled so when the next work item was run (2 seconds later) the system would
suffer a hard lock-up because the module had been unloaded by then.

This patch implements STATUS_EXIT_PENDING checks in places where the rfkill_poll
work is scheduled, and moves the final workqueue cancellation to occur after the
call to ieee80211_unregister_hw().

Bug discovered, experienced and fix tested on my PC.

Signed-off-by: TJ <email address hidden>