sony-laptop module have not Sony Vaio FW Series support, patch included

Bug #307592 reported by Anton Veretenenko on 2008-12-13
14
Affects Status Importance Assigned to Milestone
linux (Ubuntu)
Medium
Andy Whitcroft
Intrepid
Medium
Andy Whitcroft

Bug Description

I don't really know where to post a patch, so I just opened it as bug.

This patch enables fn keys support in sony-laptop module for vaio fw series.

===

SRU Justification

Impact: sony Vaio FW hotkeys do not function

Fix Description: adds model specific quirk to enable these keys

Patch: http://kernel.ubuntu.com/git?p=ubuntu/ubuntu-intrepid.git;a=commit;h=0b6882eb9458b5d5962f6a874536149c68c82c49

Risks: low, this is a model specific quirk in a sony specific driver

TEST CASE: see bug

Related branches

Duane Hinnen (duanedesign) wrote :

you might find the following link usefull. It covers how to get your patch reviewed and possiblly included in Ubuntu. Good luck an thank you for your contribution.

https://wiki.ubuntu.com/SponsorshipProcess

Duane Hinnen (duanedesign) wrote :

you also might want to upload your patch to the open bugs concerning this problem. It looks like there are quite a few people who could use this. Check bug #29987 and bug #38323. Be sure to check the patch checkbox when uploading your patch.

Changed in linux:
importance: Undecided → Medium
status: New → Triaged
Andy Whitcroft (apw) on 2008-12-23
Changed in linux:
assignee: nobody → apw
status: Triaged → In Progress
Andy Whitcroft (apw) wrote :

@Anton Veretenenko -- the patch you have submitted looks sensible. In order to get this formally committed we would need to get you to sign off on the patch, to indicate you are happy to have it merged into the kernel, that you wrote it etc etc (see Documentation/SubmittingPatches). If you are happy to do that then we can help you get this merged both upstream and into Ubuntu. In the meantime I will build some test kernels so you can test the integration.

Andy Whitcroft (apw) wrote :

Ok I have built some test kernels based on the latest Intrepid kernel due for release to -proposed, with the patch attached above applied. Could you try these kernels and report back here, thanks:

    http://people.ubuntu.com/~apw/lp307592/

Changed in linux:
status: In Progress → Incomplete

Thanks!
I will read docs and test this as I can.
I have mapped more keys, so will update this patch.

@Andy Whitcroft, here is well formated signed off patch. I have added the last 2 keys.
I have tested your builds, it works good.

Andy Whitcroft (apw) wrote :

Thanks for the patch. I have built some test kernels on based on the latest Intrepid kernel with your patch. If you could test those and report back here that would be great. I will then propose this for SRU and look at helping this get pushed upstream. Kernels at the URL below:

    http://people.ubuntu.com/~apw/lp307592-intrepid/

Works good, keys recognized.

One question. This patch enable only keys but not brightness control itself (DSDT patching needed). Does it worth to merge into upstream? I have some thoughts to enable brightness control trough hardware registers for Ati card for this laptops then.

Andy Whitcroft (apw) wrote :

Yes it is worth pusing this upstream as a separate piece. It works in its own right and is useful. The brigtness will likely take longer to sort out too.

Andy Whitcroft (apw) on 2009-01-21
Changed in linux:
status: Incomplete → In Progress
Andy Whitcroft (apw) on 2009-03-19
Changed in linux:
status: In Progress → Fix Committed
assignee: nobody → apw
status: New → Fix Committed
importance: Undecided → Medium
Andy Whitcroft (apw) on 2009-03-19
description: updated
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package linux - 2.6.28-11.36

---------------
linux (2.6.28-11.36) jaunty; urgency=low

  [ Amit Kucheria ]

  * Updating imx51 configs one more time
  * Disable CONFIG_UEVENT_HELPER_PATH

  [ Anton Veretenenko ]

  * SAUCE: sony-laptop: add support for Sony Vaio FW series function/media
    keys
    - LP: #307592

  [ Brad Figg ]

  * Have AUFS use current VFS APIs so it can build with or without
    AppArmor.

  [ Bryan Wu ]

  * Build-in "Ram block device support" to boot up with initramfs
    - LP: #329098
  * Remove brd module from iop32x modules list
    - LP: #329098
  * Increase the CONFIG_BLK_DEV_RAM_SIZE to 8192 on i.MX51

  [ Ike Panhc ]

  * SAUCE: Fixing symbol name in HECI module
    - LP: #336549

  [ Manoj Iyer ]

  * SAUCE: Added quirk for Ralink rt2870 802.11n USB driver
    - LP: #326621

  [ Upstream Kernel Changes ]

  * udf:SAUCE (drop after 2.6.30): Fix oops when invalid character in
    filename occurs
    - LP: #321606

 -- Stefan Bader <email address hidden> Fri, 20 Mar 2009 16:52:08 +0100

Changed in linux:
status: Fix Committed → Fix Released
Martin Pitt (pitti) wrote :

Accepted linux into intrepid-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

tags: added: verification-needed
Pavek (avezzandrog) wrote :
Steve Beattie (sbeattie) on 2009-06-16
tags: added: hw-specific
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package linux - 2.6.27-14.41

---------------
linux (2.6.27-14.41) intrepid-proposed; urgency=low

  [ Stefan Bader ]

  * Revert "SAUCE: input: Blacklist digitizers from joydev.c"
    - LP: #300143

linux (2.6.27-14.40) intrepid-proposed; urgency=low

  [ Amit Kucheria ]

  * Disable DEVKMEM for all archs on Intrepid
    - LP: #354221
  * SAUCE: Quirk for BT USB device on MacbookPro to be reset before use
    - LP: #332443

  [ Andy Isaacson ]

  * LIRC_PVR150: depends on VIDEO_IVTV
    - LP: #341477
  * SAUCE: FSAM7400: select CHECK_SIGNATURE
    - LP: #341712

  [ Andy Whitcroft ]

  * SAUCE: hotkey quirks for various Zepto Znote and Fujitsu Amilo laptops
    - LP: #330259
  * SAUCE: unusual devs: add an entry for the ScanLogic SL11R-IDE 0.78
    - LP: #336189

  [ Anton Veretenenko ]

  * SAUCE: sony-laptop: add support for Sony Vaio FW series function/media
    keys
    - LP: #307592

  [ Ayaz Abdulla ]

  * SAUCE: forcedeth: msi interrupt fix
    - LP: #288281

  [ Chuck Short ]

  * SAUCE: [USB] Unusual Device support for Gold MP3 Player Energy
    - LP: #125250

  [ Ike Panhc ]

  * squashfs: correct misspelling
    - LP: #322306
  * SAUCE: Fixing symbol name in HECI module
    - LP: #336549
  * Copy header files for various kernel media driver
    - LP: #322732

  [ Stefan Bader ]

  * SAUCE: vgacon: Return the upper half of 512 character fonts
    - LP: #355057
  * SAUCE: input: Blacklist digitizers from joydev.c
    - LP: #300143

  [ Upstream Kernel Changes ]

  * libata: make sure port is thawed when skipping resets
    - LP: #269652
  * x86-64: fix int $0x80 -ENOSYS return
    - LP: #339743
  * rt2x00: Fix race conditions in flag handling
    - LP: #258985
  * USB: cdc-acm: Add another conexant modem to the quirks
    - LP: #323829
  * Bluetooth: Add fine grained mem_flags usage to btusb driver
    - LP: #268502
  * Bluetooth: Handle bulk URBs in btusb driver from notify callback
    - LP: #268502
  * Bluetooth: Submit bulk URBs along with interrupt URBs
    - LP: #268502
  * hwmon: (abituguru3) Match partial DMI board name strings
    - LP: #298798
  * x86: mtrr: don't modify RdDram/WrDram bits of fixed MTRRs
    - LP: #292619
  * sis190: add identifier for Atheros AR8021 PHY
    - LP: #247889
  * ath9k: implement IO serialization
    - LP: #373034
  * ath9k: AR9280 PCI devices must serialize IO as well
    - LP: #373034
  * acer-wmi: fix regression in backlight detection
    - LP: #333386

 -- Stefan Bader <email address hidden> Wed, 26 Aug 2009 11:48:11 +0200

Changed in linux (Ubuntu Intrepid):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers