CONFIG_AX25_DAMA_SLAVE not enabled

[Tim Gardner]

Hello,

i'd like to inform you about an upstream fix to the kernel for the kernel-ax25 code (see below).

With 2.6.24, the /proc code has changed. This broke /proc/sys/net/ax25/... if the config "CONFIG_AX25_DAMA_SLAVE is not set", as it is in ubuntu.

Ubuntu hardy ships with 2.6.24 and is affected. Thus /proc/sys/ax25 is not present.

The hot-fix without patch could be CONFIG_AX25_DAMA_SLAVE=y, because then the referenced function to the proc interface is not missing.

I tend to think it could be a good idea anyway to set CONFIG_AX25_DAMA_SLAVE=y. This option compiles support for DAMA into the kernel, but it still has to be enabled via /proc. Just being capable to do DAMA does not harm. Without this option, users who require DAMA need to recompile the kernel - which most users nowadays won't. DAMA Slave is user requirement for users in some areas..

I'm not sure why this option is not set in debian and ubuntu kernels, bat i assume it is for historical reasons (a little bit lesser RAM in use).

- Thomas Osterried

[Tim Gardner (timg-tpi)]

http://kernel.ubuntu.com/git?p=ubuntu/ubuntu-hardy.git;a=commit;h=e4e7e60316dd82e96398bdf731656b8a96843778

[Tim Gardner (timg-tpi)]

SRU Justification

Impact: Cannot use /proc interface for AX.25

Patch Description: Enable CONFIG_AX25_DAMA_SLAVE config option

Patch: http://kernel.ubuntu.com/git?p=ubuntu/ubuntu-hardy.git;a=commit;h=e4e7e60316dd82e96398bdf731656b8a96843778

Test Case: See bug description.

[Tim Gardner (timg-tpi)]

http://kernel.ubuntu.com/git?p=ubuntu/ubuntu-intrepid.git;a=commit;h=70b1914deea2bbe7cd3cb13a32759471d0fe29be

[Martin Pitt (pitti)]

linux 2.6.24-21 copied to hardy-updates.

[Martin Pitt (pitti)]

Sorry, this one wasn't in -proposed yet.

[Martin Pitt (pitti)]

Accepted into intrepid-proposed, please test and give feedback here. Please see https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

[Martin Pitt (pitti)]

Accepted into hardy-proposed, please test and give feedback here. Please see https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

[Martin Pitt (pitti)]

Accepted linux into hardy-proposed, please test and give feedback here. Please see https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

[Steve Beattie (sbeattie)]

This was fixed in Intrepid during the development cycle; I've verified that the released version of the Intrepid kernel has CONFIG_AX25_DAMA_SLAVE set to 'y'. Marking that task as Fix Released.

[Steve Beattie (sbeattie)]

I can confirm that the configuration for the kernel in 2.6.24-19.41 and 2.6.24-22.45 don't have the CONFIG_AX25_DAMA_SLAVE config option set, and that the kernel in hardy-proposed, 2.6.24-23.46 does have this setting set (for both i386 and amd64 kernels). Beyond that, I can verify that /proc/sys/net/ax25 appears when the ax25 module is loaded, but nothing appears in that directory; is that correct behavior?

Otherwise, the kernel in -proposed boots and appears to function here.

[Launchpad Janitor (janitor)]

This bug was fixed in the package linux - 2.6.24-23.46

---------------
linux (2.6.24-23.46) hardy-proposed; urgency=low

  [Alessio Igor Bogani]

  * rt: Updated PREEMPT_RT support to rt21
    - LP: #302138

  [Amit Kucheria]

  * SAUCE: Update lpia patches from moblin tree
    - LP: #291457

  [Andy Whitcroft]

  * SAUCE: replace gfs2_bitfit with upstream version to prevent oops
    - LP: #276641

  [Colin Ian King]

  * isdn: Do not validate ISDN net device address prior to interface-up
    - LP: #237306
  * hwmon: (coretemp) Add Penryn CPU to coretemp
    - LP: #235119
  * USB: add support for Motorola ROKR Z6 cellphone in mass storage mode
    - LP: #263217
  * md: fix an occasional deadlock in raid5
    - LP: #208551

  [Stefan Bader]

  * SAUCE: buildenv: Show CVE entries in printchanges
  * SAUCE: buildenv: Send git-ubuntu-log informational message to stderr
  * Xen: dma: avoid unnecessarily SWIOTLB bounce buffering
    - LP: #247148
  * Update openvz patchset to apply to latest stable tree.
    - LP: #301634
  * XEN: Fix FTBS with stable updates
    - LP: #301634

  [Steve Conklin]

  * Add HID quirk for dual USB gamepad
    - LP: #140608

  [Tim Gardner]

  * Enable CONFIG_AX25_DAMA_SLAVE=y
    - LP: #257684
  * SAUCE: Correctly blacklist Thinkpad r40e in ACPI
    - LP: #278794
  * SAUCE: ALPS touchpad for Dell Latitude E6500/E6400
    - LP: #270643

  [Upstream Kernel Changes]

  * Revert "[Bluetooth] Eliminate checks for impossible conditions in IRQ
    handler"
    - LP: #217659
  * KVM: VMX: Clear CR4.VMXE in hardware_disable
    - LP: #268981
  * iov_iter_advance() fix
    - LP: #231746
  * Fix off-by-one error in iov_iter_advance()
    - LP: #231746
  * USB: serial: ch341: New VID/PID for CH341 USB-serial
    - LP: #272485
  * x86: Fix 32-bit x86 MSI-X allocation leakage
    - LP: #273103
  * b43legacy: Fix failure in rate-adjustment mechanism
    - LP: #273143
  * x86: Reserve FIRST_DEVICE_VECTOR in used_vectors bitmap.
    - LP: #276334
  * openvz: merge missed fixes from vanilla 2.6.24 openvz branch
    - LP: #298059
  * openvz: some autofs related fixes
    - LP: #298059
  * openvz: fix ve stop deadlock after nfs connect
    - LP: #298059
  * openvz: fix netlink and rtnl inside container
    - LP: #298059
  * openvz: fix wrong size of ub0_percpu
    - LP: #298059
  * openvz: fix OOPS while stopping VE started before binfmt_misc.ko loaded
    - LP: #298059
  * x86-64: Fix "bytes left to copy" return value for copy_from_user()
  * NET: Fix race in dev_close(). (Bug 9750)
    - LP: #301608
  * IPV6: Fix IPsec datagram fragmentation
    - LP: #301608
  * IPV6: dst_entry leak in ip4ip6_err.
    - LP: #301608
  * IPV4: Remove IP_TOS setting privilege checks.
    - LP: #301608
  * IPCONFIG: The kernel gets no IP from some DHCP servers
    - LP: #301608
  * IPCOMP: Disable BH on output when using shared tfm
    - LP: #301608
  * IRQ_NOPROBE helper functions
    - LP: #301608
  * MIPS: Mark all but i8259 interrupts as no-probe.
    - LP: #301608
  * ub: fix up the conversion to sg_init_table()
    - LP: #301608
  * x86: adjust enable_NMI_through_LVT0()
    - LP: #301608
  * SCSI ips: handle scsi_add_host() failure, and other err cl...