Add Missing PCI ID to sky2 driver

Bug #237211 reported by Jason on 2008-06-03
Affects Status Importance Assigned to Milestone
linux (Ubuntu)
Canonical Kernel Team

Bug Description

Please add the following to drivers/net/sky2.c to support the Marvell Yukon 88E8040T shipped with Toshiba Satellite P305-S8822

{ PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x4355) }, /* 88E8040 */

I have applied the patch as described in the above ubuntuforum posting and everything works.

Hi Jason,

It looks like the driver has already been updated for the upcoming Intrepid Ibex release (see git commit below). I'll open a Hardy nomination for it to be considered as a stable release update for 8.04.2. Thanks.

ogasawara@yoji:~/ubuntu-intrepid$ git log -p a3b4fcedee5cf1d1342b85f1318c0fe1ff1727a9
commit a3b4fcedee5cf1d1342b85f1318c0fe1ff1727a9
Author: Stephen Hemminger <email address hidden>
Date: Sat Jun 14 10:32:15 2008 -0700

    sky2: 88E8040T pci device id

    Missed one pci id for 88E8040T.

    Signed-off-by: Stephen Hemminger <email address hidden>
    Signed-off-by: Jeff Garzik <email address hidden>

diff --git a/drivers/net/sky2.c b/drivers/net/sky2.c
index 62436b3..c8a5ef2 100644
--- a/drivers/net/sky2.c
+++ b/drivers/net/sky2.c
@@ -118,6 +118,7 @@ static const struct pci_device_id sky2_id_table[] = {
        { PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x4352) }, /* 88E8038 */
        { PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x4353) }, /* 88E8039 */
        { PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x4354) }, /* 88E8040 */
+ { PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x4355) }, /* 88E8040T */
        { PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x4356) }, /* 88EC033 */
        { PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x4357) }, /* 88E8042 */
        { PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x435A) }, /* 88E8048 */

Changed in linux:
status: New → Fix Released
assignee: nobody → ubuntu-kernel-team
importance: Undecided → Medium
status: New → Triaged
Changed in linux:
assignee: ubuntu-kernel-team → colin-king
Changed in linux:
status: Triaged → In Progress
Changed in linux:
assignee: colin-king → canonical-kernel-team
status: In Progress → Fix Committed
Martin Pitt (pitti) wrote :

Accepted into -proposed, please test and give feedback here. Please see for documentation how to enable and use -proposed. Thank you in advance!

Martin Pitt (pitti) wrote :

linux 2.6.24-21 copied to hardy-updates.

Changed in linux:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers