Hardy: [NETFILTER]: {ip,ip6,nfnetlink}_queue: fix SKB_LINEAR_ASSERT when mangling packet data
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
| linux (Ubuntu) |
Undecided
|
Unassigned | ||
| Hardy |
Medium
|
Tim Gardner |
Bug Description
A patch in the linux kernel from a while back hasn't made it into the Ubuntu kernel.
http://
If you check the sources it hasn't been applied but its in the main kernel since 2.6.23
Nick Ellery (nick.ellery) wrote : | #1 |
Leann Ogasawara (leannogasawara) wrote : | #2 |
Hi yanaventer,
Looks like this patch has made it's way into the Intrepid kernel. I'll open a Hardy nomination for them to consider backporting. Thanks.
ogasawara@
commit e2b58a67b91dec0
Author: Patrick McHardy <email address hidden>
Date: Tue Feb 19 17:17:52 2008 -0800
[NETFILTER]: {ip,ip6,
Changed in linux: | |
status: | New → Fix Released |
assignee: | nobody → ubuntu-kernel-team |
importance: | Undecided → Medium |
status: | New → Triaged |
Tim Gardner (timg-tpi) wrote : | #3 |
Changed in linux: | |
assignee: | ubuntu-kernel-team → timg-tpi |
milestone: | none → ubuntu-8.04.2 |
status: | Triaged → Fix Committed |
Tim Gardner (timg-tpi) wrote : | #4 |
SRU Justification
Impact: Fix kernel assert crash
Patch Description: Use skb_copy_expand instead of pskb_expand_head.
Test Case: See bug description
Martin Pitt (pitti) wrote : | #5 |
Accepted into -proposed, please test and give feedback here. Please see https:/
Steve Beattie (sbeattie) wrote : | #6 |
If we're going to apply this fix, do we not also need to commit http://
Steve Beattie (sbeattie) wrote : | #7 |
Marking this as verification-
The patch below asks for allocation of a copy with enough space for
mangled packet and the same amount of headroom as old sk_buff. While
looking at how the regression appeared (e2b58a67), I noticed the same
pattern in ipq_mangle_ipv6() and ipq_mangle_ipv4(). The patch corrects
those locations too.
git commit e2b58a67 is the fix referred to in comment 2 by Leann Ogasawara.
Tim Gardner (timg-tpi) wrote : | #8 |
@Steve - http://
Steve Beattie (sbeattie) wrote : Re: [Bug 236699] Re: Hardy: [NETFILTER]: {ip, ip6, nfnetlink}_queue: fix SKB_LINEAR_ASSERT when mangling packet data | #9 |
On Fri, Oct 03, 2008 at 03:21:25AM -0000, Tim Gardner wrote:
> @Steve - http://
> commit works fine with 2.6.24. Arnaud said he had trouble with 2.6.25.
@Tim - while that's true (he also claims that his mangling
works fine with 2.6.22), note that the original patch reported in
http://
2.6.24.4 thread starting at http://
exactly clear *which* 2.6.24 kernel Arnaud tried his mangling against
when he went back to look to see where the regression was introduced.
What I'd really like is a testcase that triggers the original bug, and
then we could work from there, but I expect we're not going to get that.
--
Steve Beattie
<email address hidden>
http://
Martin Pitt (pitti) wrote : | #10 |
linux 2.6.24-21 copied to hardy-updates.
Changed in linux: | |
status: | Fix Committed → Fix Released |
Package set to linux.