drm_sysfs_suspend uses KERN_ERR in printk

[Chris Jones]

I am running Ubuntu 8.04's kernel and when I resume from S3 suspend, a single
message is displayed on the console about drm_sysfs_suspend, which seems to
come from the function:

static int drm_sysfs_suspend(struct device *dev, pm_message_t state)

This doesn't appear to be an error, so presumably this should be KERN_INFO, not
KERN_ERR?

(less technical users often express surprise and concern when their laptop
comes out of suspend and prints scary messages at them, even if it does
actually work fine)

[Chris Jones (cmsj)]

err, I don't know why this is showing as relating to the OpenVZ kernel, I just entered a URL from upstream vanilla Linux kernel's bugzilla

[Chris Jones (cmsj)]

This is the wrong upstream.

[Chris Jones (cmsj)]

Since upstream reports that this printk is indeed incorrect and has submitted a patch to remove it, and that the impact of the patch should be essentially zero (the message isn't an error and doesn't convey any useful information, but is confusing and ugly), could this be included the next time a hardy kernel goes to -proposed?

[Leann Ogasawara (leannogasawara)]

Thanks Chris.

The patch has already been pulled in to the upcoming Intrepid kernel. I'll add a Hardy nomination for the kernel team to consider and am also providing the upstream git commit id and description for them to reference. Thanks.

commit 57f7bd5b455298dbe94227aa1fedbbfe63bbf252
Author: Jesse Barnes <email address hidden>
Date: Fri May 23 08:40:45 2008 -0700

    remove debug printk from DRM suspend path

    Not sure how this snuck upstream, but it really doesn't belong there. We
    don't need a KERN_ERR printk in the suspend path to know what's going on (at
    least not anymore).

    Signed-off-by: Jesse Barnes <email address hidden>
    Signed-off-by: Linus Torvalds <email address hidden>

[Colin Ian King (colin-king)]

SRU justification:

Impact: Remove KERN_ERR printk from drm_sysfs_suspend() as this is not
an error (presumably was added during development and debug and not
removed at a later point). Less technical may express concern when their
laptop comes out of suspend and prints kernel error messages at them,
even if it does actually work fine.

Testcase: Suspend and resume cycle on laptop. Error message should not
be present.

Patch from upstream cherry pick 57f7bd5b455298dbe94227aa1fedbbfe63bbf252

[Martin Pitt (pitti)]

Accepted into -proposed, please test and give feedback here

[Mark Rowan (mark-tamias)]

I haven't yet been offered an updated Hardy kernel which fixes this issue; is it upcoming or will the patch only be released to future Intrepid users?

[Tim Gardner (timg-tpi)]

You have to enable -proposed in System/Administration/Synaptic Package Manager.

[Mark Rowan (mark-tamias)]

Thanks, Tim. I should have mentioned that this is, of course, already enabled.

I've had several linux-image update packages since Martin's message on 4th June (I'm currently running linux-image-2.6.24-18.32) but none of the changelogs seem to have mentioned the drm_sysfs_suspend issue, nor has the issue been fixed.

Is mine the latest linux-image from hardy-proposed or am I missing something simple?

[Mark Rowan (mark-tamias)]

Hmm.. make that linux-image-2.6.24-19, which I've inexplicably just been offered! The kernel update is installed, and I can confirm that the fix for this bug is successful.

[Martin Pitt (pitti)]

Copied to hardy-updates. The new kernel was tested extensively by many people, who reported back in other bug reports. Due to lack of feedback, this particular bug was not confirmed to be tested, though. Please report back here if the bug still occurs for you with the new kernel packages, then we will reopen this bug.

[Leann Ogasawara (leannogasawara)]

Marking this "Fix Released" against Intrepid kernel. Thanks.

[Launchpad Janitor (janitor)]

Per a decision made by the Ubuntu Kernel Team, bugs will longer be assigned to the ubuntu-kernel-team in Launchpad as part of the bug triage process. The ubuntu-kernel-team is being unassigned from this bug report. Refer to https://wiki.ubuntu.com/KernelTeamBugPolicies for more information. Thanks.